From: d.granat@samsung.com (Daniel Granat)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH] Add coccinelle script that makes sure that tables are NULL terminated
Date: Wed, 22 Apr 2015 13:16:54 +0200 [thread overview]
Message-ID: <55378326.4030707@samsung.com> (raw)
In-Reply-To: <55378124.2060908@gmail.com>
Ok, but I'm going to improve the script. New coccinelle release give my
opportunity to simplify this a lot, so I'll send next version of my
patch soon.
Best regards,
--
Daniel Granat
Junior Software Engineer
Samsung R&D Institute Poland (SRPOL)
Al. Armii Ludowej 14, 00-638 Warszawa, Poland
On 04/22/2015 01:08 PM, Krzysztof Kozlowski wrote:
> W dniu 27.02.2015 o 22:21, Daniel Granat pisze:
>> Signed-off-by: Daniel Granat <d.granat@samsung.com>
>> ---
>> scripts/coccinelle/misc/device_id_tables.cocci | 95 ++++++++++++++++++++++++++
>> 1 file changed, 95 insertions(+)
>> create mode 100644 scripts/coccinelle/misc/device_id_tables.cocci
>
> I like the idea and I think it is useful.
> Tested-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>
> However applying the patch gave some warnings:
>
> Applying: Add coccinelle script that makes sure that tables are NULL terminated
> /home/dev/linux/linux/.git/rebase-apply/patch:64: space before tab in indent.
> coccilib.report.print_report(p1[0],msg)
> /home/dev/linux/linux/.git/rebase-apply/patch:89: trailing whitespace.
> struct matched_name arr[] = {
> /home/dev/linux/linux/.git/rebase-apply/patch:99: trailing whitespace.
> struct matched_name arr[] = {
> /home/dev/linux/linux/.git/rebase-apply/patch:106: new blank line at EOF.
> +
> warning: 4 lines add whitespace errors.
>
> Best regards,
> Krzysztof
>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Granat <d.granat@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>,
Julia.Lawall@lip6.fr, cocci@systeme.lip6.fr,
linux-kernel@vger.kernel.org
Cc: Gilles.Muller@lip6.fr, nicolas.palix@imag.fr
Subject: Re: [PATCH] Add coccinelle script that makes sure that tables are NULL terminated
Date: Wed, 22 Apr 2015 13:16:54 +0200 [thread overview]
Message-ID: <55378326.4030707@samsung.com> (raw)
In-Reply-To: <55378124.2060908@gmail.com>
Ok, but I'm going to improve the script. New coccinelle release give my
opportunity to simplify this a lot, so I'll send next version of my
patch soon.
Best regards,
--
Daniel Granat
Junior Software Engineer
Samsung R&D Institute Poland (SRPOL)
Al. Armii Ludowej 14, 00-638 Warszawa, Poland
On 04/22/2015 01:08 PM, Krzysztof Kozlowski wrote:
> W dniu 27.02.2015 o 22:21, Daniel Granat pisze:
>> Signed-off-by: Daniel Granat <d.granat@samsung.com>
>> ---
>> scripts/coccinelle/misc/device_id_tables.cocci | 95 ++++++++++++++++++++++++++
>> 1 file changed, 95 insertions(+)
>> create mode 100644 scripts/coccinelle/misc/device_id_tables.cocci
>
> I like the idea and I think it is useful.
> Tested-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>
> However applying the patch gave some warnings:
>
> Applying: Add coccinelle script that makes sure that tables are NULL terminated
> /home/dev/linux/linux/.git/rebase-apply/patch:64: space before tab in indent.
> coccilib.report.print_report(p1[0],msg)
> /home/dev/linux/linux/.git/rebase-apply/patch:89: trailing whitespace.
> struct matched_name arr[] = {
> /home/dev/linux/linux/.git/rebase-apply/patch:99: trailing whitespace.
> struct matched_name arr[] = {
> /home/dev/linux/linux/.git/rebase-apply/patch:106: new blank line at EOF.
> +
> warning: 4 lines add whitespace errors.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2015-04-22 11:16 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 13:21 [Cocci] [PATCH] Add coccinelle script that makes sure that tables are NULL terminated Daniel Granat
2015-02-27 13:21 ` Daniel Granat
2015-03-27 10:32 ` [Cocci] " Daniel Granat
2015-03-27 10:32 ` Daniel Granat
2015-04-22 11:08 ` [Cocci] " Krzysztof Kozlowski
2015-04-22 11:08 ` Krzysztof Kozlowski
2015-04-22 11:16 ` Daniel Granat [this message]
2015-04-22 11:16 ` Daniel Granat
2015-05-18 11:29 ` [Cocci] [PATCH v2] " Daniel Granat
2015-05-18 11:29 ` Daniel Granat
2015-05-19 8:57 ` [Cocci] " Julia Lawall
2015-05-19 8:57 ` Julia Lawall
2015-05-19 11:58 ` [Cocci] [PATCH v3] Added tables i2c_device_id and platform_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name Daniel Granat
2015-05-19 11:58 ` Daniel Granat
2015-05-25 20:19 ` [Cocci] " Julia Lawall
2015-05-25 20:19 ` Julia Lawall
2015-06-02 16:10 ` [Cocci] [PATCH v4] Added tables i2c_device_id and platform_device_id for Daniel Granat
2015-06-02 16:10 ` Daniel Granat
2015-06-02 16:10 ` [Cocci] [PATCH v4] Added tables i2c_device_id and platform_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name Daniel Granat
2015-06-02 16:10 ` Daniel Granat
2015-06-03 9:42 ` [Cocci] " Julia Lawall
2015-06-03 9:42 ` Julia Lawall
2015-06-23 11:02 ` [Cocci] [PATCH v5] Added tables (i2c/platform)_device_id " Daniel Granat
2015-06-23 11:02 ` Daniel Granat
2015-06-23 11:50 ` [Cocci] " Krzysztof Kozlowski
2015-06-23 11:50 ` Krzysztof Kozlowski
2015-06-23 12:25 ` [Cocci] " Julia Lawall
2015-06-23 12:25 ` Julia Lawall
2015-06-26 14:39 ` [Cocci] [PATCH v6] coccinelle: Improve checking for missing NULL terminators Daniel Granat
2015-06-26 14:39 ` Daniel Granat
2015-10-23 15:31 ` [Cocci] " Daniel Granat
2015-10-23 15:31 ` Daniel Granat
2015-10-23 19:35 ` [Cocci] " Julia Lawall
2015-10-23 19:35 ` Julia Lawall
2015-10-26 21:46 ` [Cocci] " Michal Marek
2015-10-26 21:46 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55378326.4030707@samsung.com \
--to=d.granat@samsung.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.