From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/8] block: Add QMP support for streaming to an intermediate layer
Date: Wed, 22 Apr 2015 19:26:09 +0200 [thread overview]
Message-ID: <5537D9B1.5050403@redhat.com> (raw)
In-Reply-To: <65b2cc1b55bd7869244ce9bebcf671ddc15ac7d6.1429196435.git.berto@igalia.com>
On 16.04.2015 17:12, Alberto Garcia wrote:
> This patch makes the 'device' paramater of the 'block-stream' command
> accept a node name as well as a device name.
>
> In addition to that, operation blockers will be checked in all
> intermediate nodes between the top and the base node.
>
> Since qmp_block_stream() now uses the error from bdrv_lookup_bs() and
> no longer returns DeviceNotFound, iotest 030 is updated to expect
> GenericError instead.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> blockdev.c | 20 ++++++++++----------
> qapi/block-core.json | 10 +++++++---
> tests/qemu-iotests/030 | 2 +-
> 3 files changed, 18 insertions(+), 14 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2015-04-22 17:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 15:12 [Qemu-devel] [PATCH v4 0/8] Support streaming to an intermediate layer Alberto Garcia
2015-04-16 15:12 ` [Qemu-devel] [PATCH 1/8] block: keep a list of block jobs Alberto Garcia
2015-04-22 20:00 ` Eric Blake
2015-04-16 15:12 ` [Qemu-devel] [PATCH 2/8] block: allow block jobs in any arbitrary node Alberto Garcia
2015-04-22 17:15 ` Max Reitz
2015-04-22 20:06 ` Eric Blake
2015-04-23 9:04 ` Alberto Garcia
2015-04-16 15:12 ` [Qemu-devel] [PATCH 3/8] block: never cancel a streaming job without running stream_complete() Alberto Garcia
2015-04-16 15:12 ` [Qemu-devel] [PATCH 4/8] block: Support streaming to an intermediate layer Alberto Garcia
2015-04-22 17:23 ` Max Reitz
2015-04-16 15:12 ` [Qemu-devel] [PATCH 5/8] block: Add QMP support for " Alberto Garcia
2015-04-22 17:26 ` Max Reitz [this message]
2015-04-22 20:10 ` Eric Blake
2015-04-16 15:12 ` [Qemu-devel] [PATCH 6/8] docs: Document how to stream " Alberto Garcia
2015-04-22 17:29 ` Max Reitz
2015-04-22 19:27 ` Eric Blake
2015-04-16 15:12 ` [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial() Alberto Garcia
2015-04-22 17:54 ` Max Reitz
2015-04-22 19:38 ` Eric Blake
2015-04-22 19:52 ` Alberto Garcia
2015-04-16 15:12 ` [Qemu-devel] [PATCH 8/8] qemu-iotests: test streaming to an intermediate layer Alberto Garcia
2015-04-22 17:56 ` Max Reitz
2015-04-22 19:54 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5537D9B1.5050403@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.