All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Kukjin Kim <kgene@kernel.org>
Subject: Re: [PATCH] ARM: exynos: Fix wake-up interrupts for Exynos3250
Date: Thu, 23 Apr 2015 09:24:41 +0900	[thread overview]
Message-ID: <55383BC9.5010604@samsung.com> (raw)
In-Reply-To: <1429724452-26563-1-git-send-email-marc.zyngier@arm.com>

Hi Marc,

On 04/23/2015 02:40 AM, Marc Zyngier wrote:
> Commit 8b283c025443 (ARM: exynos4/5: convert pmu wakeup to
> stacked domains) changed the Exynos PMU code to use stacked
> domains. This has led to a number of interrupt numbers to be
> fixed.
> 
> In the meantime, support for Exynos 3250 was added, missing
> the required change to this platform. This amounts to revert
> ace283a04a4a (ARM: EXYNOS: Fix wrong hwirq of RTC interrupt
> for Exynos3250 SoC), as the initial patch was right, just a
> bit early...
> 
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  arch/arm/mach-exynos/suspend.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
> index 3e6aea7..40dce36 100644
> --- a/arch/arm/mach-exynos/suspend.c
> +++ b/arch/arm/mach-exynos/suspend.c
> @@ -87,8 +87,8 @@ static unsigned int exynos_pmu_spare3;
>  static u32 exynos_irqwake_intmask = 0xffffffff;
>  
>  static const struct exynos_wkup_irq exynos3250_wkup_irq[] = {
> -	{ 105, BIT(1) }, /* RTC alarm */
> -	{ 106, BIT(2) }, /* RTC tick */
> +	{ 73, BIT(1) }, /* RTC alarm */
> +	{ 74, BIT(2) }, /* RTC tick */
>  	{ /* sentinel */ },
>  };
>  
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo Choi

WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: exynos: Fix wake-up interrupts for Exynos3250
Date: Thu, 23 Apr 2015 09:24:41 +0900	[thread overview]
Message-ID: <55383BC9.5010604@samsung.com> (raw)
In-Reply-To: <1429724452-26563-1-git-send-email-marc.zyngier@arm.com>

Hi Marc,

On 04/23/2015 02:40 AM, Marc Zyngier wrote:
> Commit 8b283c025443 (ARM: exynos4/5: convert pmu wakeup to
> stacked domains) changed the Exynos PMU code to use stacked
> domains. This has led to a number of interrupt numbers to be
> fixed.
> 
> In the meantime, support for Exynos 3250 was added, missing
> the required change to this platform. This amounts to revert
> ace283a04a4a (ARM: EXYNOS: Fix wrong hwirq of RTC interrupt
> for Exynos3250 SoC), as the initial patch was right, just a
> bit early...
> 
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  arch/arm/mach-exynos/suspend.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
> index 3e6aea7..40dce36 100644
> --- a/arch/arm/mach-exynos/suspend.c
> +++ b/arch/arm/mach-exynos/suspend.c
> @@ -87,8 +87,8 @@ static unsigned int exynos_pmu_spare3;
>  static u32 exynos_irqwake_intmask = 0xffffffff;
>  
>  static const struct exynos_wkup_irq exynos3250_wkup_irq[] = {
> -	{ 105, BIT(1) }, /* RTC alarm */
> -	{ 106, BIT(2) }, /* RTC tick */
> +	{ 73, BIT(1) }, /* RTC alarm */
> +	{ 74, BIT(2) }, /* RTC tick */
>  	{ /* sentinel */ },
>  };
>  
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo Choi

  parent reply	other threads:[~2015-04-23  0:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22 17:40 [PATCH] ARM: exynos: Fix wake-up interrupts for Exynos3250 Marc Zyngier
2015-04-22 17:40 ` Marc Zyngier
2015-04-23  0:15 ` Krzysztof Kozlowski
2015-04-23  0:15   ` Krzysztof Kozlowski
2015-04-27  0:53   ` Kukjin Kim
2015-04-27  0:53     ` Kukjin Kim
2015-05-28  9:55     ` Marc Zyngier
2015-05-28  9:55       ` Marc Zyngier
2015-05-28 23:51       ` Krzysztof Kozlowski
2015-05-28 23:51         ` Krzysztof Kozlowski
2015-04-23  0:24 ` Chanwoo Choi [this message]
2015-04-23  0:24   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55383BC9.5010604@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.