From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] adjust assertion in alloc_heap_pages()
Date: Thu, 23 Apr 2015 10:07:30 +0100 [thread overview]
Message-ID: <5538B652.7080905@citrix.com> (raw)
In-Reply-To: <5538AB510200007800074F3A@mail.emea.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 747 bytes --]
On 23/04/15 07:20, Jan Beulich wrote:
> Older gcc warns (and due to -Werror fails) on this ASSERT() now that
> "node" is of unsigned type. Make it more useful at once.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Coverity-ID: 1055630
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -604,7 +604,7 @@ static struct page_info *alloc_heap_page
> }
> first_node = node;
>
> - ASSERT(node >= 0);
> + ASSERT(node < MAX_NUMNODES);
> ASSERT(zone_lo <= zone_hi);
> ASSERT(zone_hi < NR_ZONES);
>
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 1707 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-04-23 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 6:20 [PATCH] adjust assertion in alloc_heap_pages() Jan Beulich
2015-04-23 9:07 ` Andrew Cooper [this message]
2015-04-23 9:18 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5538B652.7080905@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.