* [PATCH] adjust assertion in alloc_heap_pages()
@ 2015-04-23 6:20 Jan Beulich
2015-04-23 9:07 ` Andrew Cooper
2015-04-23 9:18 ` Tim Deegan
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2015-04-23 6:20 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Campbell, Keir Fraser, Ian Jackson, Tim Deegan
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
Older gcc warns (and due to -Werror fails) on this ASSERT() now that
"node" is of unsigned type. Make it more useful at once.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -604,7 +604,7 @@ static struct page_info *alloc_heap_page
}
first_node = node;
- ASSERT(node >= 0);
+ ASSERT(node < MAX_NUMNODES);
ASSERT(zone_lo <= zone_hi);
ASSERT(zone_hi < NR_ZONES);
[-- Attachment #2: node-assert.patch --]
[-- Type: text/plain, Size: 513 bytes --]
adjust assertion in alloc_heap_pages()
Older gcc warns (and due to -Werror fails) on this ASSERT() now that
"node" is of unsigned type. Make it more useful at once.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -604,7 +604,7 @@ static struct page_info *alloc_heap_page
}
first_node = node;
- ASSERT(node >= 0);
+ ASSERT(node < MAX_NUMNODES);
ASSERT(zone_lo <= zone_hi);
ASSERT(zone_hi < NR_ZONES);
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] adjust assertion in alloc_heap_pages()
2015-04-23 6:20 [PATCH] adjust assertion in alloc_heap_pages() Jan Beulich
@ 2015-04-23 9:07 ` Andrew Cooper
2015-04-23 9:18 ` Tim Deegan
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2015-04-23 9:07 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Ian Campbell, Ian Jackson, Keir Fraser, Tim Deegan
[-- Attachment #1.1: Type: text/plain, Size: 747 bytes --]
On 23/04/15 07:20, Jan Beulich wrote:
> Older gcc warns (and due to -Werror fails) on this ASSERT() now that
> "node" is of unsigned type. Make it more useful at once.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Coverity-ID: 1055630
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -604,7 +604,7 @@ static struct page_info *alloc_heap_page
> }
> first_node = node;
>
> - ASSERT(node >= 0);
> + ASSERT(node < MAX_NUMNODES);
> ASSERT(zone_lo <= zone_hi);
> ASSERT(zone_hi < NR_ZONES);
>
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 1707 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] adjust assertion in alloc_heap_pages()
2015-04-23 6:20 [PATCH] adjust assertion in alloc_heap_pages() Jan Beulich
2015-04-23 9:07 ` Andrew Cooper
@ 2015-04-23 9:18 ` Tim Deegan
1 sibling, 0 replies; 3+ messages in thread
From: Tim Deegan @ 2015-04-23 9:18 UTC (permalink / raw)
To: Jan Beulich; +Cc: Ian Campbell, xen-devel, Keir Fraser, Ian Jackson
At 07:20 +0100 on 23 Apr (1429773633), Jan Beulich wrote:
> Older gcc warns (and due to -Werror fails) on this ASSERT() now that
> "node" is of unsigned type. Make it more useful at once.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Tim Deegan <tim@xen.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-23 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-23 6:20 [PATCH] adjust assertion in alloc_heap_pages() Jan Beulich
2015-04-23 9:07 ` Andrew Cooper
2015-04-23 9:18 ` Tim Deegan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.