All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
	eric.auger@st.com, qemu-devel@nongnu.org,
	peter.maydell@linaro.org, agraf@suse.de
Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu,
	patches@linaro.org
Subject: Re: [PATCH v2 1/2] kvm-all.c: add qemu_irq/gsi hash table and utility routines
Date: Thu, 23 Apr 2015 17:21:30 +0200	[thread overview]
Message-ID: <55390DFA.70201@linaro.org> (raw)
In-Reply-To: <55390E40.5000503@redhat.com>

On 04/23/2015 05:22 PM, Paolo Bonzini wrote:
> 
> 
> On 23/04/2015 17:08, Eric Auger wrote:
>>  int kvm_irqchip_add_irqfd_notifier(KVMState *s, EventNotifier *n,
>>                                     EventNotifier *rn, int virq);
>>  int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
>> +int kvm_irqchip_add_qemuirq_irqfd_notifier(KVMState *s, EventNotifier *n,
>> +                                           EventNotifier *rn, qemu_irq irq);
>> +int kvm_irqchip_remove_qemuirq_irqfd_notifier(KVMState *s, EventNotifier *n,
>> +                                              qemu_irq irq);
> 
> 
> Perhaps rename the existing ones to
> 
> kvm_irqchip_add_irqfd_notifier_gsi
> kvm_irqchip_remove_irqfd_notifier_gsi
> 
> and change the new ones to kvm_irqchip_add_irqfd_notifier and
> kvm_irqchip_remove_irqfd_notifier?
OK thanks!

Eric
> 
> Okay with that change; include it in the vfio-platform series and I'll
> ack it.
> 
> Paolo
> 

WARNING: multiple messages have this Message-ID (diff)
From: Eric Auger <eric.auger@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
	eric.auger@st.com, qemu-devel@nongnu.org,
	peter.maydell@linaro.org, agraf@suse.de
Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu,
	christoffer.dall@linaro.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] kvm-all.c: add qemu_irq/gsi hash table and utility routines
Date: Thu, 23 Apr 2015 17:21:30 +0200	[thread overview]
Message-ID: <55390DFA.70201@linaro.org> (raw)
In-Reply-To: <55390E40.5000503@redhat.com>

On 04/23/2015 05:22 PM, Paolo Bonzini wrote:
> 
> 
> On 23/04/2015 17:08, Eric Auger wrote:
>>  int kvm_irqchip_add_irqfd_notifier(KVMState *s, EventNotifier *n,
>>                                     EventNotifier *rn, int virq);
>>  int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
>> +int kvm_irqchip_add_qemuirq_irqfd_notifier(KVMState *s, EventNotifier *n,
>> +                                           EventNotifier *rn, qemu_irq irq);
>> +int kvm_irqchip_remove_qemuirq_irqfd_notifier(KVMState *s, EventNotifier *n,
>> +                                              qemu_irq irq);
> 
> 
> Perhaps rename the existing ones to
> 
> kvm_irqchip_add_irqfd_notifier_gsi
> kvm_irqchip_remove_irqfd_notifier_gsi
> 
> and change the new ones to kvm_irqchip_add_irqfd_notifier and
> kvm_irqchip_remove_irqfd_notifier?
OK thanks!

Eric
> 
> Okay with that change; include it in the vfio-platform series and I'll
> ack it.
> 
> Paolo
> 

  reply	other threads:[~2015-04-23 15:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 15:08 [PATCH v2 0/2] add qemu_irq/gsi hashtable Eric Auger
2015-04-23 15:08 ` [Qemu-devel] " Eric Auger
2015-04-23 15:08 ` [PATCH v2 1/2] kvm-all.c: add qemu_irq/gsi hash table and utility routines Eric Auger
2015-04-23 15:08   ` [Qemu-devel] " Eric Auger
2015-04-23 15:22   ` Paolo Bonzini
2015-04-23 15:22     ` [Qemu-devel] " Paolo Bonzini
2015-04-23 15:21     ` Eric Auger [this message]
2015-04-23 15:21       ` Eric Auger
2015-04-23 15:08 ` [PATCH v2 2/2] intc: arm_gic_kvm: set the qemu_irq/gsi mapping Eric Auger
2015-04-23 15:08   ` [Qemu-devel] " Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55390DFA.70201@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=eric.auger@st.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.