All of lore.kernel.org
 help / color / mirror / Atom feed
* nfs-utils: Allow users to disable mount option rewriting via norewriteopts mount option
@ 2015-04-20 18:34 Gregory Boyce
  2015-04-24 13:18 ` Steve Dickson
  0 siblings, 1 reply; 3+ messages in thread
From: Gregory Boyce @ 2015-04-20 18:34 UTC (permalink / raw)
  To: linux-nfs; +Cc: Gregory Boyce

Allow users to disable mount option rewriting via norewriteopts mount option.
This was required in our case in order to allow mounting a filer which 
inappropriately responded via the wrong interface.

Signed-off-by: Gregory Boyce <gregory.boyce@gmail.com>
---
  utils/mount/stropts.c | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
index df67fac..bbda754 100644
--- a/utils/mount/stropts.c
+++ b/utils/mount/stropts.c
@@ -534,6 +534,14 @@ nfs_rewrite_pmap_mount_options(struct mount_options *options, int checkv4)
  	struct pmap mnt_pmap;

  	/*
+	 * "norewriteopts" option bypasses the options rewriting
+	 */
+	if (po_contains(options, "norewriteopts") == PO_FOUND) {
+		po_remove_all(options, "norewriteopts");
+		return 1;
+	}
+
+	/*
  	 * Version and transport negotiation is not required
  	 * and does not work for RDMA mounts.
  	 */
-- 
2.3.2 (Apple Git-55)


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: nfs-utils: Allow users to disable mount option rewriting via norewriteopts mount option
  2015-04-20 18:34 nfs-utils: Allow users to disable mount option rewriting via norewriteopts mount option Gregory Boyce
@ 2015-04-24 13:18 ` Steve Dickson
  2015-04-24 15:34   ` Gregory Boyce
  0 siblings, 1 reply; 3+ messages in thread
From: Steve Dickson @ 2015-04-24 13:18 UTC (permalink / raw)
  To: Gregory Boyce, linux-nfs

Hello,

On 04/20/2015 02:34 PM, Gregory Boyce wrote:
> Allow users to disable mount option rewriting via norewriteopts mount option.
> This was required in our case in order to allow mounting a filer 
> which inappropriately responded via the wrong interface.
Why are we adding a mount option to fix a broken server??

steved.

> 
> Signed-off-by: Gregory Boyce <gregory.boyce@gmail.com>
> ---
>  utils/mount/stropts.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index df67fac..bbda754 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -534,6 +534,14 @@ nfs_rewrite_pmap_mount_options(struct mount_options *options, int checkv4)
>      struct pmap mnt_pmap;
> 
>      /*
> +     * "norewriteopts" option bypasses the options rewriting
> +     */
> +    if (po_contains(options, "norewriteopts") == PO_FOUND) {
> +        po_remove_all(options, "norewriteopts");
> +        return 1;
> +    }
> +
> +    /*
>       * Version and transport negotiation is not required
>       * and does not work for RDMA mounts.
>       */

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: nfs-utils: Allow users to disable mount option rewriting via norewriteopts mount option
  2015-04-24 13:18 ` Steve Dickson
@ 2015-04-24 15:34   ` Gregory Boyce
  0 siblings, 0 replies; 3+ messages in thread
From: Gregory Boyce @ 2015-04-24 15:34 UTC (permalink / raw)
  To: Steve Dickson, linux-nfs



On April 24, 2015 9:18:44 AM EDT, Steve Dickson <SteveD@redhat.com> wrote:
>Hello,
>
>On 04/20/2015 02:34 PM, Gregory Boyce wrote:
>> Allow users to disable mount option rewriting via norewriteopts mount
>option.
>> This was required in our case in order to allow mounting a filer 
>> which inappropriately responded via the wrong interface.
>Why are we adding a mount option to fix a broken server??
>
>steved.
>
>

Sometimes you only control the client, and it's useful to have the option to interoperate.

--
Greg

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-24 15:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-20 18:34 nfs-utils: Allow users to disable mount option rewriting via norewriteopts mount option Gregory Boyce
2015-04-24 13:18 ` Steve Dickson
2015-04-24 15:34   ` Gregory Boyce

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.