* [Qemu-trivial] [PATCH] hostmem: Fix mem-path property name in error report
@ 2015-04-24 17:41 ` Jan Kiszka
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2015-04-24 17:41 UTC (permalink / raw)
To: qemu-trivial; +Cc: qemu-devel
The subtle difference between "property not found" and "property not
set" is already confusing enough.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
backends/hostmem-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
index 5179994..4b55361 100644
--- a/backends/hostmem-file.c
+++ b/backends/hostmem-file.c
@@ -43,7 +43,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
return;
}
if (!fb->mem_path) {
- error_setg(errp, "mem_path property not set");
+ error_setg(errp, "mem-path property not set");
return;
}
#ifndef CONFIG_LINUX
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] hostmem: Fix mem-path property name in error report
@ 2015-04-24 17:41 ` Jan Kiszka
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2015-04-24 17:41 UTC (permalink / raw)
To: qemu-trivial; +Cc: qemu-devel
The subtle difference between "property not found" and "property not
set" is already confusing enough.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
backends/hostmem-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
index 5179994..4b55361 100644
--- a/backends/hostmem-file.c
+++ b/backends/hostmem-file.c
@@ -43,7 +43,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
return;
}
if (!fb->mem_path) {
- error_setg(errp, "mem_path property not set");
+ error_setg(errp, "mem-path property not set");
return;
}
#ifndef CONFIG_LINUX
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] hostmem: Fix mem-path property name in error report
2015-04-24 17:41 ` [Qemu-devel] " Jan Kiszka
@ 2015-04-24 19:00 ` Peter Crosthwaite
-1 siblings, 0 replies; 6+ messages in thread
From: Peter Crosthwaite @ 2015-04-24 19:00 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, qemu-devel
On Fri, Apr 24, 2015 at 10:41 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> The subtle difference between "property not found" and "property not
> set" is already confusing enough.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> backends/hostmem-file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
> index 5179994..4b55361 100644
> --- a/backends/hostmem-file.c
> +++ b/backends/hostmem-file.c
> @@ -43,7 +43,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
> return;
> }
> if (!fb->mem_path) {
> - error_setg(errp, "mem_path property not set");
> + error_setg(errp, "mem-path property not set");
> return;
> }
> #ifndef CONFIG_LINUX
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] hostmem: Fix mem-path property name in error report
@ 2015-04-24 19:00 ` Peter Crosthwaite
0 siblings, 0 replies; 6+ messages in thread
From: Peter Crosthwaite @ 2015-04-24 19:00 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, qemu-devel
On Fri, Apr 24, 2015 at 10:41 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> The subtle difference between "property not found" and "property not
> set" is already confusing enough.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> backends/hostmem-file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
> index 5179994..4b55361 100644
> --- a/backends/hostmem-file.c
> +++ b/backends/hostmem-file.c
> @@ -43,7 +43,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
> return;
> }
> if (!fb->mem_path) {
> - error_setg(errp, "mem_path property not set");
> + error_setg(errp, "mem-path property not set");
> return;
> }
> #ifndef CONFIG_LINUX
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] hostmem: Fix mem-path property name in error report
2015-04-24 17:41 ` [Qemu-devel] " Jan Kiszka
@ 2015-04-25 6:26 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-04-25 6:26 UTC (permalink / raw)
To: Jan Kiszka, qemu-trivial; +Cc: qemu-devel
24.04.2015 20:41, Jan Kiszka wrote:
> The subtle difference between "property not found" and "property not
> set" is already confusing enough.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-25 6:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-24 17:41 [Qemu-trivial] [PATCH] hostmem: Fix mem-path property name in error report Jan Kiszka
2015-04-24 17:41 ` [Qemu-devel] " Jan Kiszka
2015-04-24 19:00 ` [Qemu-trivial] " Peter Crosthwaite
2015-04-24 19:00 ` Peter Crosthwaite
2015-04-25 6:26 ` [Qemu-trivial] " Michael Tokarev
2015-04-25 6:26 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.