From: Julien Grall <julien.grall@citrix.com>
To: Wei Wang <wei.w.wang@intel.com>,
jbeulich@suse.com, andrew.cooper3@citrix.com,
ian.campbell@citrix.com, kevin.tian@intel.com,
eddie.dong@intel.com, xen-devel@lists.xen.org
Cc: yang.z.zhang@intel.com
Subject: Re: [PATCH 6/9] x86/intel_pstate: the main boby of the intel_pstate driver
Date: Sat, 25 Apr 2015 23:05:58 +0500 [thread overview]
Message-ID: <553BD786.6060802@citrix.com> (raw)
In-Reply-To: <1461419884-6091-1-git-send-email-wei.w.wang@intel.com>
Hi Wei,
On 23/04/2016 18:58, Wei Wang wrote:
> diff --git a/xen/include/acpi/cpufreq/processor_perf.h b/xen/include/acpi/cpufreq/processor_perf.h
> index d8a1ba6..ebff11d 100644
> --- a/xen/include/acpi/cpufreq/processor_perf.h
> +++ b/xen/include/acpi/cpufreq/processor_perf.h
> @@ -7,6 +7,7 @@
>
> #define XEN_PX_INIT 0x80000000
>
> +int intel_pstate_init(void);
The intel pstate driver is x86 specific. Although xen/include/acpi
contains common headers for common code.
Can you move the declaration in an x86 specific header (i.e in
xen/include/asm-x86)?
If I'm not mistaken, you have other patch with similar things in this
series.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-04-25 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 14:00 [PATCH 6/9] x86/intel_pstate: the main boby of the intel_pstate driver Wei Wang
2015-04-25 18:05 ` Julien Grall [this message]
2015-04-26 3:32 ` Wang, Wei W
2015-04-26 13:02 ` Julien Grall
2015-04-27 1:23 ` Wang, Wei W
2015-04-28 13:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553BD786.6060802@citrix.com \
--to=julien.grall@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=wei.w.wang@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.