All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>,  qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-trivial] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_pc_from_tb()
Date: Mon, 27 Apr 2015 15:06:00 +0300	[thread overview]
Message-ID: <553E2628.9080401@msgid.tls.msk.ru> (raw)
In-Reply-To: <553E2571.2000700@msgid.tls.msk.ru>

27.04.2015 15:02, Michael Tokarev wrote:
> 27.04.2015 04:38, Peter Crosthwaite wrote:
>> No code uses the cpu_pc_from_tb() function. Delete.

> This function is also used in target-tricore/cpu.h, and is mentioned

Not _used_ but defined, the same way as it is defined but not used in
target-arm/cpu.h.

> in comments in tcg/tcg.h.  Should these be removed as well?

Thanks,

/mjt



WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_pc_from_tb()
Date: Mon, 27 Apr 2015 15:06:00 +0300	[thread overview]
Message-ID: <553E2628.9080401@msgid.tls.msk.ru> (raw)
In-Reply-To: <553E2571.2000700@msgid.tls.msk.ru>

27.04.2015 15:02, Michael Tokarev wrote:
> 27.04.2015 04:38, Peter Crosthwaite wrote:
>> No code uses the cpu_pc_from_tb() function. Delete.

> This function is also used in target-tricore/cpu.h, and is mentioned

Not _used_ but defined, the same way as it is defined but not used in
target-arm/cpu.h.

> in comments in tcg/tcg.h.  Should these be removed as well?

Thanks,

/mjt

  reply	other threads:[~2015-04-27 12:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27  1:38 [Qemu-trivial] [PATCH target-arm 0/2] Unused code cleanups Peter Crosthwaite
2015-04-27  1:38 ` [Qemu-devel] " Peter Crosthwaite
2015-04-27  1:38 ` [Qemu-trivial] [PATCH target-arm 1/2] arm: cpu.h: Remove unused typdefs Peter Crosthwaite
2015-04-27  1:38   ` [Qemu-devel] " Peter Crosthwaite
2015-04-27 14:47   ` [Qemu-trivial] " Michael Tokarev
2015-04-27 14:47     ` [Qemu-devel] " Michael Tokarev
2015-04-27  1:38 ` [Qemu-trivial] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_pc_from_tb() Peter Crosthwaite
2015-04-27  1:38   ` [Qemu-devel] " Peter Crosthwaite
2015-04-27 12:02   ` [Qemu-trivial] " Michael Tokarev
2015-04-27 12:02     ` [Qemu-devel] " Michael Tokarev
2015-04-27 12:06     ` Michael Tokarev [this message]
2015-04-27 12:06       ` Michael Tokarev
2015-04-27 12:58     ` [Qemu-trivial] " Peter Maydell
2015-04-27 12:58       ` [Qemu-devel] " Peter Maydell
2015-04-27 19:00       ` [Qemu-trivial] " Peter Maydell
2015-04-27 19:00         ` [Qemu-devel] " Peter Maydell
2015-04-27 19:06         ` [Qemu-trivial] " Peter Crosthwaite
2015-04-27 19:06           ` Peter Crosthwaite
2015-04-27 19:10           ` [Qemu-trivial] " Peter Maydell
2015-04-27 19:10             ` Peter Maydell
2015-04-29  5:43           ` [Qemu-trivial] " Michael Tokarev
2015-04-29  5:43             ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553E2628.9080401@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.