From: Eric Blake <eblake@redhat.com>
To: Gal Hammer <ghammer@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device.
Date: Mon, 27 Apr 2015 09:01:36 -0600 [thread overview]
Message-ID: <553E4F50.4030301@redhat.com> (raw)
In-Reply-To: <1430133591-6197-6-git-send-email-ghammer@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On 04/27/2015 05:19 AM, Gal Hammer wrote:
> Signed-off-by: Gal Hammer <ghammer@redhat.com>
Subject line: Most commits do NOT end in a trailing '.'. It's less
obvious if there is a preference for starting commits with a capital
after the subject, but that seems to be the current prevailing trend.
So I might have done:
tests: Add a unit test for vmgenid device
or even:
vmgenid: Add a unit test
(the latter approach would mean grouping all of the series under a
single topic of vmgenid, instead of your approach of a different topic
per patch according to which part was being modified in support of
adding vmgenid. Either approach is fine by me)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-04-27 15:01 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 11:19 [Qemu-devel] [PATCH V15 0/5] Virtual Machine Generation ID Gal Hammer
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description Gal Hammer
2015-04-27 13:42 ` Michael S. Tsirkin
2015-04-27 13:55 ` Michael S. Tsirkin
2015-04-28 14:20 ` Gal Hammer
2015-04-27 14:56 ` Eric Blake
2015-04-28 14:38 ` Gal Hammer
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 2/5] acpi: add a vm_generation_id_changed method Gal Hammer
2015-04-27 14:57 ` Eric Blake
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 3/5] aml: implement a 32-bit fixed memory range descriptor Gal Hammer
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device Gal Hammer
2015-04-27 13:38 ` Michael S. Tsirkin
2015-04-29 12:46 ` Gal Hammer
2015-04-27 14:59 ` Eric Blake
2015-05-28 10:25 ` Paolo Bonzini
2015-05-28 11:49 ` Michael S. Tsirkin
2015-05-28 11:59 ` Gal Hammer
2015-05-28 12:21 ` Michael S. Tsirkin
2015-05-28 13:00 ` Paolo Bonzini
2015-05-28 13:24 ` Michael S. Tsirkin
2015-05-28 13:35 ` Paolo Bonzini
2015-05-29 11:46 ` Igor Mammedov
2015-06-03 16:32 ` Michael S. Tsirkin
2015-06-03 16:37 ` Paolo Bonzini
2015-06-08 13:42 ` Gal Hammer
2015-06-08 13:43 ` Paolo Bonzini
2015-06-08 13:52 ` Gal Hammer
2015-06-08 13:55 ` Paolo Bonzini
2015-06-08 13:58 ` Daniel P. Berrange
2015-06-08 14:05 ` Gal Hammer
2015-06-08 15:01 ` Michael S. Tsirkin
2015-06-08 15:17 ` Paolo Bonzini
2015-06-08 15:22 ` Michael S. Tsirkin
2015-06-08 15:28 ` Gal Hammer
2015-06-08 15:32 ` Michael S. Tsirkin
2015-06-08 15:33 ` Paolo Bonzini
2015-06-08 15:41 ` Michael S. Tsirkin
2015-06-08 15:43 ` Paolo Bonzini
2015-06-08 14:00 ` Gal Hammer
2015-06-08 13:59 ` Paolo Bonzini
2015-04-27 11:19 ` [Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device Gal Hammer
2015-04-27 15:01 ` Eric Blake [this message]
2015-04-27 16:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E4F50.4030301@redhat.com \
--to=eblake@redhat.com \
--cc=ghammer@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.