All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Dimitrov <picmaster@mail.bg>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm-extra][PATCH 1/2] linux-riotboard: Add separate riotboard kernel recipe
Date: Mon, 27 Apr 2015 18:27:18 +0300	[thread overview]
Message-ID: <553E5556.9070406@mail.bg> (raw)
In-Reply-To: <CAP9ODKoeAd4rR-F41bS4qLKHTqz5VgynspafxFfvtb-spZkKGw@mail.gmail.com>

Hi Otavio,

On 04/27/2015 02:40 PM, Otavio Salvador wrote:
> Hello Nikolay,
>
> On Mon, Apr 27, 2015 at 1:35 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>> Add dedicated RIoTboard kernel recipe for easier maintenance and patch
>> cherry-picking.
>>
>> Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>
>
> I want to check with you if you really want to have a dedicated
> recipe. For bugfixes (as now) you can use a bbappend as a temporary
> solution and, at end of the day, easy to remove once this is fixed in
> the kernel.
>
> Please let me know your thoughts...

Do you mean something like this (bbappend in meta-fsl-arm-extra)?

diff --git a/recipes-kernel/linux/linux-fslc_4.0.bbappend 
b/recipes-kernel/linux/linux-fslc_4.0.bbappend
new file mode 100644
index 0000000..d7a4e72
--- /dev/null
+++ b/recipes-kernel/linux/linux-fslc_4.0.bbappend
@@ -0,0 +1,3 @@
+FILESEXTRAPATHS_append := ":${THISDIR}/${PN}"
+
+SRC_URI_imx6dl-riotboard = "file://riotboard-specific.patch"

Well, imho the difference between bbappending and having a separate
recipe is that the bbappending mechanism is retro-reactive - I can
bbappend patches to linux-fslc but in the meantime the board support
will be broken.

Maintaining a separate kernel recipe for riotboard is a proactive way,
imho. When linux-fslc updates are happening, they won't immediately
break the riotboard, and after I test the updates I can update SRC_REV
to point it to a specific working commit, or as in my case point
SRC_REV to the latest commit and revert just one specific patch. The
advantage is that all the time the board support will be working.

This was my motivation for the patch. Please tell me if there are any 
drawback of having a separate board kernel recipe.

Regards,
Nikolay


  reply	other threads:[~2015-04-27 15:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27  4:35 [meta-fsl-arm-extra][PATCH 1/2] linux-riotboard: Add separate riotboard kernel recipe Nikolay Dimitrov
2015-04-27  4:35 ` [meta-fsl-arm-extra][PATCH 2/2] linux-riotboard: Fix broken boot Nikolay Dimitrov
2015-04-27 11:40 ` [meta-fsl-arm-extra][PATCH 1/2] linux-riotboard: Add separate riotboard kernel recipe Otavio Salvador
2015-04-27 15:27   ` Nikolay Dimitrov [this message]
2015-04-27 16:26     ` Otavio Salvador
2015-04-27 16:54       ` Daiane Angolini
2015-04-27 16:59         ` Otavio Salvador
2015-04-28  4:14           ` Nikolay Dimitrov
2015-04-28 13:46             ` Daiane Angolini
2015-04-28 13:53               ` Fabio Estevam
2015-04-28 13:57                 ` Gary Thomas
2015-04-28 14:01                   ` Fabio Estevam
2015-04-28 15:39                     ` Fabio Estevam
2015-04-28 16:25                       ` Gary Thomas
2015-04-28 16:42                       ` Otavio Salvador
2015-04-28 17:10                         ` Nikolay Dimitrov
2015-04-28 17:12                           ` Otavio Salvador
2015-04-28 17:24                             ` Nikolay Dimitrov
2015-04-28 17:38                               ` Otavio Salvador
2015-04-28 17:44                                 ` Otavio Salvador
2015-04-29  6:18                       ` Nikolay Dimitrov
2015-04-28 18:19       ` Nikolay Dimitrov
2015-04-28 18:33         ` Otavio Salvador
2015-04-28 18:45           ` Nikolay Dimitrov
2015-04-27 11:54 ` Daiane Angolini
2015-04-27 15:54   ` Nikolay Dimitrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553E5556.9070406@mail.bg \
    --to=picmaster@mail.bg \
    --cc=meta-freescale@yoctoproject.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.