Re: [meta-fsl-arm-extra][PATCH 1/2] linux-riotboard: Add separate riotboard kernel recipe

[Nikolay Dimitrov <picmaster@mail.bg>]

Hi Daiane,

On 04/27/2015 02:54 PM, Daiane Angolini wrote:
> On Mon, Apr 27, 2015 at 1:35 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>> Add dedicated RIoTboard kernel recipe for easier maintenance and patch
>> cherry-picking.
>
>> diff --git a/recipes-kernel/linux/linux-riotboard_4.0.bb b/recipes-kernel/linux/linux-riotboard_4.0.bb
>> new file mode 100644
>> index 0000000..7ac63fc
>> --- /dev/null
>> +++ b/recipes-kernel/linux/linux-riotboard_4.0.bb
>> @@ -0,0 +1,15 @@
>> +SUMMARY = "Linux kernel for Embest RIoTboard"
>
> In case you really need a dedicated kernel, please use a DESCRIPTION
> and elaborate it. What is the history of this kernel, why do you need
> a different kernel, what is the difference of this kernel, and in case
> it is really a 4.0 kernel why the chages are not upstreamed are
> possible questions to be answerd in the DESCRIPTION.

OK, will do.

>> +
>> +require recipes-kernel/linux/linux-imx.inc
>> +require recipes-kernel/linux/linux-dtb.inc
>> +
>> +DEPENDS += "lzop-native bc-native"
>> +
>> +SRCBRANCH = "patches-4.0"
>> +SRCREV = "48dfc7ce6933a593a651e8ce029cbc5bcca19382"
>> +
>> +SRC_URI = "git://github.com/Freescale/linux-fslc.git;branch=${SRCBRANCH} \
>> +           file://defconfig \
>
> I don't understand why are you using the same git repository as
> linux-fslc, can you, please elaborate/explain your idea?

I wanted to revert a specific linux-fslc patch while still reusing as
much code as possible (and not cloning the repo). I can also switch
entirely to mainline and stop using linux-fslc, if you think that's an
issue.

> And, it also means your commit log is weak and you can elaborate it for v2?
>
> Daiane
>
>> +"
>> +
>> +COMPATIBLE_MACHINE = "(imx6dl-riotboard)"
>> --
>> 1.7.10.4
>>
>> --

Thanks for the feedback. I'll take it into account for v2, once Otavio
also acknowledges the need for separate kernel recipe.

Regards,
Nikolay