From: Jon Hunter <jgchunter@gmail.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>, linux-tegra@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexandre Courbot <gnurou@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-kernel@vger.kernel.org,
Mikko Perttunen <mikko.perttunen@kapsi.fi>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Tuomas Tynkkynen <ttynkkynen@nvidia.com>,
Kumar Gala <galak@codeaurora.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ARM: tegra: Correct which USB controller has the UTMI pad registers
Date: Tue, 28 Apr 2015 10:11:05 +0100 [thread overview]
Message-ID: <553F4EA9.4000307@gmail.com> (raw)
In-Reply-To: <1428045671-2333-1-git-send-email-tomeu.vizoso@collabora.com>
On 04/03/2015 08:21 AM, Tomeu Vizoso wrote:
> It should be the first controller, not the second. The indexes of the
> usb resets were also wrong and have been fixed.
>
> The issue was caused by the changes in 308efde ("ARM: tegra: Add resets
> & has-utmi-pad-registers flag to all USB PHYs") being misapplied by git
> due to the patch context being insufficient.
>
> This broke USB after 6261b06 ("regulator: Defer lookup of supply to
> regulator_get"), because it changed the order in which the controllers
> were probed.
>
> The fix for this issue was suggested by Mikko Perttunen and Tuomas
> Tynkkynen.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Mikko Perttunen <mikko.perttunen@kapsi.fi>
> Cc: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
> ---
> Hi,
>
> hope I have gotten it right this time, but please do check :)
FWIW, this works for me.
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jgchunter@gmail.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: tegra: Correct which USB controller has the UTMI pad registers
Date: Tue, 28 Apr 2015 10:11:05 +0100 [thread overview]
Message-ID: <553F4EA9.4000307@gmail.com> (raw)
In-Reply-To: <1428045671-2333-1-git-send-email-tomeu.vizoso@collabora.com>
On 04/03/2015 08:21 AM, Tomeu Vizoso wrote:
> It should be the first controller, not the second. The indexes of the
> usb resets were also wrong and have been fixed.
>
> The issue was caused by the changes in 308efde ("ARM: tegra: Add resets
> & has-utmi-pad-registers flag to all USB PHYs") being misapplied by git
> due to the patch context being insufficient.
>
> This broke USB after 6261b06 ("regulator: Defer lookup of supply to
> regulator_get"), because it changed the order in which the controllers
> were probed.
>
> The fix for this issue was suggested by Mikko Perttunen and Tuomas
> Tynkkynen.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Mikko Perttunen <mikko.perttunen@kapsi.fi>
> Cc: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
> ---
> Hi,
>
> hope I have gotten it right this time, but please do check :)
FWIW, this works for me.
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
next prev parent reply other threads:[~2015-04-28 9:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 14:31 [PATCH] ARM: tegra: Correct which USB controller has the UTMI pad registers Tomeu Vizoso
2015-04-02 14:31 ` Tomeu Vizoso
2015-04-02 14:31 ` Tomeu Vizoso
[not found] ` <1427985119-15307-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2015-04-02 14:53 ` Mikko Perttunen
2015-04-02 14:53 ` Mikko Perttunen
2015-04-02 14:53 ` Mikko Perttunen
[not found] ` <551D57E0.7050102-/1wQRMveznE@public.gmane.org>
2015-04-02 15:00 ` [PATCH v2] " Tomeu Vizoso
2015-04-02 15:00 ` Tomeu Vizoso
2015-04-02 15:00 ` Tomeu Vizoso
[not found] ` <1427986842-21409-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2015-04-02 15:20 ` Mikko Perttunen
2015-04-02 15:20 ` Mikko Perttunen
2015-04-02 15:20 ` Mikko Perttunen
2015-04-02 15:35 ` Mikko Perttunen
2015-04-02 15:35 ` Mikko Perttunen
[not found] ` <551D61A5.2010102-/1wQRMveznE@public.gmane.org>
2015-04-03 7:21 ` [PATCH v3] " Tomeu Vizoso
2015-04-03 7:21 ` Tomeu Vizoso
2015-04-03 7:21 ` Tomeu Vizoso
[not found] ` <1428045671-2333-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2015-04-03 9:10 ` Mikko Perttunen
2015-04-03 9:10 ` Mikko Perttunen
2015-04-03 9:10 ` Mikko Perttunen
2015-04-28 9:11 ` Jon Hunter [this message]
2015-04-28 9:11 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553F4EA9.4000307@gmail.com \
--to=jgchunter@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mikko.perttunen@kapsi.fi \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=ttynkkynen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.