From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/9] clk: berlin: move to a dedicated sub-node
Date: Tue, 28 Apr 2015 13:32:10 +0200 [thread overview]
Message-ID: <553F6FBA.3070908@gmail.com> (raw)
In-Reply-To: <1428417909-27378-2-git-send-email-antoine.tenart@free-electrons.com>
On 07.04.2015 16:45, Antoine Tenart wrote:
> The Berlin clock driver was sharing a DT node with the pin controller
> and the reset driver. All these devices are now sub-nodes of the chip
> controller. This patch rework the Berlin clock driver to allow moving
> the Berlin clock DT bindings into their own sub-node of the chip
> controller node.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Mike, Stephen,
would you mind to give your Acked-by for this patch and let me take
this through Berlin and ARM-SoC tree? The patch only touches berlin-
specific subdirectories in clk/ so there should be no merge issues
expected.
Sebastian
> ---
> drivers/clk/berlin/bg2.c | 7 +++----
> drivers/clk/berlin/bg2q.c | 7 ++++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/clk/berlin/bg2.c b/drivers/clk/berlin/bg2.c
> index 515fb133495c..3bfb3aede9f4 100644
> --- a/drivers/clk/berlin/bg2.c
> +++ b/drivers/clk/berlin/bg2.c
> @@ -502,12 +502,13 @@ static const struct berlin2_gate_data bg2_gates[] __initconst = {
>
> static void __init berlin2_clock_setup(struct device_node *np)
> {
> + struct device_node *parent_np = of_get_parent(np);
> const char *parent_names[9];
> struct clk *clk;
> u8 avpll_flags = 0;
> int n;
>
> - gbase = of_iomap(np, 0);
> + gbase = of_iomap(parent_np, 0);
> if (!gbase)
> return;
>
> @@ -685,7 +686,5 @@ static void __init berlin2_clock_setup(struct device_node *np)
> bg2_fail:
> iounmap(gbase);
> }
> -CLK_OF_DECLARE(berlin2_clock, "marvell,berlin2-chip-ctrl",
> - berlin2_clock_setup);
> -CLK_OF_DECLARE(berlin2cd_clock, "marvell,berlin2cd-chip-ctrl",
> +CLK_OF_DECLARE(berlin2_clock, "marvell,berlin2-clk",
> berlin2_clock_setup);
> diff --git a/drivers/clk/berlin/bg2q.c b/drivers/clk/berlin/bg2q.c
> index 440ef81ab15c..72a50ded145a 100644
> --- a/drivers/clk/berlin/bg2q.c
> +++ b/drivers/clk/berlin/bg2q.c
> @@ -290,18 +290,19 @@ static const struct berlin2_gate_data bg2q_gates[] __initconst = {
>
> static void __init berlin2q_clock_setup(struct device_node *np)
> {
> + struct device_node *parent_np = of_get_parent(np);
> const char *parent_names[9];
> struct clk *clk;
> int n;
>
> - gbase = of_iomap(np, 0);
> + gbase = of_iomap(parent_np, 0);
> if (!gbase) {
> pr_err("%s: Unable to map global base\n", np->full_name);
> return;
> }
>
> /* BG2Q CPU PLL is not part of global registers */
> - cpupll_base = of_iomap(np, 1);
> + cpupll_base = of_iomap(parent_np, 1);
> if (!cpupll_base) {
> pr_err("%s: Unable to map cpupll base\n", np->full_name);
> iounmap(gbase);
> @@ -384,5 +385,5 @@ bg2q_fail:
> iounmap(cpupll_base);
> iounmap(gbase);
> }
> -CLK_OF_DECLARE(berlin2q_clock, "marvell,berlin2q-chip-ctrl",
> +CLK_OF_DECLARE(berlin2q_clock, "marvell,berlin2q-clk",
> berlin2q_clock_setup);
>
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>,
mturquette@linaro.org, sboyd@codeaurora.org
Cc: zmxu@marvell.com, jszhang@marvell.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/9] clk: berlin: move to a dedicated sub-node
Date: Tue, 28 Apr 2015 13:32:10 +0200 [thread overview]
Message-ID: <553F6FBA.3070908@gmail.com> (raw)
In-Reply-To: <1428417909-27378-2-git-send-email-antoine.tenart@free-electrons.com>
On 07.04.2015 16:45, Antoine Tenart wrote:
> The Berlin clock driver was sharing a DT node with the pin controller
> and the reset driver. All these devices are now sub-nodes of the chip
> controller. This patch rework the Berlin clock driver to allow moving
> the Berlin clock DT bindings into their own sub-node of the chip
> controller node.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Mike, Stephen,
would you mind to give your Acked-by for this patch and let me take
this through Berlin and ARM-SoC tree? The patch only touches berlin-
specific subdirectories in clk/ so there should be no merge issues
expected.
Sebastian
> ---
> drivers/clk/berlin/bg2.c | 7 +++----
> drivers/clk/berlin/bg2q.c | 7 ++++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/clk/berlin/bg2.c b/drivers/clk/berlin/bg2.c
> index 515fb133495c..3bfb3aede9f4 100644
> --- a/drivers/clk/berlin/bg2.c
> +++ b/drivers/clk/berlin/bg2.c
> @@ -502,12 +502,13 @@ static const struct berlin2_gate_data bg2_gates[] __initconst = {
>
> static void __init berlin2_clock_setup(struct device_node *np)
> {
> + struct device_node *parent_np = of_get_parent(np);
> const char *parent_names[9];
> struct clk *clk;
> u8 avpll_flags = 0;
> int n;
>
> - gbase = of_iomap(np, 0);
> + gbase = of_iomap(parent_np, 0);
> if (!gbase)
> return;
>
> @@ -685,7 +686,5 @@ static void __init berlin2_clock_setup(struct device_node *np)
> bg2_fail:
> iounmap(gbase);
> }
> -CLK_OF_DECLARE(berlin2_clock, "marvell,berlin2-chip-ctrl",
> - berlin2_clock_setup);
> -CLK_OF_DECLARE(berlin2cd_clock, "marvell,berlin2cd-chip-ctrl",
> +CLK_OF_DECLARE(berlin2_clock, "marvell,berlin2-clk",
> berlin2_clock_setup);
> diff --git a/drivers/clk/berlin/bg2q.c b/drivers/clk/berlin/bg2q.c
> index 440ef81ab15c..72a50ded145a 100644
> --- a/drivers/clk/berlin/bg2q.c
> +++ b/drivers/clk/berlin/bg2q.c
> @@ -290,18 +290,19 @@ static const struct berlin2_gate_data bg2q_gates[] __initconst = {
>
> static void __init berlin2q_clock_setup(struct device_node *np)
> {
> + struct device_node *parent_np = of_get_parent(np);
> const char *parent_names[9];
> struct clk *clk;
> int n;
>
> - gbase = of_iomap(np, 0);
> + gbase = of_iomap(parent_np, 0);
> if (!gbase) {
> pr_err("%s: Unable to map global base\n", np->full_name);
> return;
> }
>
> /* BG2Q CPU PLL is not part of global registers */
> - cpupll_base = of_iomap(np, 1);
> + cpupll_base = of_iomap(parent_np, 1);
> if (!cpupll_base) {
> pr_err("%s: Unable to map cpupll base\n", np->full_name);
> iounmap(gbase);
> @@ -384,5 +385,5 @@ bg2q_fail:
> iounmap(cpupll_base);
> iounmap(gbase);
> }
> -CLK_OF_DECLARE(berlin2q_clock, "marvell,berlin2q-chip-ctrl",
> +CLK_OF_DECLARE(berlin2q_clock, "marvell,berlin2q-clk",
> berlin2q_clock_setup);
>
next prev parent reply other threads:[~2015-04-28 11:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 14:45 [PATCH v3 0/9] ARM: berlin: refactor the clock Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
2015-04-07 14:45 ` [PATCH v3 1/9] clk: berlin: move to a dedicated sub-node Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
2015-04-28 11:32 ` Sebastian Hesselbarth [this message]
2015-04-28 11:32 ` Sebastian Hesselbarth
2015-05-07 8:46 ` Sebastian Hesselbarth
2015-05-07 8:46 ` Sebastian Hesselbarth
2015-05-15 1:12 ` Stephen Boyd
2015-05-15 1:12 ` Stephen Boyd
2015-04-07 14:45 ` [PATCH v3 2/9] Documentation: bindings: move the Berlin clock documentation Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
2015-05-15 1:13 ` Stephen Boyd
2015-05-15 1:13 ` Stephen Boyd
2015-04-07 14:45 ` [PATCH v3 3/9] ARM: berlin: rework the clock node for BG2 Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
2015-04-07 14:45 ` [PATCH v3 4/9] ARM: berlin: rework the clock node for BG2CD Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
2015-04-07 14:45 ` [PATCH v3 5/9] ARM: berlin: rework the clock node for BG2Q Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
2015-04-07 14:45 ` [PATCH v3 6/9] Documentation: bindings: update the berlin chip and system ctrl doc Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
2015-04-07 14:45 ` [PATCH v3 7/9] ARM: berlin: remove useless chip and system ctrl compatibles in BG2 Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
2015-04-07 14:45 ` [PATCH v3 8/9] ARM: berlin: remove useless chip and system ctrl compatibles in BG2CD Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
2015-04-07 14:45 ` [PATCH v3 9/9] ARM: berlin: remove useless chip and system ctrl compatibles in BG2Q Antoine Tenart
2015-04-07 14:45 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553F6FBA.3070908@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.