All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Thomas Monjalon
	<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH] Simplify the ifdefs in rte.app.mk.
Date: Wed, 29 Apr 2015 12:08:54 +0100	[thread overview]
Message-ID: <5540BBC6.3090008@intel.com> (raw)
In-Reply-To: <CA+PrjLEFpvOLS4rn=0MOOvXrW-rXK28Q3H+peq1Wrobg-kLtWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 29/04/2015 11:12, Thomas Monjalon wrote:
> Hi Keith,
>
> Thanks for trying to improve maintainability.
>
> It seems this is the second version of your patch.
> Please add v2 prefix and a changelog to ease review and
> patch management.
> As you probably know, it is explained here:
>      http://dpdk.org/dev#send
Hi Thomas,

Just to clarify as I tend to use RFC PATCH as well, do we still mark it 
as v2 even though the first patch was an RFC PATCH?

Sergio
> 2015-04-28 19:03 GMT+02:00 Keith Wiles <keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>:
>> Trying to simplify the ifdefs in rte.app.mk to make the code
>> more readable and maintainable by moving LDLIBS variable to use
>> the same style as LDLIBS-y being used in the rest of the code.
>>
>> Added a new variable called EXTRA_LDLIBS to be used by example apps
>> instead of using LDLIBS directly.
>>
>> Signed-off-by: Keith Wiles <keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

  parent reply	other threads:[~2015-04-29 11:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 17:03 [PATCH] Simplify the ifdefs in rte.app.mk Keith Wiles
     [not found] ` <1430240597-26782-1-git-send-email-keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 10:12   ` Thomas Monjalon
     [not found]     ` <CA+PrjLEFpvOLS4rn=0MOOvXrW-rXK28Q3H+peq1Wrobg-kLtWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-29 11:08       ` Gonzalez Monroy, Sergio [this message]
     [not found]         ` <5540BBC6.3090008-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 11:51           ` Thomas Monjalon
     [not found]             ` <CA+PrjLFdSMyzNcrvD4cU_PPSXQSbot+cTSrfPrGJCaRwLebzEg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-29 14:05               ` Wiles, Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5540BBC6.3090008@intel.com \
    --to=sergio.gonzalez.monroy-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.