Default config value for osd_disk_thread_ioprio_class

Default config value for osd_disk_thread_ioprio_class

[Wido den Hollander]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

In the process of upgrading a cluster from Giant to Hammer I saw this
on the OSD logs:

2015-04-29 14:02:37.015454 7f887875e900 -1 osd.456 43089
set_disk_tp_priority(22) Invalid argument:
osd_disk_thread_ioprio_class is  but only the following values are
allowed: idle, be or rt

That is correct, since config_opts.h says:

OPTION(osd_disk_thread_ioprio_class, OPT_STR, "") // rt realtime be
best effort idle

It's nothing bad, but it would be nicer if we got rid of it.

What to do here? Allow "" as a config setting and then ignore it or
set the default to rt, be or idle?

- -- 
Met vriendelijke groet / Kind regards,

Wido den Hollander

PCextreme B.V.

http://www.pcextreme.nl/contact
Tel direct: +31 (0)118 700 212
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVQMpHAAoJEH3G8jg7TO7a7QsH/0k4ijmOewQaLZz9FMOvnBMz
EFuZWwrpuZYncUDGXqXKYygQwsRMCSJkWX0vE7GJ0/6OalqD9qgbEHhCfNj/G/wR
jwQCX1dWwXX6+PDBSQHWyUIsH1v/UGOAw1jLRyMrgZe8MZcSNgVBnvU8vPKVlD7j
MjLXM/10CDubpuxe67rsgJxNPAA0LJnsyjNWtj3PwwdWgZCV7lwYLuCxh3oVKrMP
8I8RcofcKK53SVN/KI/mgk8UiUvTaob4pIff6fimLLRufzM+27FlnDFn3hZArDjD
izMqoUnaPNM6OBbDNiLUoywVAnDhtDcH2UtRrJCdHWyTi+Ej3oJDxxigq0Gpjlo=
=2wZ0
-----END PGP SIGNATURE-----

Re: Default config value for osd_disk_thread_ioprio_class

[Wido den Hollander]

On 04/29/2015 02:10 PM, Wido den Hollander wrote:
> Hi,
> 
> In the process of upgrading a cluster from Giant to Hammer I saw this
> on the OSD logs:
> 
> 2015-04-29 14:02:37.015454 7f887875e900 -1 osd.456 43089
> set_disk_tp_priority(22) Invalid argument:
> osd_disk_thread_ioprio_class is  but only the following values are
> allowed: idle, be or rt
> 
> That is correct, since config_opts.h says:
> 
> OPTION(osd_disk_thread_ioprio_class, OPT_STR, "") // rt realtime be
> best effort idle
> 
> It's nothing bad, but it would be nicer if we got rid of it.
> 
> What to do here? Allow "" as a config setting and then ignore it or
> set the default to rt, be or idle?
> 

I see there actually is a check for it:

  if (cct->_conf->osd_disk_thread_ioprio_class.empty() ||
      cct->_conf->osd_disk_thread_ioprio_priority < 0)
    return;

So empty() does not return True there while it should since the setting
is set to ""?

> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Wido den Hollander
42on B.V.
Ceph trainer and consultant

Phone: +31 (0)20 700 9902
Skype: contact42on

Re: Default config value for osd_disk_thread_ioprio_class

[Sage Weil]

On Wed, 29 Apr 2015, Wido den Hollander wrote:
> On 04/29/2015 02:10 PM, Wido den Hollander wrote:
> > Hi,
> > 
> > In the process of upgrading a cluster from Giant to Hammer I saw this
> > on the OSD logs:
> > 
> > 2015-04-29 14:02:37.015454 7f887875e900 -1 osd.456 43089
> > set_disk_tp_priority(22) Invalid argument:
> > osd_disk_thread_ioprio_class is  but only the following values are
> > allowed: idle, be or rt
> > 
> > That is correct, since config_opts.h says:
> > 
> > OPTION(osd_disk_thread_ioprio_class, OPT_STR, "") // rt realtime be
> > best effort idle
> > 
> > It's nothing bad, but it would be nicer if we got rid of it.
> > 
> > What to do here? Allow "" as a config setting and then ignore it or
> > set the default to rt, be or idle?
> > 
> 
> I see there actually is a check for it:
> 
>   if (cct->_conf->osd_disk_thread_ioprio_class.empty() ||
>       cct->_conf->osd_disk_thread_ioprio_priority < 0)
>     return;
> 
> So empty() does not return True there while it should since the setting
> is set to ""?

Hrm, "" should be empty()....

s

> 
> > --
> > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> -- 
> Wido den Hollander
> 42on B.V.
> Ceph trainer and consultant
> 
> Phone: +31 (0)20 700 9902
> Skype: contact42on
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Re: Default config value for osd_disk_thread_ioprio_class

[Wido den Hollander]

On 04/29/2015 06:49 PM, Sage Weil wrote:
> On Wed, 29 Apr 2015, Wido den Hollander wrote:
>> On 04/29/2015 02:10 PM, Wido den Hollander wrote:
>>> Hi,
>>>
>>> In the process of upgrading a cluster from Giant to Hammer I saw this
>>> on the OSD logs:
>>>
>>> 2015-04-29 14:02:37.015454 7f887875e900 -1 osd.456 43089
>>> set_disk_tp_priority(22) Invalid argument:
>>> osd_disk_thread_ioprio_class is  but only the following values are
>>> allowed: idle, be or rt
>>>
>>> That is correct, since config_opts.h says:
>>>
>>> OPTION(osd_disk_thread_ioprio_class, OPT_STR, "") // rt realtime be
>>> best effort idle
>>>
>>> It's nothing bad, but it would be nicer if we got rid of it.
>>>
>>> What to do here? Allow "" as a config setting and then ignore it or
>>> set the default to rt, be or idle?
>>>
>>
>> I see there actually is a check for it:
>>
>>   if (cct->_conf->osd_disk_thread_ioprio_class.empty() ||
>>       cct->_conf->osd_disk_thread_ioprio_priority < 0)
>>     return;
>>
>> So empty() does not return True there while it should since the setting
>> is set to ""?
> 
> Hrm, "" should be empty()....
> 

So I thought and verified with a simple C++ test.

So this seems like a bug. I filed one: http://tracker.ceph.com/issues/11505

Wido

> s
> 
>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>>
>> -- 
>> Wido den Hollander
>> 42on B.V.
>> Ceph trainer and consultant
>>
>> Phone: +31 (0)20 700 9902
>> Skype: contact42on
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>


-- 
Wido den Hollander
42on B.V.
Ceph trainer and consultant

Phone: +31 (0)20 700 9902
Skype: contact42on

Re: Default config value for osd_disk_thread_ioprio_class

[Mykola Golub]

On Wed, Apr 29, 2015 at 08:55:30PM +0200, Wido den Hollander wrote:

> In the process of upgrading a cluster from Giant to Hammer I saw this
> on the OSD logs:
> 
> 2015-04-29 14:02:37.015454 7f887875e900 -1 osd.456 43089
> set_disk_tp_priority(22) Invalid argument:
> osd_disk_thread_ioprio_class is  but only the following values are
> allowed: idle, be or rt

Could you please provide "ceph version" line from this log, somewhere
before this error?

-- 
Mykola Golub

Re: Default config value for osd_disk_thread_ioprio_class

[Wido den Hollander]

On 05/05/2015 08:46 AM, Mykola Golub wrote:
> On Wed, Apr 29, 2015 at 08:55:30PM +0200, Wido den Hollander wrote:
> 
>> In the process of upgrading a cluster from Giant to Hammer I saw this
>> on the OSD logs:
>>
>> 2015-04-29 14:02:37.015454 7f887875e900 -1 osd.456 43089
>> set_disk_tp_priority(22) Invalid argument:
>> osd_disk_thread_ioprio_class is  but only the following values are
>> allowed: idle, be or rt
> 
> Could you please provide "ceph version" line from this log, somewhere
> before this error?
> 

This was with 0.94.1 with the Ubuntu 14.04 packages from eu.ceph.com

I currently don't have access to this cluster anymore, but it was not
build from source by myself.


-- 
Wido den Hollander
42on B.V.
Ceph trainer and consultant

Phone: +31 (0)20 700 9902
Skype: contact42on