From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-mips@linux-mips.org, KVM <kvm@vger.kernel.org>,
kvm-ppc@vger.kernel.org, Cornelia Huck <cornelia.huck@de.ibm.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 1/2] KVM: provide irq_unsafe kvm_guest_{enter|exit}
Date: Thu, 30 Apr 2015 12:28:23 +0000 [thread overview]
Message-ID: <55421FE7.3060905@redhat.com> (raw)
In-Reply-To: <55421B0A.2060606@de.ibm.com>
On 30/04/2015 14:07, Christian Borntraeger wrote:
>>>>> >>>> +static inline void __kvm_guest_enter(void)
>>>>> >>>> {
>>>>> >>>> - unsigned long flags;
>>>>> >>>> -
>>>>> >>>> - BUG_ON(preemptible());
>>>> >>>
>>>> >>> Please keep the BUG_ON() in kvm_guest_enter. Otherwise looks good, thanks!
>> >
>> > Ah, you mean have the BUG_ON in the non underscore version? Yes, makes sense.
> Hmmm, too quick.
> the BUG_ON was there to make sure that rcu_virt_note_context_switch is safe.
> The reworked code pulls the rcu_virt_note_context_switch within the irq_save
> section so we no longer need this BUG_ON, no?
Right. I can apply the patches then!
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org,
KVM <kvm@vger.kernel.org>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 1/2] KVM: provide irq_unsafe kvm_guest_{enter|exit}
Date: Thu, 30 Apr 2015 14:28:23 +0200 [thread overview]
Message-ID: <55421FE7.3060905@redhat.com> (raw)
In-Reply-To: <55421B0A.2060606@de.ibm.com>
On 30/04/2015 14:07, Christian Borntraeger wrote:
>>>>> >>>> +static inline void __kvm_guest_enter(void)
>>>>> >>>> {
>>>>> >>>> - unsigned long flags;
>>>>> >>>> -
>>>>> >>>> - BUG_ON(preemptible());
>>>> >>>
>>>> >>> Please keep the BUG_ON() in kvm_guest_enter. Otherwise looks good, thanks!
>> >
>> > Ah, you mean have the BUG_ON in the non underscore version? Yes, makes sense.
> Hmmm, too quick.
> the BUG_ON was there to make sure that rcu_virt_note_context_switch is safe.
> The reworked code pulls the rcu_virt_note_context_switch within the irq_save
> section so we no longer need this BUG_ON, no?
Right. I can apply the patches then!
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-mips@linux-mips.org, KVM <kvm@vger.kernel.org>,
kvm-ppc@vger.kernel.org, Cornelia Huck <cornelia.huck@de.ibm.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 1/2] KVM: provide irq_unsafe kvm_guest_{enter|exit}
Date: Thu, 30 Apr 2015 14:28:23 +0200 [thread overview]
Message-ID: <55421FE7.3060905@redhat.com> (raw)
In-Reply-To: <55421B0A.2060606@de.ibm.com>
On 30/04/2015 14:07, Christian Borntraeger wrote:
>>>>> >>>> +static inline void __kvm_guest_enter(void)
>>>>> >>>> {
>>>>> >>>> - unsigned long flags;
>>>>> >>>> -
>>>>> >>>> - BUG_ON(preemptible());
>>>> >>>
>>>> >>> Please keep the BUG_ON() in kvm_guest_enter. Otherwise looks good, thanks!
>> >
>> > Ah, you mean have the BUG_ON in the non underscore version? Yes, makes sense.
> Hmmm, too quick.
> the BUG_ON was there to make sure that rcu_virt_note_context_switch is safe.
> The reworked code pulls the rcu_virt_note_context_switch within the irq_save
> section so we no longer need this BUG_ON, no?
Right. I can apply the patches then!
Paolo
next prev parent reply other threads:[~2015-04-30 12:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 11:43 [PATCHv2 0/2] KVM: micro-optimization and interrupt disabling Christian Borntraeger
2015-04-30 11:43 ` Christian Borntraeger
2015-04-30 11:43 ` Christian Borntraeger
2015-04-30 11:43 ` [PATCH 1/2] KVM: provide irq_unsafe kvm_guest_{enter|exit} Christian Borntraeger
2015-04-30 11:43 ` Christian Borntraeger
2015-04-30 11:50 ` Paolo Bonzini
2015-04-30 11:50 ` Paolo Bonzini
2015-04-30 12:01 ` Christian Borntraeger
2015-04-30 12:01 ` Christian Borntraeger
2015-04-30 12:02 ` Christian Borntraeger
2015-04-30 12:02 ` Christian Borntraeger
2015-04-30 12:07 ` Christian Borntraeger
2015-04-30 12:07 ` Christian Borntraeger
2015-04-30 12:07 ` Christian Borntraeger
2015-04-30 12:28 ` Paolo Bonzini [this message]
2015-04-30 12:28 ` Paolo Bonzini
2015-04-30 12:28 ` Paolo Bonzini
2015-04-30 11:43 ` [PATCH 2/2] KVM: arm/mips/x86/power use __kvm_guest_{enter|exit} Christian Borntraeger
2015-04-30 11:43 ` Christian Borntraeger
2015-05-05 12:08 ` Christoffer Dall
2015-05-05 12:08 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55421FE7.3060905@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.