From: nschichan@freebox.fr (Nicolas Schichan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Seccomp filter JIT support on ARM.
Date: Thu, 30 Apr 2015 14:35:31 +0200 [thread overview]
Message-ID: <55422193.9010905@freebox.fr> (raw)
In-Reply-To: <554108CC.6000801@iogearbox.net>
On 04/29/2015 06:37 PM, Daniel Borkmann wrote:
> On 04/29/2015 03:37 PM, Nicolas Schichan wrote:
> ...
>> The fourth and final patch fixes a bug in the emit_udiv() function
>> when used to convert a BPF_ALU | BPF_DIV | BPF_K instruction in the
>> ARM BPF JIT code.
>
> Shouldn't that fix go separately, so it can be included into 4.1
> resp. -stable?
Sure, shall I resend that separately from the v2 of the serie or is it fine in
its current form ?
> Would be good if you also Cc Mircea, who wrote the code. Was that
> caught by lib/test_bpf.c suite (if not, would be good to add a test
> case for it) ?
It was detected by an internal test suite we have here. I see that there are
some BPF_ALU | BPF_DIV | BPF_K instructions so it might also be caught by
lib/test_bpf.c as well.
Regards,
--
Nicolas Schichan
Freebox SAS
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Schichan <nschichan@freebox.fr>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Mircea Gherzan <mgherzan@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org, ast@plumgrid.com
Subject: Re: [PATCH 0/4] Seccomp filter JIT support on ARM.
Date: Thu, 30 Apr 2015 14:35:31 +0200 [thread overview]
Message-ID: <55422193.9010905@freebox.fr> (raw)
In-Reply-To: <554108CC.6000801@iogearbox.net>
On 04/29/2015 06:37 PM, Daniel Borkmann wrote:
> On 04/29/2015 03:37 PM, Nicolas Schichan wrote:
> ...
>> The fourth and final patch fixes a bug in the emit_udiv() function
>> when used to convert a BPF_ALU | BPF_DIV | BPF_K instruction in the
>> ARM BPF JIT code.
>
> Shouldn't that fix go separately, so it can be included into 4.1
> resp. -stable?
Sure, shall I resend that separately from the v2 of the serie or is it fine in
its current form ?
> Would be good if you also Cc Mircea, who wrote the code. Was that
> caught by lib/test_bpf.c suite (if not, would be good to add a test
> case for it) ?
It was detected by an internal test suite we have here. I see that there are
some BPF_ALU | BPF_DIV | BPF_K instructions so it might also be caught by
lib/test_bpf.c as well.
Regards,
--
Nicolas Schichan
Freebox SAS
next prev parent reply other threads:[~2015-04-30 12:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 13:37 [PATCH 0/4] Seccomp filter JIT support on ARM Nicolas Schichan
2015-04-29 13:37 ` Nicolas Schichan
2015-04-29 13:37 ` [PATCH 1/4] net: filter: make bpf_migrate_filter available outside of net/core/filter.c Nicolas Schichan
2015-04-29 13:37 ` [PATCH 2/4] seccomp: rework seccomp_prepare_filter() Nicolas Schichan
2015-04-29 17:12 ` Daniel Borkmann
2015-04-30 12:27 ` Nicolas Schichan
2015-04-30 12:46 ` Daniel Borkmann
2015-04-30 14:12 ` Nicolas Schichan
2015-04-29 13:37 ` [PATCH 3/4] ARM: net: add JIT support for loads from struct seccomp_data Nicolas Schichan
2015-04-29 13:37 ` Nicolas Schichan
2015-04-29 13:37 ` [PATCH 4/4] ARM: net fix emit_udiv() for BPF_ALU | BPF_DIV | BPF_K intruction Nicolas Schichan
2015-04-29 13:37 ` Nicolas Schichan
2015-05-01 17:37 ` Russell King - ARM Linux
2015-05-01 17:37 ` Russell King - ARM Linux
2015-05-04 16:16 ` Nicolas Schichan
2015-05-04 16:16 ` Nicolas Schichan
2015-05-04 17:57 ` Russell King - ARM Linux
2015-05-04 17:57 ` Russell King - ARM Linux
2015-04-29 16:37 ` [PATCH 0/4] Seccomp filter JIT support on ARM Daniel Borkmann
2015-04-29 16:37 ` Daniel Borkmann
2015-04-30 12:35 ` Nicolas Schichan [this message]
2015-04-30 12:35 ` Nicolas Schichan
2015-04-30 12:51 ` Daniel Borkmann
2015-04-30 12:51 ` Daniel Borkmann
2015-04-30 17:17 ` Alexei Starovoitov
2015-04-30 17:17 ` Alexei Starovoitov
2015-04-29 16:46 ` Alexei Starovoitov
2015-04-29 16:46 ` Alexei Starovoitov
2015-04-29 16:46 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55422193.9010905@freebox.fr \
--to=nschichan@freebox.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.