All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] media: cx88-mpeg: clear interrupt status register before streaming video
@ 2022-02-20 18:19 Daniel González Cabanelas
  0 siblings, 0 replies; only message in thread
From: Daniel González Cabanelas @ 2022-02-20 18:19 UTC (permalink / raw)
  To: linux-media; +Cc: hverkuil-cisco, mchehab

Some cx88 video cards may have transport stream status interrupts set
to 1 from cold start, causing errors like this:

  cx88xx: cx88_print_irqbits: core:irq mpeg  [0x100000] ts_err?*
  cx8802: cx8802_mpeg_irq: mpeg:general errors: 0x00100000

According to CX2388x datasheet, the interrupt status register should be
cleared before enabling IRQs to stream video.

Fix it by clearing the Transport Stream Interrupt Status register.

Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
---
Changes in v2:
  - Added bits 8 and 12 to the clear operation. Now all documented
    MO_TS_INTSTAT bits are cleared.

 drivers/media/pci/cx88/cx88-mpeg.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/media/pci/cx88/cx88-mpeg.c b/drivers/media/pci/cx88/cx88-mpeg.c
index 680e1e3fe..2c1d5137a 100644
--- a/drivers/media/pci/cx88/cx88-mpeg.c
+++ b/drivers/media/pci/cx88/cx88-mpeg.c
@@ -162,6 +162,9 @@ int cx8802_start_dma(struct cx8802_dev    *dev,
 	cx_write(MO_TS_GPCNTRL, GP_COUNT_CONTROL_RESET);
 	q->count = 0;
 
+	/* clear interrupt status register */
+	cx_write(MO_TS_INTSTAT,  0x1f1111);
+
 	/* enable irqs */
 	dprintk(1, "setting the interrupt mask\n");
 	cx_set(MO_PCI_INTMSK, core->pci_irqmask | PCI_INT_TSINT);
-- 
2.35.1





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-20 18:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-20 18:19 [PATCH v2] media: cx88-mpeg: clear interrupt status register before streaming video Daniel González Cabanelas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.