All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Emilio G. Cota" <cota@braap.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] i440fx-test: guard ARRAY_SIZE definition with #ifndef
Date: Thu, 30 Apr 2015 23:14:06 +0300	[thread overview]
Message-ID: <55428D0E.8070706@msgid.tls.msk.ru> (raw)
In-Reply-To: <1430421390-2787-1-git-send-email-cota@braap.org>

30.04.2015 22:16, Emilio G. Cota wrote:
> ARRAY_SIZE is defined in osdep.h so having an unconditional
> definition here is fragile.

Fragile in what sense?  Nothing in that file includes osdep.h.
At the maximum, compiler will issue a warning about redefinition
(it should really be redefinition, not the same definition),
which might be treated as error, and we'll just fix that
warning.. I'd say just be done with this, it doesn't deserve
that much attention ;)

Somehow initially I thought this patch actually FIXES a warning
of this sort.  But it looks lile it is only fixes a potential
warning. Oh well...  :)

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Emilio G. Cota" <cota@braap.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] i440fx-test: guard ARRAY_SIZE definition with #ifndef
Date: Thu, 30 Apr 2015 23:14:06 +0300	[thread overview]
Message-ID: <55428D0E.8070706@msgid.tls.msk.ru> (raw)
In-Reply-To: <1430421390-2787-1-git-send-email-cota@braap.org>

30.04.2015 22:16, Emilio G. Cota wrote:
> ARRAY_SIZE is defined in osdep.h so having an unconditional
> definition here is fragile.

Fragile in what sense?  Nothing in that file includes osdep.h.
At the maximum, compiler will issue a warning about redefinition
(it should really be redefinition, not the same definition),
which might be treated as error, and we'll just fix that
warning.. I'd say just be done with this, it doesn't deserve
that much attention ;)

Somehow initially I thought this patch actually FIXES a warning
of this sort.  But it looks lile it is only fixes a potential
warning. Oh well...  :)

Thanks,

/mjt

  parent reply	other threads:[~2015-04-30 20:14 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30  5:08 [Qemu-trivial] [PULL 00/42] Trivial patches for 2015-04-30 Michael Tokarev
2015-04-30  5:08 ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 01/42] tpm: Cast 64bit variables to int when used in DPRINTF Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 02/42] tpm: Modify DPRINTF to enable -Wformat checking Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 03/42] bitops : fix coding style Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 04/42] ui/vnc " Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 05/42] ui/vnc : remove 'struct' of 'typedef struct' Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 06/42] ui/console : remove 'struct' from 'typedef struct' type Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 07/42] hw/display : remove 'struct' from 'typedef QXL struct' Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 08/42] misc: Fix new collection of typos Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 09/42] range: remove useless inclusions Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 10/42] qemu-config: remove stray inclusions of hw/ files Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 11/42] tpm: fix coding style Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 12/42] hostmem: Fix mem-path property name in error report Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 13/42] qemu-options: trivial spelling fix (messsage) Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 14/42] vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags() Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 15/42] pci: Remove unused function ich9_d2pbr_init() Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 16/42] monitor: Remove unused functions Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 17/42] usb: " Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 18/42] util: " Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 19/42] arm: cpu.h: Remove unused typdefs Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 20/42] configure: alphabetize tricore in target list Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 21/42] docs/atomics.txt: fix two typos Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 22/42] libcacard: stop including qemu-common.h Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 23/42] libcacard: do not use full paths for include files in the same dir Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 24/42] defconfigs: Piggyback microblazeel on microblaze Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 25/42] microblaze: mmu: Delete flip_um fn prototype Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 26/42] microblaze: cpu: Remote unused cpu_get_pc Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 27/42] microblaze: cpu: Remove unused CC_OP enum Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 28/42] microblaze: cpu: Delete EXCP_NMI Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 29/42] microblaze: cpu: Renumber EXCP_* constants to close gap Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 30/42] microblaze: cpu: delete unused cpu_interrupts_enabled Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 31/42] cpus: use first_cpu macro instead of QTAILQ_FIRST(&cpus) Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 32/42] input: remove unused mouse_handlers list Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 33/42] qemu-char: remove unused list node from FDCharDriver Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 34/42] coroutine: remove unnecessary parentheses in qemu_co_queue_empty Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 35/42] linux-user/elfload: use QTAILQ_FOREACH instead of open-coding it Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 36/42] i440fx-test: remove ARRAY_SIZE redefinition Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 37/42] qmp-commands: Fix typo Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 38/42] target-mips: fix memory leak Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 39/42] vhost-user: remove superfluous '\n' around error_report() Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 40/42] kvm: Silence warning from valgrind Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 41/42] tcg: Delete unused cpu_pc_from_tb() Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30  5:08 ` [Qemu-trivial] [PULL 42/42] microblaze: fix memory leak Michael Tokarev
2015-04-30  5:08   ` [Qemu-devel] " Michael Tokarev
2015-04-30 12:58 ` [Qemu-trivial] [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30 Peter Maydell
2015-04-30 12:58   ` Peter Maydell
2015-04-30 13:05   ` [Qemu-trivial] " Michael Tokarev
2015-04-30 13:05     ` [Qemu-devel] " Michael Tokarev
2015-04-30 19:16   ` [Qemu-trivial] [PATCH] i440fx-test: guard ARRAY_SIZE definition with #ifndef Emilio G. Cota
2015-04-30 19:16     ` [Qemu-devel] " Emilio G. Cota
2015-04-30 19:28     ` [Qemu-trivial] " Stefan Weil
2015-04-30 19:28       ` Stefan Weil
2015-04-30 20:02       ` [Qemu-trivial] " Peter Maydell
2015-04-30 20:02         ` Peter Maydell
2015-04-30 20:14     ` Michael Tokarev [this message]
2015-04-30 20:14       ` Michael Tokarev
2015-04-30 22:21       ` [Qemu-trivial] [PATCH] tests: consolidate common includes under libqtest.h Emilio G. Cota
2015-04-30 22:21         ` [Qemu-devel] " Emilio G. Cota
2015-05-05 10:28         ` [Qemu-trivial] " Paolo Bonzini
2015-05-05 10:28           ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55428D0E.8070706@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=cota@braap.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.