3.4.107: Wrong back port of "PCI: Handle read-only BARs on AMD CS553x devices"?

3.4.107: Wrong back port of "PCI: Handle read-only BARs on AMD CS553x devices"?

[Dirk Behme]

Hi,

from a private 3.4.107 review I've got the comment that

PCI: Handle read-only BARs on AMD CS553x devices

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=d4e393820d2ed20fc6a4088f3eda44458764d997

might be wrongly back ported to 3.4.107: The problem is that the 
prototype of pcibios_bus_to_resource() was changed by commit fc27985 
"PCI: Convert pcibios_resource_to_bus() to take a pci_bus, not a 
pci_dev" in v3.14, but this commit was not back ported to the v3.4.y 
stable series [1].

Best regards

Dirk

[1]

drivers/pci/quirks.c: In function ‘quirk_io’:
drivers/pci/quirks.c:351:26: warning: passing argument 1 of 
‘pcibios_bus_to_resource’ from incompatible pointer type
   pcibios_bus_to_resource(dev->bus, res, &bus_region);
                           ^
In file included from drivers/pci/quirks.c:21:0:
include/linux/pci.h:653:6: note: expected ‘struct pci_dev *’ but 
argument is of type ‘struct pci_bus *’
  void pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res,
       ^

Re: 3.4.107: Wrong back port of "PCI: Handle read-only BARs on AMD CS553x devices"?

[Zefan Li]

On 2015/5/2 13:25, Dirk Behme wrote:
> Hi,
> 
> from a private 3.4.107 review I've got the comment that
> 
> PCI: Handle read-only BARs on AMD CS553x devices
> 
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=d4e393820d2ed20fc6a4088f3eda44458764d997
> 
> might be wrongly back ported to 3.4.107: The problem is that the prototype of pcibios_bus_to_resource() was changed by commit fc27985 "PCI: Convert pcibios_resource_to_bus() to take a pci_bus, not a pci_dev" in v3.14, but this commit was not back ported to the v3.4.y stable series [1].
> 

I've backported fc27985 to 3.4 to fix this. Thanks!

> Best regards
> 
> Dirk
> 
> [1]
> 
> drivers/pci/quirks.c: In function ‘quirk_io’:
> drivers/pci/quirks.c:351:26: warning: passing argument 1 of ‘pcibios_bus_to_resource’ from incompatible pointer type
>   pcibios_bus_to_resource(dev->bus, res, &bus_region);
>                           ^
> In file included from drivers/pci/quirks.c:21:0:
> include/linux/pci.h:653:6: note: expected ‘struct pci_dev *’ but argument is of type ‘struct pci_bus *’
>  void pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res,
>       ^
> -- 
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>