From: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>,
Yadwinder Singh Brar <yadi.brar@samsung.com>,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com
Cc: robh+dt@kernel.org, yadi.brar01@gmail.com
Subject: Re: [2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250
Date: Sat, 02 May 2015 14:49:46 +0900 [thread overview]
Message-ID: <5544657A.7010006@gmail.com> (raw)
In-Reply-To: <553F68CC.6030504@samsung.com>
W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
> Hi Kukjin,
>
> Any updated for this patch. Without this PMIC RTC is not working on
> SMDK5250.
>
Could you resend the patch after rebasing it?
Best regards,
Krzysztof
> Thanks,
> Pankaj Dubey
>
> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
>> This patch adds pinctrl configuration for using configuring gpx3-2 as an
>> external interrupt from max77686. Though max77686 RTC is enabled and gets
>> probed by default, it doesnt work as its unable to get interrupt.
>>
>> This patch makes max77686 RTC work and also configures it as wakeup
>> source.
>>
>> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> ---
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 12 ++++++++++++
>> 1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> index 95b5b51..19cd918 100644
>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> @@ -131,6 +131,9 @@
>> reg = <0x09>;
>> interrupt-parent = <&gpx3>;
>> interrupts = <2 IRQ_TYPE_NONE>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&max77686_irq>;
>> + wakeup-source;
>>
>> voltage-regulators {
>> ldo1_reg: LDO1 {
>> @@ -411,3 +414,12 @@
>> };
>> };
>> };
>> +
>> +&pinctrl_0 {
>> + max77686_irq: max77686-irq {
>> + samsung,pins = "gpx3-2";
>> + samsung,pin-function = <0xf>;
>> + samsung,pin-pud = <0>;
>> + samsung,pin-drv = <0>;
>> + };
>> +};
>>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski.k@gmail.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250
Date: Sat, 02 May 2015 14:49:46 +0900 [thread overview]
Message-ID: <5544657A.7010006@gmail.com> (raw)
In-Reply-To: <553F68CC.6030504@samsung.com>
W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
> Hi Kukjin,
>
> Any updated for this patch. Without this PMIC RTC is not working on
> SMDK5250.
>
Could you resend the patch after rebasing it?
Best regards,
Krzysztof
> Thanks,
> Pankaj Dubey
>
> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
>> This patch adds pinctrl configuration for using configuring gpx3-2 as an
>> external interrupt from max77686. Though max77686 RTC is enabled and gets
>> probed by default, it doesnt work as its unable to get interrupt.
>>
>> This patch makes max77686 RTC work and also configures it as wakeup
>> source.
>>
>> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> ---
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 12 ++++++++++++
>> 1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> index 95b5b51..19cd918 100644
>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> @@ -131,6 +131,9 @@
>> reg = <0x09>;
>> interrupt-parent = <&gpx3>;
>> interrupts = <2 IRQ_TYPE_NONE>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&max77686_irq>;
>> + wakeup-source;
>>
>> voltage-regulators {
>> ldo1_reg: LDO1 {
>> @@ -411,3 +414,12 @@
>> };
>> };
>> };
>> +
>> +&pinctrl_0 {
>> + max77686_irq: max77686-irq {
>> + samsung,pins = "gpx3-2";
>> + samsung,pin-function = <0xf>;
>> + samsung,pin-pud = <0>;
>> + samsung,pin-drv = <0>;
>> + };
>> +};
>>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-02 5:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 12:08 [PATCH 1/2] ARM: dts: Fix bootup issue on smdk5250 Yadwinder Singh Brar
2014-11-18 12:08 ` Yadwinder Singh Brar
2014-11-18 12:08 ` [PATCH 2/2] ARM: dts: Add missing irq pinctrl for max77686 " Yadwinder Singh Brar
2014-11-18 12:08 ` Yadwinder Singh Brar
2014-11-18 14:02 ` Javier Martinez Canillas
2014-11-18 14:02 ` Javier Martinez Canillas
2014-11-20 4:06 ` [2/2] " Pankaj Dubey
2014-11-20 4:06 ` Pankaj Dubey
2015-04-28 11:02 ` Pankaj Dubey
2015-04-28 11:02 ` Pankaj Dubey
2015-05-02 5:49 ` Krzysztof Kozlowski [this message]
2015-05-02 5:49 ` Krzysztof Kozlowski
2015-08-17 5:50 ` Krzysztof Kozlowski
2015-08-17 5:50 ` Krzysztof Kozlowski
2015-08-18 6:13 ` Pankaj Dubey
2015-08-18 6:13 ` Pankaj Dubey
2015-08-18 6:27 ` Pankaj Dubey
2015-08-18 6:27 ` Pankaj Dubey
2015-08-18 7:00 ` Krzysztof Kozlowski
2015-08-18 7:00 ` Krzysztof Kozlowski
2014-11-20 4:01 ` [1/2] ARM: dts: Fix bootup issue " Pankaj Dubey
2014-11-20 4:01 ` Pankaj Dubey
2014-11-22 3:25 ` Kukjin Kim
2014-11-22 3:25 ` Kukjin Kim
2014-11-25 13:16 ` Yadwinder Singh Brar
2014-11-25 13:16 ` Yadwinder Singh Brar
2015-04-28 11:05 ` Pankaj Dubey
2015-04-28 11:05 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5544657A.7010006@gmail.com \
--to=k.kozlowski.k@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=yadi.brar01@gmail.com \
--cc=yadi.brar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.