* [PATCH] blkcg: remove redundant code in blkcg_css_free()
@ 2015-05-04 0:41 ` Zefan Li
0 siblings, 0 replies; 4+ messages in thread
From: Zefan Li @ 2015-05-04 0:41 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jens Axboe, LKML, Cgroups
The check was needed only when we supported modular cgroup subsystem.
Signed-off-by: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
block/blk-cgroup.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 0ac817b..92b7edd 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -814,9 +814,7 @@ static void blkcg_css_offline(struct cgroup_subsys_state *css)
static void blkcg_css_free(struct cgroup_subsys_state *css)
{
struct blkcg *blkcg = css_to_blkcg(css);
-
- if (blkcg != &blkcg_root)
- kfree(blkcg);
+ kfree(blkcg);
}
static struct cgroup_subsys_state *
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] blkcg: remove redundant code in blkcg_css_free()
@ 2015-05-04 0:41 ` Zefan Li
0 siblings, 0 replies; 4+ messages in thread
From: Zefan Li @ 2015-05-04 0:41 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jens Axboe, LKML, Cgroups
The check was needed only when we supported modular cgroup subsystem.
Signed-off-by: Zefan Li <lizefan@huawei.com>
---
block/blk-cgroup.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 0ac817b..92b7edd 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -814,9 +814,7 @@ static void blkcg_css_offline(struct cgroup_subsys_state *css)
static void blkcg_css_free(struct cgroup_subsys_state *css)
{
struct blkcg *blkcg = css_to_blkcg(css);
-
- if (blkcg != &blkcg_root)
- kfree(blkcg);
+ kfree(blkcg);
}
static struct cgroup_subsys_state *
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] blkcg: remove redundant code in blkcg_css_free()
2015-05-04 0:41 ` Zefan Li
@ 2015-05-04 16:16 ` Tejun Heo
-1 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2015-05-04 16:16 UTC (permalink / raw)
To: Zefan Li; +Cc: Jens Axboe, LKML, Cgroups
On Mon, May 04, 2015 at 08:41:16AM +0800, Zefan Li wrote:
> The check was needed only when we supported modular cgroup subsystem.
>
> Signed-off-by: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Acked-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Jens, can you please take this patch or shall I route it through the
cgroup tree?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blkcg: remove redundant code in blkcg_css_free()
@ 2015-05-04 16:16 ` Tejun Heo
0 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2015-05-04 16:16 UTC (permalink / raw)
To: Zefan Li; +Cc: Jens Axboe, LKML, Cgroups
On Mon, May 04, 2015 at 08:41:16AM +0800, Zefan Li wrote:
> The check was needed only when we supported modular cgroup subsystem.
>
> Signed-off-by: Zefan Li <lizefan@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Jens, can you please take this patch or shall I route it through the
cgroup tree?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-04 16:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-04 0:41 [PATCH] blkcg: remove redundant code in blkcg_css_free() Zefan Li
2015-05-04 0:41 ` Zefan Li
[not found] ` <5546C02C.3060803-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-05-04 16:16 ` Tejun Heo
2015-05-04 16:16 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.