* [Qemu-trivial] [PATCH] sheepdog: fix resource leak with sd_snapshot_create
@ 2015-05-05 1:48 ` zhanghailiang
0 siblings, 0 replies; 6+ messages in thread
From: zhanghailiang @ 2015-05-05 1:48 UTC (permalink / raw)
To: qemu-trivial; +Cc: mitake.hitoshi, namei.unix, qemu-devel, kwolf, zhanghailiang
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
block/sheepdog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 2d5f06a..bd7cbed 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -2341,6 +2341,7 @@ static int sd_snapshot_create(BlockDriverState *bs, QEMUSnapshotInfo *sn_info)
if (ret < 0) {
error_report("failed to create inode for snapshot: %s",
error_get_pretty(local_err));
+ error_free(local_err);
goto cleanup;
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] sheepdog: fix resource leak with sd_snapshot_create
@ 2015-05-05 1:48 ` zhanghailiang
0 siblings, 0 replies; 6+ messages in thread
From: zhanghailiang @ 2015-05-05 1:48 UTC (permalink / raw)
To: qemu-trivial; +Cc: mitake.hitoshi, namei.unix, qemu-devel, kwolf, zhanghailiang
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
block/sheepdog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 2d5f06a..bd7cbed 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -2341,6 +2341,7 @@ static int sd_snapshot_create(BlockDriverState *bs, QEMUSnapshotInfo *sn_info)
if (ret < 0) {
error_report("failed to create inode for snapshot: %s",
error_get_pretty(local_err));
+ error_free(local_err);
goto cleanup;
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] sheepdog: fix resource leak with sd_snapshot_create
2015-05-05 1:48 ` [Qemu-devel] " zhanghailiang
@ 2015-05-05 7:29 ` Markus Armbruster
-1 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-05-05 7:29 UTC (permalink / raw)
To: zhanghailiang; +Cc: qemu-trivial, mitake.hitoshi, qemu-devel, kwolf, namei.unix
zhanghailiang <zhang.zhanghailiang@huawei.com> writes:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> block/sheepdog.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 2d5f06a..bd7cbed 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -2341,6 +2341,7 @@ static int sd_snapshot_create(BlockDriverState *bs, QEMUSnapshotInfo *sn_info)
> if (ret < 0) {
> error_report("failed to create inode for snapshot: %s",
> error_get_pretty(local_err));
> + error_free(local_err);
> goto cleanup;
> }
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] sheepdog: fix resource leak with sd_snapshot_create
@ 2015-05-05 7:29 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-05-05 7:29 UTC (permalink / raw)
To: zhanghailiang; +Cc: qemu-trivial, mitake.hitoshi, qemu-devel, kwolf, namei.unix
zhanghailiang <zhang.zhanghailiang@huawei.com> writes:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> block/sheepdog.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 2d5f06a..bd7cbed 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -2341,6 +2341,7 @@ static int sd_snapshot_create(BlockDriverState *bs, QEMUSnapshotInfo *sn_info)
> if (ret < 0) {
> error_report("failed to create inode for snapshot: %s",
> error_get_pretty(local_err));
> + error_free(local_err);
> goto cleanup;
> }
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] sheepdog: fix resource leak with sd_snapshot_create
2015-05-05 1:48 ` [Qemu-devel] " zhanghailiang
@ 2015-05-05 10:18 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-05-05 10:18 UTC (permalink / raw)
To: zhanghailiang, qemu-trivial; +Cc: mitake.hitoshi, namei.unix, qemu-devel, kwolf
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] sheepdog: fix resource leak with sd_snapshot_create
@ 2015-05-05 10:18 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-05-05 10:18 UTC (permalink / raw)
To: zhanghailiang, qemu-trivial; +Cc: mitake.hitoshi, namei.unix, qemu-devel, kwolf
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-05 10:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-05 1:48 [Qemu-trivial] [PATCH] sheepdog: fix resource leak with sd_snapshot_create zhanghailiang
2015-05-05 1:48 ` [Qemu-devel] " zhanghailiang
2015-05-05 7:29 ` [Qemu-trivial] " Markus Armbruster
2015-05-05 7:29 ` Markus Armbruster
2015-05-05 10:18 ` [Qemu-trivial] " Michael Tokarev
2015-05-05 10:18 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.