From: "H. Peter Anvin" <hpa@zytor.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: mingo@redhat.com, x86@kernel.org, dvhart@infradead.org,
andy.schevchenko@gmail.com, boon.leong.ong@intel.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, derek.browne@intel.com,
josef.ahmad@intel.com, erik.nyquist@intel.com
Subject: Re: [PATCH 1/2] x86/quark: Add Quark embedded SRAM support
Date: Tue, 05 May 2015 15:19:25 -0700 [thread overview]
Message-ID: <554941ED.2080004@zytor.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1505041608530.4225@nanos>
On 05/04/2015 08:00 AM, Thomas Gleixner wrote:
>
>> + */
>> +static int esram_dbgfs_state_show(struct seq_file *s, void *unused)
>> +{
>> + struct esram_dev *edev = &esram_dev;
>> + u32 data;
>> + u32 reg = (u32)s->private;
>
> You really like to waste lines. What's wrong with:
>
> u32 data, reg = .....
>
I have to say I agree with Bryan here: it is rather ugly to mix
uninitialized and initialized variables on the same declaration line.
-hpa
next prev parent reply other threads:[~2015-05-05 22:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 2:17 [PATCH 0/2] x86/quark: Add eSRAM driver and test code Bryan O'Donoghue
2015-05-04 2:17 ` [PATCH 1/2] x86/quark: Add Quark embedded SRAM support Bryan O'Donoghue
2015-05-04 15:00 ` Thomas Gleixner
2015-05-05 13:48 ` Bryan O'Donoghue
2015-05-05 20:07 ` Darren Hart
2015-05-05 22:19 ` H. Peter Anvin [this message]
2015-05-05 8:44 ` Paul Bolle
2015-05-05 13:03 ` Bryan O'Donoghue
2015-05-06 9:58 ` Ingo Molnar
2015-05-06 15:46 ` Bryan O'Donoghue
2015-05-04 2:17 ` [PATCH 2/2] x86/quark: Add Quark embedded SRAM self-test Bryan O'Donoghue
2015-05-05 8:34 ` Paul Bolle
2015-05-06 10:02 ` Ingo Molnar
2015-05-06 14:27 ` Bryan O'Donoghue
2015-05-06 10:08 ` Ingo Molnar
2015-05-06 9:52 ` [PATCH 0/2] x86/quark: Add eSRAM driver and test code Ingo Molnar
2015-05-06 15:27 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554941ED.2080004@zytor.com \
--to=hpa@zytor.com \
--cc=andy.schevchenko@gmail.com \
--cc=boon.leong.ong@intel.com \
--cc=derek.browne@intel.com \
--cc=dvhart@infradead.org \
--cc=erik.nyquist@intel.com \
--cc=josef.ahmad@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.