All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] libcacard: stop including qemu-common.h
Date: Wed, 06 May 2015 13:05:20 +0300	[thread overview]
Message-ID: <5549E760.6030208@msgid.tls.msk.ru> (raw)
In-Reply-To: <CABoDooPkbFvVsC8i0XF9-9+dZQK16aJGDVoE7LAd_L9=COagqA@mail.gmail.com>

06.05.2015 12:23, Laurent Desnogues wrote:
> Hello,
> 
> On Mon, Apr 27, 2015 at 3:27 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> This is a small step towards making libcacard standalone.
> 
> on my system the removal of qemu-common.h inclusion broke compilation
> due to assert being used in glib-compat.h.

Interesting. What kind of build environment is that?  I compile-tested on
several platforms, all went fine.. ;)

>     A  fix might be to include
> assert.h in glib-compat.h.

I prefer s/assert/g_assert/ in glib-compat.h.

Thanks,

/mjt



WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] libcacard: stop including qemu-common.h
Date: Wed, 06 May 2015 13:05:20 +0300	[thread overview]
Message-ID: <5549E760.6030208@msgid.tls.msk.ru> (raw)
In-Reply-To: <CABoDooPkbFvVsC8i0XF9-9+dZQK16aJGDVoE7LAd_L9=COagqA@mail.gmail.com>

06.05.2015 12:23, Laurent Desnogues wrote:
> Hello,
> 
> On Mon, Apr 27, 2015 at 3:27 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> This is a small step towards making libcacard standalone.
> 
> on my system the removal of qemu-common.h inclusion broke compilation
> due to assert being used in glib-compat.h.

Interesting. What kind of build environment is that?  I compile-tested on
several platforms, all went fine.. ;)

>     A  fix might be to include
> assert.h in glib-compat.h.

I prefer s/assert/g_assert/ in glib-compat.h.

Thanks,

/mjt

  reply	other threads:[~2015-05-06 10:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 13:27 [Qemu-trivial] [PATCH v2] libcacard: stop including qemu-common.h Michael Tokarev
2015-04-27 13:27 ` [Qemu-devel] " Michael Tokarev
2015-04-27 13:29 ` [Qemu-trivial] " Paolo Bonzini
2015-04-27 13:29   ` [Qemu-devel] " Paolo Bonzini
2015-05-06  9:23 ` [Qemu-trivial] " Laurent Desnogues
2015-05-06  9:23   ` Laurent Desnogues
2015-05-06 10:05   ` Michael Tokarev [this message]
2015-05-06 10:05     ` Michael Tokarev
2015-05-06 12:01     ` [Qemu-trivial] " Laurent Desnogues
2015-05-06 12:01       ` Laurent Desnogues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5549E760.6030208@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=laurent.desnogues@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.