From: Guenter Roeck <linux@roeck-us.net>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>,
linux-watchdog@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, wim@iguana.be,
timo.kokkonen@offcode.fi, kernel@pengutronix.de
Subject: Re: [PATCH] watchdog: imx2_wdt: also set wdog->timeout to new_timeout
Date: Wed, 06 May 2015 06:40:48 -0700 [thread overview]
Message-ID: <554A19E0.20509@roeck-us.net> (raw)
In-Reply-To: <1430911079-23738-1-git-send-email-m.grzeschik@pengutronix.de>
On 05/06/2015 04:17 AM, Michael Grzeschik wrote:
> Commit faad5de0b104 ("watchdog: imx2_wdt: convert to watchdog core api")
> removes the custom ioctl function. The generic ioctl handler is not
> setting the wdog->timeout to the new_timeout but handing this preset
> value back to the userspace. This patch sets the new value in the
> drivers set_timeout function to fix that problem.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] watchdog: imx2_wdt: also set wdog->timeout to new_timeout
Date: Wed, 06 May 2015 06:40:48 -0700 [thread overview]
Message-ID: <554A19E0.20509@roeck-us.net> (raw)
In-Reply-To: <1430911079-23738-1-git-send-email-m.grzeschik@pengutronix.de>
On 05/06/2015 04:17 AM, Michael Grzeschik wrote:
> Commit faad5de0b104 ("watchdog: imx2_wdt: convert to watchdog core api")
> removes the custom ioctl function. The generic ioctl handler is not
> setting the wdog->timeout to the new_timeout but handing this preset
> value back to the userspace. This patch sets the new value in the
> drivers set_timeout function to fix that problem.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2015-05-06 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 11:17 [PATCH] watchdog: imx2_wdt: also set wdog->timeout to new_timeout Michael Grzeschik
2015-05-06 11:17 ` Michael Grzeschik
2015-05-06 13:40 ` Guenter Roeck [this message]
2015-05-06 13:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554A19E0.20509@roeck-us.net \
--to=linux@roeck-us.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=timo.kokkonen@offcode.fi \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.