From: Rhyland Klein <rklein@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Benson Leung <bleung@chromium.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>, <linux-clk@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: tegra: Update struct tegra_clk_pll_params kerneldoc
Date: Wed, 6 May 2015 12:13:45 -0400 [thread overview]
Message-ID: <554A3DB9.8080504@nvidia.com> (raw)
In-Reply-To: <1430919815-22380-1-git-send-email-thierry.reding@gmail.com>
On 5/6/2015 9:43 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Benson Leung pointed out that the kerneldoc for this structure has
> become stale. Update the field descriptions to match the structure
> content.
>
> Reported-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/clk/tegra/clk.h | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h
> index f3782dedbdfb..c47e633616be 100644
> --- a/drivers/clk/tegra/clk.h
> +++ b/drivers/clk/tegra/clk.h
> @@ -157,7 +157,7 @@ struct div_nmp {
> };
>
> /**
> - * struct clk_pll_params - PLL parameters
> + * struct tegra_clk_pll_params - PLL parameters
> *
> * @input_min: Minimum input frequency
> * @input_max: Maximum input frequency
> @@ -168,12 +168,22 @@ struct div_nmp {
> * @base_reg: PLL base reg offset
> * @misc_reg: PLL misc reg offset
> * @lock_reg: PLL lock reg offset
> - * @lock_bit_idx: Bit index for PLL lock status
> + * @lock_mask: Bitmask for PLL lock status
> * @lock_enable_bit_idx: Bit index to enable PLL lock
> + * @iddq_reg: PLL IDDQ register offset
> + * @iddq_bit_idx: Bit index to enable PLL IDDQ
> + * @aux_reg: AUX register offset
> + * @dyn_ramp_reg: Dynamic ramp control register offset
> + * @ext_misc_reg: Miscellaneous control register offsets
> + * @pmc_divnm_reg: n, m divider PMC override register offset (PLLM)
> + * @pmc_divp_reg: p divider PMC override register offset (PLLM)
> + * @flags: PLL flags
> + * @stepa_shift: Dynamic ramp step A field shift
> + * @stepb_shift: Dynamic ramp step B field shift
> * @lock_delay: Delay in us if PLL lock is not used
> + * @div_nmp: offsets and widths on n, m and p fields
> * @freq_table: array of frequencies supported by PLL
> * @fixed_rate: PLL rate if it is fixed
> - * @flags: PLL flags
> *
> * Flags:
> * TEGRA_PLL_USE_LOCK - This flag indicated to use lock bits for
>
Acked-by: Rhyland Klein <rklein@nvidia.com>
-rhyland
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Benson Leung <bleung-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] clk: tegra: Update struct tegra_clk_pll_params kerneldoc
Date: Wed, 6 May 2015 12:13:45 -0400 [thread overview]
Message-ID: <554A3DB9.8080504@nvidia.com> (raw)
In-Reply-To: <1430919815-22380-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 5/6/2015 9:43 AM, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Benson Leung pointed out that the kerneldoc for this structure has
> become stale. Update the field descriptions to match the structure
> content.
>
> Reported-by: Benson Leung <bleung-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/clk/tegra/clk.h | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h
> index f3782dedbdfb..c47e633616be 100644
> --- a/drivers/clk/tegra/clk.h
> +++ b/drivers/clk/tegra/clk.h
> @@ -157,7 +157,7 @@ struct div_nmp {
> };
>
> /**
> - * struct clk_pll_params - PLL parameters
> + * struct tegra_clk_pll_params - PLL parameters
> *
> * @input_min: Minimum input frequency
> * @input_max: Maximum input frequency
> @@ -168,12 +168,22 @@ struct div_nmp {
> * @base_reg: PLL base reg offset
> * @misc_reg: PLL misc reg offset
> * @lock_reg: PLL lock reg offset
> - * @lock_bit_idx: Bit index for PLL lock status
> + * @lock_mask: Bitmask for PLL lock status
> * @lock_enable_bit_idx: Bit index to enable PLL lock
> + * @iddq_reg: PLL IDDQ register offset
> + * @iddq_bit_idx: Bit index to enable PLL IDDQ
> + * @aux_reg: AUX register offset
> + * @dyn_ramp_reg: Dynamic ramp control register offset
> + * @ext_misc_reg: Miscellaneous control register offsets
> + * @pmc_divnm_reg: n, m divider PMC override register offset (PLLM)
> + * @pmc_divp_reg: p divider PMC override register offset (PLLM)
> + * @flags: PLL flags
> + * @stepa_shift: Dynamic ramp step A field shift
> + * @stepb_shift: Dynamic ramp step B field shift
> * @lock_delay: Delay in us if PLL lock is not used
> + * @div_nmp: offsets and widths on n, m and p fields
> * @freq_table: array of frequencies supported by PLL
> * @fixed_rate: PLL rate if it is fixed
> - * @flags: PLL flags
> *
> * Flags:
> * TEGRA_PLL_USE_LOCK - This flag indicated to use lock bits for
>
Acked-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
-rhyland
--
nvpublic
next prev parent reply other threads:[~2015-05-06 16:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 16:38 [PATCH] clk: tegra: Fix comments for structure definitions Rhyland Klein
2015-04-13 16:38 ` Rhyland Klein
2015-04-22 9:40 ` Peter De Schrijver
2015-04-22 9:40 ` Peter De Schrijver
2015-05-04 17:45 ` Benson Leung
2015-05-04 17:45 ` Benson Leung
2015-05-04 20:32 ` Benson Leung
2015-05-04 20:32 ` Benson Leung
2015-05-06 13:43 ` [PATCH] clk: tegra: Update struct tegra_clk_pll_params kerneldoc Thierry Reding
2015-05-06 13:43 ` Thierry Reding
2015-05-06 16:13 ` Rhyland Klein [this message]
2015-05-06 16:13 ` Rhyland Klein
2015-05-06 17:49 ` Benson Leung
2015-05-07 15:23 ` [PATCH v2] " Thierry Reding
2015-05-07 15:23 ` Thierry Reding
2015-05-07 15:41 ` Benson Leung
2015-05-20 3:39 ` Michael Turquette
2015-05-20 3:39 ` Michael Turquette
2015-05-06 13:40 ` [PATCH] clk: tegra: Fix comments for structure definitions Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554A3DB9.8080504@nvidia.com \
--to=rklein@nvidia.com \
--cc=bleung@chromium.org \
--cc=gnurou@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pdeschrijver@nvidia.com \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.