Re: [PATCH V2] Test compaction of mlocked memory

[Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>]

On 04/23/2015 02:24 PM, Shuah Khan wrote:
> On 04/23/2015 02:23 PM, Andrew Morton wrote:
>> On Thu, 23 Apr 2015 14:41:34 -0400 Eric B Munson <emunson-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org> wrote:
>>
>>> On Thu, 23 Apr 2015, Sri Jayaramappa wrote:
>>>
>>>> Commit commit 5bbe3547aa3b ("mm: allow compaction of unevictable pages")
>>>> introduced a sysctl that allows userspace to enable scanning of locked
>>>> pages for compaction.  This patch introduces a new test which fragments
>>>> main memory and attempts to allocate a number of huge pages to exercise
>>>> this compaction logic.
>>>>
>>>> Tested on machines with up to 32 GB RAM. With the patch a much larger
>>>> number of huge pages can be allocated than on the kernel without the
>>>> patch.
>>>>
>>>> Example output:
>>>> On a machine with 16 GB RAM:
>>>> sudo make run_tests vm
>>>> ...
>>>> -----------------------
>>>> running compaction_test
>>>> -----------------------
>>>> No of huge pages allocated = 3834
>>>> [PASS]
>>>> ...
>>>>
>>>> Signed-off-by: Sri Jayaramappa <sjayaram-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
>>>> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>>> Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>>> Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
>>>> Cc: Eric B Munson <emunson-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
>>>
>>> Reviewed-by: Eric B Munson <emunson-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
>>
>> Acked-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
>>
>> I'm assuming that Shuah will process this one?
>>
> 
> Yes. I will get this one after the merge window closes.
> 

Hi Sri Jayaramappa,

The patch didn't pass checkpatch. Several trailing whitespace
errors. Could you please fix these and resend.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978