From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Chuck Lever <chuck.lever@oracle.com>,
linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v1 06/14] xprtrdma: Acquire FMRs in rpcrdma_fmr_register_external()
Date: Thu, 07 May 2015 13:15:50 +0300 [thread overview]
Message-ID: <554B3B56.1010806@dev.mellanox.co.il> (raw)
In-Reply-To: <20150504175739.3483.46010.stgit@manet.1015granger.net>
On 5/4/2015 8:57 PM, Chuck Lever wrote:
> Acquiring 64 FMRs in rpcrdma_buffer_get() while holding the buffer
> pool lock is expensive, and unnecessary because FMR mode can
> transfer up to a 1MB payload using just a single ib_fmr.
>
> Instead, acquire ib_fmrs one-at-a-time as chunks are registered, and
> return them to rb_mws immediately during deregistration.
>
> Transport reset is now unneeded for FMR. Each FMR is recovered
> synchronously when its RPC is retransmitted.
Does this worth a separate patch? I don't see why the two
changes are together. Is there a dependency I'm missing?
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 06/14] xprtrdma: Acquire FMRs in rpcrdma_fmr_register_external()
Date: Thu, 07 May 2015 13:15:50 +0300 [thread overview]
Message-ID: <554B3B56.1010806@dev.mellanox.co.il> (raw)
In-Reply-To: <20150504175739.3483.46010.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
On 5/4/2015 8:57 PM, Chuck Lever wrote:
> Acquiring 64 FMRs in rpcrdma_buffer_get() while holding the buffer
> pool lock is expensive, and unnecessary because FMR mode can
> transfer up to a 1MB payload using just a single ib_fmr.
>
> Instead, acquire ib_fmrs one-at-a-time as chunks are registered, and
> return them to rb_mws immediately during deregistration.
>
> Transport reset is now unneeded for FMR. Each FMR is recovered
> synchronously when its RPC is retransmitted.
Does this worth a separate patch? I don't see why the two
changes are together. Is there a dependency I'm missing?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-07 10:15 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 17:56 [PATCH v1 00/14] client NFS/RDMA patches for 4.2 Chuck Lever
2015-05-04 17:56 ` Chuck Lever
2015-05-04 17:56 ` [PATCH v1 01/14] xprtrdma: Transport fault injection Chuck Lever
2015-05-04 17:56 ` Chuck Lever
2015-05-05 13:49 ` Anna Schumaker
2015-05-05 13:49 ` Anna Schumaker
2015-05-05 13:53 ` Chuck Lever
2015-05-05 13:53 ` Chuck Lever
2015-05-05 14:44 ` Anna Schumaker
2015-05-05 14:44 ` Anna Schumaker
2015-05-05 15:15 ` Chuck Lever
2015-05-05 15:15 ` Chuck Lever
2015-05-05 15:16 ` Anna Schumaker
2015-05-05 15:16 ` Anna Schumaker
2015-05-05 15:10 ` Steve Wise
2015-05-05 15:10 ` Steve Wise
2015-05-04 17:57 ` [PATCH v1 02/14] xprtrdma: Warn when there are orphaned IB objects Chuck Lever
2015-05-04 17:57 ` Chuck Lever
2015-05-06 11:37 ` Devesh Sharma
2015-05-06 11:37 ` Devesh Sharma
2015-05-06 13:24 ` Chuck Lever
2015-05-06 13:24 ` Chuck Lever
2015-05-06 14:05 ` Sagi Grimberg
2015-05-06 14:05 ` Sagi Grimberg
2015-05-06 14:22 ` Devesh Sharma
2015-05-06 14:22 ` Devesh Sharma
2015-05-06 16:48 ` Jason Gunthorpe
2015-05-06 16:48 ` Jason Gunthorpe
2015-05-07 7:53 ` Devesh Sharma
2015-05-07 7:53 ` Devesh Sharma
2015-05-04 17:57 ` [PATCH v1 03/14] xprtrdma: Replace rpcrdma_rep::rr_buffer with rr_rxprt Chuck Lever
2015-05-04 17:57 ` Chuck Lever
2015-05-07 9:38 ` Sagi Grimberg
2015-05-07 9:38 ` Sagi Grimberg
2015-05-07 13:25 ` Chuck Lever
2015-05-07 13:25 ` Chuck Lever
2015-05-04 17:57 ` [PATCH v1 04/14] xprtrdma: Use ib_device pointer safely Chuck Lever
2015-05-04 17:57 ` Chuck Lever
2015-05-07 10:00 ` Sagi Grimberg
2015-05-07 10:00 ` Sagi Grimberg
2015-05-07 13:39 ` Chuck Lever
2015-05-07 13:39 ` Chuck Lever
2015-05-07 13:56 ` Sagi Grimberg
2015-05-07 13:56 ` Sagi Grimberg
2015-05-07 14:12 ` Chuck Lever
2015-05-07 14:12 ` Chuck Lever
2015-05-07 15:11 ` Sagi Grimberg
2015-05-07 15:11 ` Sagi Grimberg
2015-05-11 15:22 ` Chuck Lever
2015-05-11 15:22 ` Chuck Lever
2015-05-11 18:26 ` Hefty, Sean
2015-05-11 18:26 ` Hefty, Sean
2015-05-11 18:57 ` Chuck Lever
2015-05-11 18:57 ` Chuck Lever
2015-05-12 10:01 ` Sagi Grimberg
2015-05-12 10:01 ` Sagi Grimberg
2015-05-04 17:57 ` [PATCH v1 05/14] xprtrdma: Introduce helpers for allocating MWs Chuck Lever
2015-05-04 17:57 ` Chuck Lever
2015-05-07 10:16 ` Sagi Grimberg
2015-05-07 10:16 ` Sagi Grimberg
2015-05-04 17:57 ` [PATCH v1 06/14] xprtrdma: Acquire FMRs in rpcrdma_fmr_register_external() Chuck Lever
2015-05-04 17:57 ` Chuck Lever
2015-05-07 10:15 ` Sagi Grimberg [this message]
2015-05-07 10:15 ` Sagi Grimberg
2015-05-04 17:57 ` [PATCH v1 07/14] xprtrdma: Introduce an FRMR recovery workqueue Chuck Lever
2015-05-04 17:57 ` Chuck Lever
2015-05-07 10:37 ` Devesh Sharma
2015-05-07 10:37 ` Devesh Sharma
2015-05-04 17:57 ` [PATCH v1 08/14] xprtrdma: Acquire MRs in rpcrdma_register_external() Chuck Lever
2015-05-04 17:57 ` Chuck Lever
2015-05-07 10:31 ` Sagi Grimberg
2015-05-07 10:31 ` Sagi Grimberg
2015-05-08 15:24 ` Devesh Sharma
2015-05-08 15:24 ` Devesh Sharma
2015-05-08 15:40 ` Chuck Lever
2015-05-08 15:40 ` Chuck Lever
2015-05-10 10:17 ` Sagi Grimberg
2015-05-10 10:17 ` Sagi Grimberg
2015-05-04 17:58 ` [PATCH v1 09/14] xprtrdma: Remove unused LOCAL_INV recovery logic Chuck Lever
2015-05-04 17:58 ` Chuck Lever
2015-05-07 10:35 ` Sagi Grimberg
2015-05-07 10:35 ` Sagi Grimberg
2015-05-08 15:31 ` Devesh Sharma
2015-05-08 15:31 ` Devesh Sharma
2015-05-04 17:58 ` [PATCH v1 10/14] xprtrdma: Remove ->ro_reset Chuck Lever
2015-05-04 17:58 ` Chuck Lever
2015-05-07 10:36 ` Sagi Grimberg
2015-05-07 10:36 ` Sagi Grimberg
2015-05-08 15:33 ` Devesh Sharma
2015-05-08 15:33 ` Devesh Sharma
2015-05-04 17:58 ` [PATCH v1 11/14] xprtrdma: Remove rpcrdma_ia::ri_memreg_strategy Chuck Lever
2015-05-04 17:58 ` Chuck Lever
2015-05-07 10:36 ` Sagi Grimberg
2015-05-07 10:36 ` Sagi Grimberg
2015-05-08 15:34 ` Devesh Sharma
2015-05-08 15:34 ` Devesh Sharma
2015-05-04 17:58 ` [PATCH v1 12/14] xprtrdma: Split rb_lock Chuck Lever
2015-05-04 17:58 ` Chuck Lever
2015-05-07 10:37 ` Sagi Grimberg
2015-05-07 10:37 ` Sagi Grimberg
2015-05-04 17:58 ` [PATCH v1 13/14] xprtrdma: Stack relief in fmr_op_map() Chuck Lever
2015-05-04 17:58 ` Chuck Lever
2015-05-07 10:50 ` Sagi Grimberg
2015-05-07 10:50 ` Sagi Grimberg
2015-05-08 15:36 ` Devesh Sharma
2015-05-08 15:36 ` Devesh Sharma
2015-05-04 17:58 ` [PATCH v1 14/14] xprtrmda: Reduce per-transport MR allocation Chuck Lever
2015-05-04 17:58 ` Chuck Lever
2015-05-07 11:00 ` Sagi Grimberg
2015-05-07 11:00 ` Sagi Grimberg
2015-05-08 15:53 ` Devesh Sharma
2015-05-08 15:53 ` Devesh Sharma
2015-05-05 15:17 ` [PATCH v1 00/14] client NFS/RDMA patches for 4.2 Steve Wise
2015-05-05 15:17 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B3B56.1010806@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.