dm-snap-persistent: chunk_io doesn't call destroy_work_on_stack in 3.10.76

dm-snap-persistent: chunk_io doesn't call destroy_work_on_stack in 3.10.76

[Akira Hayakawa]

Hi,

I am looking at 3.10.76 kernel and found that
chunk_io function of dm-snap-persistent doesn't call
destroy_work_on_stack to pair with INIT_WORK_ON_STACK.

        INIT_WORK_ONSTACK(&req.work, do_metadata);
        queue_work(ps->metadata_wq, &req.work);
        flush_workqueue(ps->metadata_wq);
        // I think you need it here
 
        return req.result;

Is it not buggy?

- Akira

Re: dm-snap-persistent: chunk_io doesn't call destroy_work_on_stack in 3.10.76

[Minfei Huang]

On 05/08/15 at 04:38P, Akira Hayakawa wrote:
> Hi,
> 
> I am looking at 3.10.76 kernel and found that
> chunk_io function of dm-snap-persistent doesn't call
> destroy_work_on_stack to pair with INIT_WORK_ON_STACK.
> 
>         INIT_WORK_ONSTACK(&req.work, do_metadata);
>         queue_work(ps->metadata_wq, &req.work);
>         flush_workqueue(ps->metadata_wq);
>         // I think you need it here
>  
>         return req.result;
> 
> Is it not buggy?

commit c1a6416021b311fdb5b98e40ed8b29508845ed16
Author: Chuansheng Liu <chuansheng.liu@intel.com>
Date:   Tue Jan 7 16:56:18 2014 +0800

    dm snapshot: call destroy_work_on_stack() to pair with INIT_WORK_ONSTACK()
    
    In case CONFIG_DEBUG_OBJECTS_WORK is defined, it is needed to
    call destroy_work_on_stack() which frees the debug object to pair
    with INIT_WORK_ONSTACK().
    
    Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
    Signed-off-by: Mike Snitzer <snitzer@redhat.com>

Thanks
Minfei

> 
> - Akira
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel