All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: James Bottomley <jbottomley@odin.com>
Cc: Christoph Hellwig <hch@lst.de>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	Hannes Reinecke <hare@suse.de>,
	Mike Christie <michaelc@cs.wisc.edu>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	target-devel <target-devel@vger.kernel.org>
Subject: [PATCH v4 4/5] target: Correct a comment
Date: Fri, 8 May 2015 10:08:55 +0200	[thread overview]
Message-ID: <554C6F17.30501@sandisk.com> (raw)
In-Reply-To: <554C6E79.7020501@sandisk.com>

Correct the comment above the definition of TCM_MAX_COMMAND_SIZE.
A quote from Christoph:

    There aren't any legacy issues, we just decided to handle >
    16 byte CDBs in the slow path.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Mike Christie <michaelc@cs.wisc.edu>
---
 include/target/target_core_base.h | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
index 480e9f8..0203774 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -17,16 +17,8 @@
 /* Don't raise above 511 or REPORT_LUNS needs to handle >1 page */
 #define TRANSPORT_MAX_LUNS_PER_TPG		256
 /*
- * By default we use 32-byte CDBs in TCM Core and subsystem plugin code.
- *
- * Note that both include/scsi/scsi_cmnd.h:MAX_COMMAND_SIZE and
- * include/linux/blkdev.h:BLOCK_MAX_CDB as of v2.6.36-rc4 still use
- * 16-byte CDBs by default and require an extra allocation for
- * 32-byte CDBs to because of legacy issues.
- *
- * Within TCM Core there are no such legacy limitiations, so we go ahead
- * use 32-byte CDBs by default and use include/scsi/scsi.h:scsi_command_size()
- * within all TCM Core and subsystem plugin code.
+ * Maximum size of a CDB that can be stored in se_cmd without allocating
+ * memory dynamically for the CDB.
  */
 #define TCM_MAX_COMMAND_SIZE			32
 /*
-- 
2.1.4


  parent reply	other threads:[~2015-05-08  8:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  8:06 [PATCH v4 0/5] Split SCSI header files Bart Van Assche
2015-05-08  8:07 ` [PATCH v4 1/5] " Bart Van Assche
2015-05-08 12:36   ` Hannes Reinecke
2015-05-11  6:31   ` Christoph Hellwig
2015-05-08  8:07 ` [PATCH v4 2/5] Move code that is used both by initiator and target drivers Bart Van Assche
2015-05-08 12:37   ` Hannes Reinecke
2015-05-11  6:31   ` Christoph Hellwig
2015-05-08  8:08 ` [PATCH v4 3/5] Replace MAX_COMMAND_SIZE with BLK_MAX_CDB Bart Van Assche
2015-05-08 12:37   ` Hannes Reinecke
2015-05-11  6:32   ` Christoph Hellwig
2015-05-11  7:55     ` Bart Van Assche
2015-05-11  7:56       ` Christoph Hellwig
2015-05-08  8:08 ` Bart Van Assche [this message]
2015-05-08 12:38   ` [PATCH v4 4/5] target: Correct a comment Hannes Reinecke
2015-05-08  8:11 ` [PATCH v4 5/5] target: Minimize SCSI header #include directives Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554C6F17.30501@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jbottomley@odin.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.