From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
James Bottomley <jbottomley@odin.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Mike Christie <michaelc@cs.wisc.edu>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
target-devel <target-devel@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] Replace MAX_COMMAND_SIZE with BLK_MAX_CDB
Date: Fri, 08 May 2015 14:37:44 +0200 [thread overview]
Message-ID: <554CAE18.7080000@suse.de> (raw)
In-Reply-To: <554C6EFF.5000400@sandisk.com>
On 05/08/2015 10:08 AM, Bart Van Assche wrote:
> Since the two constants MAX_COMMAND_SIZE and BLK_MAX_CDB have
> the same meaning, replace MAX_COMMAND_SIZE with BLK_MAX_CDB.
>
> This patch has been generated as follows:
> - Removed the MAX_COMMAND_SIZE definitions manually from
> <scsi/scsi_cmnd.h> and also from
> drivers/usb/gadget/function/storage_common.h.
> - Ran the following command over the Linux source tree:
> sed -i.orig 's/\([^a-zA-Z_]\)MAX_COMMAND_SIZE/\1BLK_MAX_CDB/g' $(git grep -lw MAX_COMMAND_SIZE)
>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Cc: Nicholas Bellinger <nab@linux-iscsi.org>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Mike Christie <michaelc@cs.wisc.edu>
> ---
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-05-08 12:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 8:06 [PATCH v4 0/5] Split SCSI header files Bart Van Assche
2015-05-08 8:07 ` [PATCH v4 1/5] " Bart Van Assche
2015-05-08 12:36 ` Hannes Reinecke
2015-05-11 6:31 ` Christoph Hellwig
2015-05-08 8:07 ` [PATCH v4 2/5] Move code that is used both by initiator and target drivers Bart Van Assche
2015-05-08 12:37 ` Hannes Reinecke
2015-05-11 6:31 ` Christoph Hellwig
2015-05-08 8:08 ` [PATCH v4 3/5] Replace MAX_COMMAND_SIZE with BLK_MAX_CDB Bart Van Assche
2015-05-08 12:37 ` Hannes Reinecke [this message]
2015-05-11 6:32 ` Christoph Hellwig
2015-05-11 7:55 ` Bart Van Assche
2015-05-11 7:56 ` Christoph Hellwig
2015-05-08 8:08 ` [PATCH v4 4/5] target: Correct a comment Bart Van Assche
2015-05-08 12:38 ` Hannes Reinecke
2015-05-08 8:11 ` [PATCH v4 5/5] target: Minimize SCSI header #include directives Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554CAE18.7080000@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=jbottomley@odin.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.