All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Hongyang Yang <yanghy@cn.fujitsu.com>, xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
	wency@cn.fujitsu.com, eddie.dong@intel.com,
	yunhong.jiang@intel.com, ian.jackson@eu.citrix.com,
	rshriram@cs.ubc.ca
Subject: Re: [PATCH Remus v1 5/8] tools/libxc: defer the setting of HVM_PARAM_IDENT_PT
Date: Fri, 8 May 2015 09:19:20 +0100	[thread overview]
Message-ID: <554C7188.5050507@citrix.com> (raw)
In-Reply-To: <554C4064.60700@cn.fujitsu.com>

On 08/05/15 05:49, Hongyang Yang wrote:
> Hi Andrew,
>
> On 05/07/2015 11:24 PM, Andrew Cooper wrote:
>> On 07/05/15 14:59, Hongyang Yang wrote:
>>>
>>>
>>> On 05/07/2015 06:35 PM, Andrew Cooper wrote:
>>>> On 07/05/15 07:37, Yang Hongyang wrote:
>>>>> Set the hvm param HVM_PARAM_IDENT_PT second time will fail.
>>>>> So defer the setting of HVM_PARAM_IDENT_PT.
>>>>>
>>>>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>>>>
>>>> I would argue that this is a Xen bug, not a migration bug.  There is
>>>> nothing conceptually wrong with setting this param multiple times.
>>>
>>> I noticed that in legacy migration, this was set multiple times, so
>>> this patch is only a workaround that will avoid the fail in my test.
>>> will try your hypervisor patch tomorrow.
>>
>> Try this version, which has been rebased over Pauls' cleanup in this
>> area which has just been committed to staging.
>
> A quick test show that this patch fix the problem, will you send this
> patch separately or I put this patch into my series?

I am putting together a short series to help your integration.  I shall
include this with a proper commit message etc.

~Andrew

  reply	other threads:[~2015-05-08  8:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07  6:37 [PATCH Remus v1 0/8] Remus support for Migration-v2 Yang Hongyang
2015-05-07  6:37 ` [PATCH Remus v1 1/8] tools/libxc: adjust the memory allocation for migration Yang Hongyang
2015-05-07  9:48   ` Andrew Cooper
2015-05-07 13:42     ` Hongyang Yang
2015-05-07 13:57       ` Ian Campbell
2015-05-08  9:11         ` Hongyang Yang
2015-05-08 16:27         ` David Vrabel
2015-05-08 16:42           ` Ian Campbell
2015-05-07 14:01       ` Andrew Cooper
2015-05-07  6:37 ` [PATCH Remus v1 2/8] tools/libxc: reuse send_some_pages() in send_all_pages() Yang Hongyang
2015-05-07 10:08   ` Andrew Cooper
2015-05-07 13:48     ` Hongyang Yang
2015-05-07  6:37 ` [PATCH Remus v1 3/8] tools/libxc: introduce process_record() Yang Hongyang
2015-05-07 10:12   ` Andrew Cooper
2015-05-07  6:37 ` [PATCH Remus v1 4/8] tools/libxc: split read/handle qemu info Yang Hongyang
2015-05-07 10:48   ` Andrew Cooper
2015-05-07 13:55     ` Hongyang Yang
2015-05-07  6:37 ` [PATCH Remus v1 5/8] tools/libxc: defer the setting of HVM_PARAM_IDENT_PT Yang Hongyang
2015-05-07 10:35   ` Andrew Cooper
2015-05-07 13:59     ` Hongyang Yang
2015-05-07 15:24       ` Andrew Cooper
2015-05-08  4:49         ` Hongyang Yang
2015-05-08  8:19           ` Andrew Cooper [this message]
2015-05-07  6:37 ` [PATCH Remus v1 6/8] tools/libxc: implement Remus checkpointed save Yang Hongyang
2015-05-07  6:37 ` [PATCH Remus v1 7/8] tools/libxc: implement Remus checkpointed restore Yang Hongyang
2015-05-07  6:37 ` [PATCH Remus v1 8/8] tools/libxc: X86_PV_INFO can be sent multiple times under Remus Yang Hongyang
2015-05-07 10:58   ` Andrew Cooper
2015-05-07 14:03     ` Hongyang Yang
2015-05-07  7:04 ` [PATCH Remus v1 0/8] Remus support for Migration-v2 Hongyang Yang
2015-05-07  9:31   ` Andrew Cooper
2015-05-07 15:07     ` Hongyang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554C7188.5050507@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=wei.liu2@citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yanghy@cn.fujitsu.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.