All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Paul Walmsley <paul@pwsan.com>, Dave Gerlach <d-gerlach@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Tony Lindgren <tony@atomide.com>, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH] ARM: OMAP2+: PRM: Fix am437x module reset
Date: Fri, 8 May 2015 14:13:33 -0500	[thread overview]
Message-ID: <554D0ADD.1000304@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1505081749320.19833@utopia.booyaka.com>

Hi Paul,

On 05/08/2015 12:50 PM, Paul Walmsley wrote:
> Hi Dave 
> 
> On Fri, 1 May 2015, Dave Gerlach wrote:
> 
>> When moving to using the OMAP4+ PRM driver on am437x, we switched
>> to using all omap4 ops for module reset management. However, reset
>> register layout on am437x is more similar to am335x than omap4 because
>> of the the need for an st_shift for the *_RST bits in certain *_RSTST
>> registers, like WKUP_PROC_LRST in the PRCM_RM_WKUP_RSTST. Without this
>> we cannot bring the Wakeup M3 IP out of reset.
>>
>> Because of this, we must use the am33xx prm ops for the hardreset
>> functionality while continuing to use all other omap4 ops. To accomplish
>> this we split out the common portion of omap44xx_prm_init and add an
>> am437x_prm_init to register the prm_ll_data struct specific to am437x.
>>
>> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
> 
> I'm assuming this has been superseded by Tero's patches.  If not, please 
> let me know.

Yep, thats right. You can drop/ignore this patch, we did miss Tero's
PRCM cleanup when this patch was rebased.

regards
Suman



WARNING: multiple messages have this Message-ID (diff)
From: s-anna@ti.com (Suman Anna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: PRM: Fix am437x module reset
Date: Fri, 8 May 2015 14:13:33 -0500	[thread overview]
Message-ID: <554D0ADD.1000304@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1505081749320.19833@utopia.booyaka.com>

Hi Paul,

On 05/08/2015 12:50 PM, Paul Walmsley wrote:
> Hi Dave 
> 
> On Fri, 1 May 2015, Dave Gerlach wrote:
> 
>> When moving to using the OMAP4+ PRM driver on am437x, we switched
>> to using all omap4 ops for module reset management. However, reset
>> register layout on am437x is more similar to am335x than omap4 because
>> of the the need for an st_shift for the *_RST bits in certain *_RSTST
>> registers, like WKUP_PROC_LRST in the PRCM_RM_WKUP_RSTST. Without this
>> we cannot bring the Wakeup M3 IP out of reset.
>>
>> Because of this, we must use the am33xx prm ops for the hardreset
>> functionality while continuing to use all other omap4 ops. To accomplish
>> this we split out the common portion of omap44xx_prm_init and add an
>> am437x_prm_init to register the prm_ll_data struct specific to am437x.
>>
>> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
> 
> I'm assuming this has been superseded by Tero's patches.  If not, please 
> let me know.

Yep, thats right. You can drop/ignore this patch, we did miss Tero's
PRCM cleanup when this patch was rebased.

regards
Suman

  reply	other threads:[~2015-05-08 19:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 19:27 [PATCH] ARM: OMAP2+: PRM: Fix am437x module reset Dave Gerlach
2015-05-01 19:27 ` Dave Gerlach
2015-05-04 17:19 ` Tony Lindgren
2015-05-04 17:19   ` Tony Lindgren
2015-05-05 13:17   ` Tero Kristo
2015-05-05 13:17     ` Tero Kristo
2015-05-08 17:50 ` Paul Walmsley
2015-05-08 17:50   ` Paul Walmsley
2015-05-08 19:13   ` Suman Anna [this message]
2015-05-08 19:13     ` Suman Anna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554D0ADD.1000304@ti.com \
    --to=s-anna@ti.com \
    --cc=d-gerlach@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.