From: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
To: Ilia Mirkin <imirkin@alum.mit.edu>, mesa-dev@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org, mesa-stable@lists.freedesktop.org
Subject: Re: [Nouveau] [PATCH] nv50/ir: only enable mul saturate on G200+
Date: Sat, 9 May 2015 17:12:45 +0200 [thread overview]
Message-ID: <554E23ED.9090804@mni.thm.de> (raw)
In-Reply-To: <1431156678-1981-1-git-send-email-imirkin@alum.mit.edu>
Reviewed-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
On 09.05.2015 09:31, Ilia Mirkin wrote:
> Commit 44673512a84 enabled support for saturating fmul. However
> experimentally this does not seem to work on the older chips. Restrict
> the feature to G200 (NVA0) and later.
>
> Reported-by: Pierre Moreau <pierre.morrow@free.fr>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90350
> Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
> Cc: mesa-stable@lists.freedesktop.org
> ---
> src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp
> index 70180eb..ca545a6 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp
> @@ -84,7 +84,7 @@ static const struct opProperties _initProps[] =
> // neg abs not sat c[] s[], a[], imm
> { OP_ADD, 0x3, 0x0, 0x0, 0x8, 0x2, 0x1, 0x1, 0x2 },
> { OP_SUB, 0x3, 0x0, 0x0, 0x8, 0x2, 0x1, 0x1, 0x2 },
> - { OP_MUL, 0x3, 0x0, 0x0, 0x8, 0x2, 0x1, 0x1, 0x2 },
> + { OP_MUL, 0x3, 0x0, 0x0, 0x0, 0x2, 0x1, 0x1, 0x2 },
> { OP_MAX, 0x3, 0x3, 0x0, 0x0, 0x2, 0x1, 0x1, 0x0 },
> { OP_MIN, 0x3, 0x3, 0x0, 0x0, 0x2, 0x1, 0x1, 0x0 },
> { OP_MAD, 0x7, 0x0, 0x0, 0x8, 0x6, 0x1, 0x1, 0x0 }, // special constraint
> @@ -188,6 +188,9 @@ void TargetNV50::initOpInfo()
> if (prop->mSat & 8)
> opInfo[prop->op].dstMods = NV50_IR_MOD_SAT;
> }
> +
> + if (chipset >= 0xa0)
> + opInfo[OP_MUL].dstMods = NV50_IR_MOD_SAT;
> }
>
> unsigned int
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
prev parent reply other threads:[~2015-05-09 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 7:31 [PATCH] nv50/ir: only enable mul saturate on G200+ Ilia Mirkin
[not found] ` <1431156678-1981-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2015-05-09 7:41 ` Pierre Moreau
2015-05-09 15:12 ` Tobias Klausmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554E23ED.9090804@mni.thm.de \
--to=tobias.johannes.klausmann@mni.thm.de \
--cc=imirkin@alum.mit.edu \
--cc=mesa-dev@lists.freedesktop.org \
--cc=mesa-stable@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.