From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
linux-mtd@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Simon Guinot <simon.guinot@sequanux.org>
Subject: Re: [PATCH] ARM: dts: kirkwood: add "nor-jedec" flash compatible binding
Date: Mon, 11 May 2015 15:09:28 +0200 [thread overview]
Message-ID: <5550AA08.5060001@free-electrons.com> (raw)
In-Reply-To: <1431066079-19725-1-git-send-email-zajec5@gmail.com>
Hi Rafał,
On 08/05/2015 08:21, Rafał Miłecki wrote:
> Starting with commits
> 8ff16cf ("Documentation: devicetree: m25p80: add "nor-jedec" binding")
> 1103b85 ("mtd: m25p80: bind to "nor-jedec" ID, for auto-detection")
> we have "nor-jedec" binding indicating support for JEDEC identification.
I have the same question that for mvebu: did you actually check that all
the NOR flash referenced in the dts supports the JEDEC identification?
Then again, if it id the case I will add it in mvebu/dt soon, unless Andrew,
Jason or any other developer who has submitted the dts is aware of a restriction
about applying it.
Thanks,
Gregory
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> arch/arm/boot/dts/kirkwood-b3.dts | 2 +-
> arch/arm/boot/dts/kirkwood-cloudbox.dts | 2 +-
> arch/arm/boot/dts/kirkwood-dir665.dts | 2 +-
> arch/arm/boot/dts/kirkwood-dreamplug.dts | 2 +-
> arch/arm/boot/dts/kirkwood-lsxl.dtsi | 2 +-
> arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 2 +-
> arch/arm/boot/dts/kirkwood-netxbig.dtsi | 2 +-
> arch/arm/boot/dts/kirkwood-ns2-common.dtsi | 2 +-
> arch/arm/boot/dts/kirkwood-rd88f6192.dts | 2 +-
> arch/arm/boot/dts/kirkwood-synology.dtsi | 2 +-
> arch/arm/boot/dts/kirkwood-t5325.dts | 2 +-
> arch/arm/boot/dts/kirkwood-ts219.dtsi | 2 +-
> 12 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-b3.dts b/arch/arm/boot/dts/kirkwood-b3.dts
> index c9247f8..103551f 100644
> --- a/arch/arm/boot/dts/kirkwood-b3.dts
> +++ b/arch/arm/boot/dts/kirkwood-b3.dts
> @@ -74,7 +74,7 @@
> m25p16@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "st,m25p16";
> + compatible = "st,m25p16", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <40000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-cloudbox.dts b/arch/arm/boot/dts/kirkwood-cloudbox.dts
> index ab6ab49..4a04985 100644
> --- a/arch/arm/boot/dts/kirkwood-cloudbox.dts
> +++ b/arch/arm/boot/dts/kirkwood-cloudbox.dts
> @@ -42,7 +42,7 @@
> flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l4005a";
> + compatible = "mxicy,mx25l4005a", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-dir665.dts b/arch/arm/boot/dts/kirkwood-dir665.dts
> index 786959e..94c80a2 100644
> --- a/arch/arm/boot/dts/kirkwood-dir665.dts
> +++ b/arch/arm/boot/dts/kirkwood-dir665.dts
> @@ -93,7 +93,7 @@
> m25p80@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l12805d";
> + compatible = "mxicy,mx25l12805d", "nor-jedec";
> spi-max-frequency = <50000000>;
> reg = <0>;
>
> diff --git a/arch/arm/boot/dts/kirkwood-dreamplug.dts b/arch/arm/boot/dts/kirkwood-dreamplug.dts
> index 6467c79..c9a1c09 100644
> --- a/arch/arm/boot/dts/kirkwood-dreamplug.dts
> +++ b/arch/arm/boot/dts/kirkwood-dreamplug.dts
> @@ -42,7 +42,7 @@
> m25p40@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l1606e";
> + compatible = "mxicy,mx25l1606e", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <50000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> index 5348447..58e197a 100644
> --- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> @@ -74,7 +74,7 @@
> m25p40@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "m25p40";
> + compatible = "m25p40", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <25000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> index f82827d..ae68061 100644
> --- a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> +++ b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> @@ -65,7 +65,7 @@
> flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l12805d";
> + compatible = "mxicy,mx25l12805d", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <50000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-netxbig.dtsi b/arch/arm/boot/dts/kirkwood-netxbig.dtsi
> index b0cfb7c..11d21c0 100644
> --- a/arch/arm/boot/dts/kirkwood-netxbig.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-netxbig.dtsi
> @@ -33,7 +33,7 @@
> flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l4005a";
> + compatible = "mxicy,mx25l4005a", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-ns2-common.dtsi b/arch/arm/boot/dts/kirkwood-ns2-common.dtsi
> index fe6c024..b860b7f 100644
> --- a/arch/arm/boot/dts/kirkwood-ns2-common.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ns2-common.dtsi
> @@ -29,7 +29,7 @@
> flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l4005a";
> + compatible = "mxicy,mx25l4005a", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-rd88f6192.dts b/arch/arm/boot/dts/kirkwood-rd88f6192.dts
> index 35a29de..80dff2f 100644
> --- a/arch/arm/boot/dts/kirkwood-rd88f6192.dts
> +++ b/arch/arm/boot/dts/kirkwood-rd88f6192.dts
> @@ -61,7 +61,7 @@
> m25p128@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "st,m25p128";
> + compatible = "st,m25p128", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-synology.dtsi b/arch/arm/boot/dts/kirkwood-synology.dtsi
> index 8be5b2e..48f4b02 100644
> --- a/arch/arm/boot/dts/kirkwood-synology.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-synology.dtsi
> @@ -217,7 +217,7 @@
> m25p80@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "st,m25p80";
> + compatible = "st,m25p80", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-t5325.dts b/arch/arm/boot/dts/kirkwood-t5325.dts
> index 610ec0f..5dbd9a0 100644
> --- a/arch/arm/boot/dts/kirkwood-t5325.dts
> +++ b/arch/arm/boot/dts/kirkwood-t5325.dts
> @@ -88,7 +88,7 @@
> flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "st,m25p80";
> + compatible = "st,m25p80", "nor-jedec";
> spi-max-frequency = <86000000>;
> reg = <0>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> index df7f152..cbb1049 100644
> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> @@ -49,7 +49,7 @@
> m25p128@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "m25p128";
> + compatible = "m25p128", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: kirkwood: add "nor-jedec" flash compatible binding
Date: Mon, 11 May 2015 15:09:28 +0200 [thread overview]
Message-ID: <5550AA08.5060001@free-electrons.com> (raw)
In-Reply-To: <1431066079-19725-1-git-send-email-zajec5@gmail.com>
Hi Rafa?,
On 08/05/2015 08:21, Rafa? Mi?ecki wrote:
> Starting with commits
> 8ff16cf ("Documentation: devicetree: m25p80: add "nor-jedec" binding")
> 1103b85 ("mtd: m25p80: bind to "nor-jedec" ID, for auto-detection")
> we have "nor-jedec" binding indicating support for JEDEC identification.
I have the same question that for mvebu: did you actually check that all
the NOR flash referenced in the dts supports the JEDEC identification?
Then again, if it id the case I will add it in mvebu/dt soon, unless Andrew,
Jason or any other developer who has submitted the dts is aware of a restriction
about applying it.
Thanks,
Gregory
>
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> ---
> arch/arm/boot/dts/kirkwood-b3.dts | 2 +-
> arch/arm/boot/dts/kirkwood-cloudbox.dts | 2 +-
> arch/arm/boot/dts/kirkwood-dir665.dts | 2 +-
> arch/arm/boot/dts/kirkwood-dreamplug.dts | 2 +-
> arch/arm/boot/dts/kirkwood-lsxl.dtsi | 2 +-
> arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 2 +-
> arch/arm/boot/dts/kirkwood-netxbig.dtsi | 2 +-
> arch/arm/boot/dts/kirkwood-ns2-common.dtsi | 2 +-
> arch/arm/boot/dts/kirkwood-rd88f6192.dts | 2 +-
> arch/arm/boot/dts/kirkwood-synology.dtsi | 2 +-
> arch/arm/boot/dts/kirkwood-t5325.dts | 2 +-
> arch/arm/boot/dts/kirkwood-ts219.dtsi | 2 +-
> 12 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-b3.dts b/arch/arm/boot/dts/kirkwood-b3.dts
> index c9247f8..103551f 100644
> --- a/arch/arm/boot/dts/kirkwood-b3.dts
> +++ b/arch/arm/boot/dts/kirkwood-b3.dts
> @@ -74,7 +74,7 @@
> m25p16 at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "st,m25p16";
> + compatible = "st,m25p16", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <40000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-cloudbox.dts b/arch/arm/boot/dts/kirkwood-cloudbox.dts
> index ab6ab49..4a04985 100644
> --- a/arch/arm/boot/dts/kirkwood-cloudbox.dts
> +++ b/arch/arm/boot/dts/kirkwood-cloudbox.dts
> @@ -42,7 +42,7 @@
> flash at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l4005a";
> + compatible = "mxicy,mx25l4005a", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-dir665.dts b/arch/arm/boot/dts/kirkwood-dir665.dts
> index 786959e..94c80a2 100644
> --- a/arch/arm/boot/dts/kirkwood-dir665.dts
> +++ b/arch/arm/boot/dts/kirkwood-dir665.dts
> @@ -93,7 +93,7 @@
> m25p80 at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l12805d";
> + compatible = "mxicy,mx25l12805d", "nor-jedec";
> spi-max-frequency = <50000000>;
> reg = <0>;
>
> diff --git a/arch/arm/boot/dts/kirkwood-dreamplug.dts b/arch/arm/boot/dts/kirkwood-dreamplug.dts
> index 6467c79..c9a1c09 100644
> --- a/arch/arm/boot/dts/kirkwood-dreamplug.dts
> +++ b/arch/arm/boot/dts/kirkwood-dreamplug.dts
> @@ -42,7 +42,7 @@
> m25p40 at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l1606e";
> + compatible = "mxicy,mx25l1606e", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <50000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> index 5348447..58e197a 100644
> --- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> @@ -74,7 +74,7 @@
> m25p40 at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "m25p40";
> + compatible = "m25p40", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <25000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> index f82827d..ae68061 100644
> --- a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> +++ b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> @@ -65,7 +65,7 @@
> flash at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l12805d";
> + compatible = "mxicy,mx25l12805d", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <50000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-netxbig.dtsi b/arch/arm/boot/dts/kirkwood-netxbig.dtsi
> index b0cfb7c..11d21c0 100644
> --- a/arch/arm/boot/dts/kirkwood-netxbig.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-netxbig.dtsi
> @@ -33,7 +33,7 @@
> flash at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l4005a";
> + compatible = "mxicy,mx25l4005a", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-ns2-common.dtsi b/arch/arm/boot/dts/kirkwood-ns2-common.dtsi
> index fe6c024..b860b7f 100644
> --- a/arch/arm/boot/dts/kirkwood-ns2-common.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ns2-common.dtsi
> @@ -29,7 +29,7 @@
> flash at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "mxicy,mx25l4005a";
> + compatible = "mxicy,mx25l4005a", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-rd88f6192.dts b/arch/arm/boot/dts/kirkwood-rd88f6192.dts
> index 35a29de..80dff2f 100644
> --- a/arch/arm/boot/dts/kirkwood-rd88f6192.dts
> +++ b/arch/arm/boot/dts/kirkwood-rd88f6192.dts
> @@ -61,7 +61,7 @@
> m25p128 at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "st,m25p128";
> + compatible = "st,m25p128", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-synology.dtsi b/arch/arm/boot/dts/kirkwood-synology.dtsi
> index 8be5b2e..48f4b02 100644
> --- a/arch/arm/boot/dts/kirkwood-synology.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-synology.dtsi
> @@ -217,7 +217,7 @@
> m25p80 at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "st,m25p80";
> + compatible = "st,m25p80", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-t5325.dts b/arch/arm/boot/dts/kirkwood-t5325.dts
> index 610ec0f..5dbd9a0 100644
> --- a/arch/arm/boot/dts/kirkwood-t5325.dts
> +++ b/arch/arm/boot/dts/kirkwood-t5325.dts
> @@ -88,7 +88,7 @@
> flash at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "st,m25p80";
> + compatible = "st,m25p80", "nor-jedec";
> spi-max-frequency = <86000000>;
> reg = <0>;
> mode = <0>;
> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> index df7f152..cbb1049 100644
> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> @@ -49,7 +49,7 @@
> m25p128 at 0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "m25p128";
> + compatible = "m25p128", "nor-jedec";
> reg = <0>;
> spi-max-frequency = <20000000>;
> mode = <0>;
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-05-11 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 6:21 [PATCH] ARM: dts: kirkwood: add "nor-jedec" flash compatible binding Rafał Miłecki
2015-05-08 6:21 ` Rafał Miłecki
2015-05-11 13:09 ` Gregory CLEMENT [this message]
2015-05-11 13:09 ` Gregory CLEMENT
2015-05-11 13:25 ` Andrew Lunn
2015-05-11 13:25 ` Andrew Lunn
2015-05-12 5:15 ` Rafał Miłecki
2015-05-12 5:15 ` Rafał Miłecki
2015-05-12 5:07 ` Rafał Miłecki
2015-05-12 5:07 ` Rafał Miłecki
2015-05-15 12:45 ` Gregory CLEMENT
2015-05-15 12:45 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5550AA08.5060001@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=simon.guinot@sequanux.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.