From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 2/4] gpio: gpio-generic: add flag to read out output value from reg_set
Date: Mon, 11 May 2015 16:28:05 +0300 [thread overview]
Message-ID: <5550AE65.8070401@mentor.com> (raw)
In-Reply-To: <CACRpkdbw_Gy5Qswp=90hwL=iOfxQSHBEk6rSRLhBKWoP6Le+LA@mail.gmail.com>
On 11.05.2015 12:50, Linus Walleij wrote:
> On Wed, Apr 29, 2015 at 5:34 PM, Vladimir Zapolskiy
> <vladimir_zapolskiy@mentor.com> wrote:
>
>> The change introduces BGPIOF_READ_OUTPUT_REG_SET flag for gpio-generic
>> GPIO chip implementation, which allows to get correct configured value
>> from reg_set register, input value is still get from reg_dat.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
>
> Looks reasonable. Patch applied.
>
> Do we need device tree bindings for this?
I don't think so, particular drivers have this as a fixed property, and
"basic-mmio-gpio" has no device tree bindings.
OTOH let see on dynamics of the flag usage, if it grows, it may happen
that its negation is a better candidate for a quirk.
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2015-05-11 13:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 15:34 [PATCH 0/4] gpio: generic: add option to read output value from set register Vladimir Zapolskiy
2015-04-29 15:34 ` [PATCH 1/4] Revert "gpio: generic: clamp retured value to [0,1]" Vladimir Zapolskiy
2015-05-11 9:46 ` Linus Walleij
2015-05-11 13:12 ` Vladimir Zapolskiy
2015-05-12 7:45 ` Alexandre Courbot
2015-05-12 7:54 ` Vladimir Zapolskiy
2015-05-12 11:52 ` Linus Walleij
2015-04-29 15:34 ` [PATCH 2/4] gpio: gpio-generic: add flag to read out output value from reg_set Vladimir Zapolskiy
2015-05-11 9:50 ` Linus Walleij
2015-05-11 13:28 ` Vladimir Zapolskiy [this message]
2015-04-29 15:35 ` [PATCH 3/4] gpio: moxart: get value of output gpio from generic driver Vladimir Zapolskiy
2015-05-11 9:52 ` Linus Walleij
2015-05-11 12:17 ` Jonas Jensen
2015-05-11 13:17 ` Vladimir Zapolskiy
2015-04-29 15:35 ` [PATCH 4/4] gpio: mxc: read output value from GPIO_DR register Vladimir Zapolskiy
2015-05-11 9:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5550AE65.8070401@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.