[review-request] michaelw/table-porting

[review-request] michaelw/table-porting

[Michael Wood]

commit 2951e0228000ad9bbd40b96e33a46ff0ad53dd45
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Mon May 11 18:51:28 2015 +0100

     bitbake: toaster: Port All recipes, layers and machines to 
ToasterTables

     Port of the main tables to the new ToasterTable widget.

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>

commit 5f2ba9929b6d724bbf211c1461c009c4cb5345c3
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Fri May 8 17:24:11 2015 +0100

     bitbake: toaster: Add toaster table widget

     This widget provides a common client and backend widget to support
     presenting data tables in Toaster.

     It provides; data loading, paging, page size, ordering, filtering,
     column toggling, caching, column defaults, counts and search.

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>

Re: [review-request] michaelw/table-porting

[Barros Pena, Belen]

Those tables are working beautifully. The autocomplete suggestions still
don't though. 

Thanks!

Belén

On 12/05/2015 15:57, "Michael Wood" <michael.g.wood@intel.com> wrote:

>On 12/05/15 14:36, Michael Wood wrote:
>> On 12/05/15 11:21, Barros Pena, Belen wrote:
>>> Hi Michael,
>>>
>>> It pretty much works :) apart from a few glitches. There they go:
>>>
>>> * Autocomplete is not working in this branch (it does work on master)
>>
>> Not me this one, I think it's probably the URL refactor which may be
>> fixed somewhere. It's broken in master too.
>> I've added a patch on this branch to fix it.

>>I'll find out what's
>> going on.
>>
>>>
>>> * The tables don't seem to recognise the layers added to the project.
>>>If
>>> you create a project, then go to the all layers table, then search for
>>> meta-yocto, it shows the 'add layer' button (but the layer is already
>>> added to the project). If you add a layer, then refresh the page, the
>>> layer you just added shows the 'add layer' button, instead of the
>>> 'delete'
>>> button.
>>
>> This is the issue you commented on a bug this morning
>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=7708
>>
>
>Sorry about that, I jumped the gun, the list of current layers wasn't
>being returned (for some reason the project layers are called
>"layercommit" in the database and I didn't test it after changing the
>get layers function, I assumed it would be "layer id" crazy assumption!)
>
>I've pushed this fix to the branch
>
>
>>
>>>
>>> All recipes table:
>>>
>>> * This table is missing the 'layer' column
>> Done
>>>
>>> * Would it be possible to set a span class in the 'Description' column
>>> heading. Otherwise it just takes over the whole table.
>> Done
>>>
>>> * Sorting doesn't seem to be working in this table. The 'recipe'
>>>heading
>>> appears sorted when you load the table, but the recipes are not sorted.
>>> When you click on the heading, it sorts by z to a.
>>
>> Done
>>
>>>
>>> Thanks!
>>>
>>> Belén
>>>
>>>
>>>
>>> On 11/05/2015 20:50, "Michael Wood" <michael.g.wood@intel.com> wrote:
>>>
>>>> commit 2951e0228000ad9bbd40b96e33a46ff0ad53dd45
>>>> Author: Michael Wood <michael.g.wood@intel.com>
>>>> Date:   Mon May 11 18:51:28 2015 +0100
>>>>
>>>>      bitbake: toaster: Port All recipes, layers and machines to
>>>> ToasterTables
>>>>
>>>>      Port of the main tables to the new ToasterTable widget.
>>>>
>>>>      Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>>>>
>>>> commit 5f2ba9929b6d724bbf211c1461c009c4cb5345c3
>>>> Author: Michael Wood <michael.g.wood@intel.com>
>>>> Date:   Fri May 8 17:24:11 2015 +0100
>>>>
>>>>      bitbake: toaster: Add toaster table widget
>>>>
>>>>      This widget provides a common client and backend widget to
>>>>support
>>>>      presenting data tables in Toaster.
>>>>
>>>>      It provides; data loading, paging, page size, ordering,
>>>>filtering,
>>>>      column toggling, caching, column defaults, counts and search.
>>>>
>>>>      Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>>>>
>>>> -- 
>>>> _______________________________________________
>>>> toaster mailing list
>>>> toaster@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/toaster
>>
>

Re: [review-request] michaelw/table-porting

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 3943 bytes --]

Taken for submission, as it is.

Any fixes will have to come on top of this patch set.

Cheers,
Alex

On Tue, May 12, 2015 at 4:49 PM, Barros Pena, Belen <
belen.barros.pena@intel.com> wrote:

> Those tables are working beautifully. The autocomplete suggestions still
> don't though.
>
> Thanks!
>
> Belén
>
> On 12/05/2015 15:57, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
> >On 12/05/15 14:36, Michael Wood wrote:
> >> On 12/05/15 11:21, Barros Pena, Belen wrote:
> >>> Hi Michael,
> >>>
> >>> It pretty much works :) apart from a few glitches. There they go:
> >>>
> >>> * Autocomplete is not working in this branch (it does work on master)
> >>
> >> Not me this one, I think it's probably the URL refactor which may be
> >> fixed somewhere. It's broken in master too.
> >> I've added a patch on this branch to fix it.
>
> >>I'll find out what's
> >> going on.
> >>
> >>>
> >>> * The tables don't seem to recognise the layers added to the project.
> >>>If
> >>> you create a project, then go to the all layers table, then search for
> >>> meta-yocto, it shows the 'add layer' button (but the layer is already
> >>> added to the project). If you add a layer, then refresh the page, the
> >>> layer you just added shows the 'add layer' button, instead of the
> >>> 'delete'
> >>> button.
> >>
> >> This is the issue you commented on a bug this morning
> >> https://bugzilla.yoctoproject.org/show_bug.cgi?id=7708
> >>
> >
> >Sorry about that, I jumped the gun, the list of current layers wasn't
> >being returned (for some reason the project layers are called
> >"layercommit" in the database and I didn't test it after changing the
> >get layers function, I assumed it would be "layer id" crazy assumption!)
> >
> >I've pushed this fix to the branch
> >
> >
> >>
> >>>
> >>> All recipes table:
> >>>
> >>> * This table is missing the 'layer' column
> >> Done
> >>>
> >>> * Would it be possible to set a span class in the 'Description' column
> >>> heading. Otherwise it just takes over the whole table.
> >> Done
> >>>
> >>> * Sorting doesn't seem to be working in this table. The 'recipe'
> >>>heading
> >>> appears sorted when you load the table, but the recipes are not sorted.
> >>> When you click on the heading, it sorts by z to a.
> >>
> >> Done
> >>
> >>>
> >>> Thanks!
> >>>
> >>> Belén
> >>>
> >>>
> >>>
> >>> On 11/05/2015 20:50, "Michael Wood" <michael.g.wood@intel.com> wrote:
> >>>
> >>>> commit 2951e0228000ad9bbd40b96e33a46ff0ad53dd45
> >>>> Author: Michael Wood <michael.g.wood@intel.com>
> >>>> Date:   Mon May 11 18:51:28 2015 +0100
> >>>>
> >>>>      bitbake: toaster: Port All recipes, layers and machines to
> >>>> ToasterTables
> >>>>
> >>>>      Port of the main tables to the new ToasterTable widget.
> >>>>
> >>>>      Signed-off-by: Michael Wood <michael.g.wood@intel.com>
> >>>>
> >>>> commit 5f2ba9929b6d724bbf211c1461c009c4cb5345c3
> >>>> Author: Michael Wood <michael.g.wood@intel.com>
> >>>> Date:   Fri May 8 17:24:11 2015 +0100
> >>>>
> >>>>      bitbake: toaster: Add toaster table widget
> >>>>
> >>>>      This widget provides a common client and backend widget to
> >>>>support
> >>>>      presenting data tables in Toaster.
> >>>>
> >>>>      It provides; data loading, paging, page size, ordering,
> >>>>filtering,
> >>>>      column toggling, caching, column defaults, counts and search.
> >>>>
> >>>>      Signed-off-by: Michael Wood <michael.g.wood@intel.com>
> >>>>
> >>>> --
> >>>> _______________________________________________
> >>>> toaster mailing list
> >>>> toaster@yoctoproject.org
> >>>> https://lists.yoctoproject.org/listinfo/toaster
> >>
> >
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 6701 bytes --]