From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Antoine Tenart <antoine.tenart@free-electrons.com>,
sebastian.hesselbarth@gmail.com, dwmw2@infradead.org,
computersforpeace@gmail.com
Cc: zmxu@marvell.com, boris.brezillon@free-electrons.com,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
jszhang@marvell.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 05/12] mtd: pxa3xx_nand: rework flash detection and timing setup
Date: Mon, 11 May 2015 19:10:56 -0300 [thread overview]
Message-ID: <555128F0.30702@vanguardiasur.com.ar> (raw)
In-Reply-To: <1431356341-31640-6-git-send-email-antoine.tenart@free-electrons.com>
On 05/11/2015 11:58 AM, Antoine Tenart wrote:
[..]
> -
> - /* calculate flash information */
> - host->read_id_bytes = (f->page_size == 2048) ? 4 : 2;
> -
[..]
> @@ -1732,6 +1669,7 @@ static int alloc_nand_resource(struct platform_device *pdev)
> host->mtd = mtd;
> host->cs = cs;
> host->info_data = info;
> + host->read_id_bytes = 4;
Are you sure this is correct? The value is set according to the page
size before this patch.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel@vanguardiasur.com.ar (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 05/12] mtd: pxa3xx_nand: rework flash detection and timing setup
Date: Mon, 11 May 2015 19:10:56 -0300 [thread overview]
Message-ID: <555128F0.30702@vanguardiasur.com.ar> (raw)
In-Reply-To: <1431356341-31640-6-git-send-email-antoine.tenart@free-electrons.com>
On 05/11/2015 11:58 AM, Antoine Tenart wrote:
[..]
> -
> - /* calculate flash information */
> - host->read_id_bytes = (f->page_size == 2048) ? 4 : 2;
> -
[..]
> @@ -1732,6 +1669,7 @@ static int alloc_nand_resource(struct platform_device *pdev)
> host->mtd = mtd;
> host->cs = cs;
> host->info_data = info;
> + host->read_id_bytes = 4;
Are you sure this is correct? The value is set according to the page
size before this patch.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Antoine Tenart <antoine.tenart@free-electrons.com>,
sebastian.hesselbarth@gmail.com, dwmw2@infradead.org,
computersforpeace@gmail.com
Cc: boris.brezillon@free-electrons.com, zmxu@marvell.com,
jszhang@marvell.com, linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 05/12] mtd: pxa3xx_nand: rework flash detection and timing setup
Date: Mon, 11 May 2015 19:10:56 -0300 [thread overview]
Message-ID: <555128F0.30702@vanguardiasur.com.ar> (raw)
In-Reply-To: <1431356341-31640-6-git-send-email-antoine.tenart@free-electrons.com>
On 05/11/2015 11:58 AM, Antoine Tenart wrote:
[..]
> -
> - /* calculate flash information */
> - host->read_id_bytes = (f->page_size == 2048) ? 4 : 2;
> -
[..]
> @@ -1732,6 +1669,7 @@ static int alloc_nand_resource(struct platform_device *pdev)
> host->mtd = mtd;
> host->cs = cs;
> host->info_data = info;
> + host->read_id_bytes = 4;
Are you sure this is correct? The value is set according to the page
size before this patch.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2015-05-11 22:14 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 14:58 [PATCH v5 00/12] ARM: berlin: add nand support Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` [PATCH v5 01/12] mtd: pxa3xx_nand: add a non mandatory ECC clock Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` [PATCH v5 02/12] Documentation: bindings: document the clocks for pxa3xx-nand Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` [PATCH v5 03/12] mtd: pxa3xx_nand: add a default chunk size Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` [PATCH v5 04/12] mtd: pxa3xx_nand: add helpers to setup the timings Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` [PATCH v5 05/12] mtd: pxa3xx_nand: rework flash detection and timing setup Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 22:10 ` Ezequiel Garcia [this message]
2015-05-11 22:10 ` Ezequiel Garcia
2015-05-11 22:10 ` Ezequiel Garcia
2015-05-12 14:39 ` Antoine Tenart
2015-05-12 14:39 ` Antoine Tenart
2015-05-12 14:39 ` Antoine Tenart
2015-05-16 21:23 ` Ezequiel Garcia
2015-05-16 21:23 ` Ezequiel Garcia
2015-05-16 21:23 ` Ezequiel Garcia
2015-05-20 13:55 ` Antoine Tenart
2015-05-20 13:55 ` Antoine Tenart
2015-05-20 13:55 ` Antoine Tenart
2015-05-20 13:56 ` Ezequiel Garcia
2015-05-20 13:56 ` Ezequiel Garcia
2015-05-20 13:56 ` Ezequiel Garcia
2015-05-20 14:04 ` Antoine Tenart
2015-05-20 14:04 ` Antoine Tenart
2015-05-20 14:04 ` Antoine Tenart
2015-05-16 22:02 ` Ezequiel Garcia
2015-05-16 22:02 ` Ezequiel Garcia
2015-05-16 22:02 ` Ezequiel Garcia
2015-05-20 14:03 ` Antoine Tenart
2015-05-20 14:03 ` Antoine Tenart
2015-05-20 14:03 ` Antoine Tenart
2015-05-20 14:05 ` Ezequiel Garcia
2015-05-20 14:05 ` Ezequiel Garcia
2015-05-20 14:05 ` Ezequiel Garcia
2015-05-11 14:58 ` [PATCH v5 06/12] mtd: pxa3xx_nand: clean up the pxa3xx timings Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` [PATCH v5 07/12] mtd: nand: add Samsung K9GBG08U0A-M to nand_ids table Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-16 18:57 ` Ezequiel Garcia
2015-05-16 18:57 ` Ezequiel Garcia
2015-05-16 18:57 ` Ezequiel Garcia
2015-05-20 14:06 ` Antoine Tenart
2015-05-20 14:06 ` Antoine Tenart
2015-05-20 14:06 ` Antoine Tenart
2015-05-20 14:09 ` Ezequiel Garcia
2015-05-20 14:09 ` Ezequiel Garcia
2015-05-20 14:09 ` Ezequiel Garcia
2015-05-20 14:24 ` Antoine Tenart
2015-05-20 14:24 ` Antoine Tenart
2015-05-20 14:24 ` Antoine Tenart
2015-05-20 14:43 ` Antoine Tenart
2015-05-20 14:43 ` Antoine Tenart
2015-05-20 14:43 ` Antoine Tenart
2015-05-24 18:42 ` Ezequiel Garcia
2015-05-24 18:42 ` Ezequiel Garcia
2015-05-24 18:42 ` Ezequiel Garcia
2015-07-20 18:08 ` Brian Norris
2015-07-20 18:08 ` Brian Norris
2015-07-20 18:22 ` Ezequiel Garcia
2015-07-20 18:22 ` Ezequiel Garcia
2015-05-11 14:58 ` [PATCH v5 08/12] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` [PATCH v5 09/12] Documentation: bindings: add the Berlin nand controller compatible Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` [PATCH v5 10/12] mtd: nand: let Marvell Berlin SoCs select the pxa3xx driver Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:58 ` Antoine Tenart
2015-05-11 14:59 ` [PATCH v5 11/12] ARM: berlin: add BG2Q node for the nand Antoine Tenart
2015-05-11 14:59 ` Antoine Tenart
2015-05-11 14:59 ` Antoine Tenart
2015-05-11 14:59 ` [PATCH v5 12/12] ARM: berlin: enable flash on the BG2Q DMP Antoine Tenart
2015-05-11 14:59 ` Antoine Tenart
2015-05-11 14:59 ` Antoine Tenart
2015-05-16 21:37 ` [PATCH v5 00/12] ARM: berlin: add nand support Ezequiel Garcia
2015-05-16 21:37 ` Ezequiel Garcia
2015-05-16 21:37 ` Ezequiel Garcia
2015-05-20 14:08 ` Antoine Tenart
2015-05-20 14:08 ` Antoine Tenart
2015-05-20 14:08 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555128F0.30702@vanguardiasur.com.ar \
--to=ezequiel@vanguardiasur.com.ar \
--cc=antoine.tenart@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.