All of lore.kernel.org
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: Zynq: DT: Enable xadc node in zynq-parallella.dts
Date: Tue, 12 May 2015 14:13:20 +0200	[thread overview]
Message-ID: <5551EE60.40601@suse.de> (raw)
In-Reply-To: <1431037945-40360-2-git-send-email-xander.huff@ni.com>

Am 08.05.2015 um 00:32 schrieb Xander Huff:
> Now that zynq-7000 disables xadc by default, enable in zynq-parallella
> to retain existing behavior.
> 
> Signed-off-by: Xander Huff <xander.huff@ni.com>
> ---
>  arch/arm/boot/dts/zynq-parallella.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
> index 1745712..b1a1f7a 100644
> --- a/arch/arm/boot/dts/zynq-parallella.dts
> +++ b/arch/arm/boot/dts/zynq-parallella.dts
> @@ -32,6 +32,12 @@
>  		bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootfstype=ext4 rw rootwait";
>  		linux,stdout-path = "/amba/serial at e0001000";
>  	};
> +
> +	amba {
> +		adc: adc at f8007100 {
> +			status = "okay";
> +		};
> +	};

You've already discarded this patchset, but please note for the future
that the desired style would've been the one you see below, i.e.

>  };

&adc {
	status = "okay";
};

Regards,
Andreas

>  
>  &clkc {
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG N?rnberg)

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
To: Xander Huff <xander.huff-acOepvfBmUk@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ben.shelton-acOepvfBmUk@public.gmane.org,
	michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
	joe.hershberger-acOepvfBmUk@public.gmane.org,
	soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
	joshc-acOepvfBmUk@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/6] ARM: Zynq: DT: Enable xadc node in zynq-parallella.dts
Date: Tue, 12 May 2015 14:13:20 +0200	[thread overview]
Message-ID: <5551EE60.40601@suse.de> (raw)
In-Reply-To: <1431037945-40360-2-git-send-email-xander.huff-acOepvfBmUk@public.gmane.org>

Am 08.05.2015 um 00:32 schrieb Xander Huff:
> Now that zynq-7000 disables xadc by default, enable in zynq-parallella
> to retain existing behavior.
> 
> Signed-off-by: Xander Huff <xander.huff-acOepvfBmUk@public.gmane.org>
> ---
>  arch/arm/boot/dts/zynq-parallella.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
> index 1745712..b1a1f7a 100644
> --- a/arch/arm/boot/dts/zynq-parallella.dts
> +++ b/arch/arm/boot/dts/zynq-parallella.dts
> @@ -32,6 +32,12 @@
>  		bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootfstype=ext4 rw rootwait";
>  		linux,stdout-path = "/amba/serial@e0001000";
>  	};
> +
> +	amba {
> +		adc: adc@f8007100 {
> +			status = "okay";
> +		};
> +	};

You've already discarded this patchset, but please note for the future
that the desired style would've been the one you see below, i.e.

>  };

&adc {
	status = "okay";
};

Regards,
Andreas

>  
>  &clkc {
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-05-12 12:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 22:32 [PATCH 1/6] ARM: Zynq: DT: Disable xadc node by default in zynq-7000.dtsi Xander Huff
2015-05-07 22:32 ` Xander Huff
2015-05-07 22:32 ` [PATCH 2/6] ARM: Zynq: DT: Enable xadc node in zynq-parallella.dts Xander Huff
2015-05-07 22:32   ` Xander Huff
2015-05-12 12:13   ` Andreas Färber [this message]
2015-05-12 12:13     ` Andreas Färber
2015-05-07 22:32 ` [PATCH 3/6] ARM: Zynq: DT: Enable xadc node in zynq-zc702.dts Xander Huff
2015-05-07 22:32   ` Xander Huff
2015-05-07 22:32 ` [PATCH 4/6] ARM: Zynq: DT: Enable xadc node in zynq-zc706.dts Xander Huff
2015-05-07 22:32   ` Xander Huff
2015-05-07 22:32 ` [PATCH 5/6] ARM: Zynq: DT: Enable xadc node in zynq-zed.dts Xander Huff
2015-05-07 22:32   ` Xander Huff
2015-05-07 22:32 ` [PATCH 6/6] ARM: Zynq: DT: Enable xadc node in zynq-zybo.dts Xander Huff
2015-05-07 22:32   ` Xander Huff
2015-05-07 22:36 ` [PATCH 1/6] ARM: Zynq: DT: Disable xadc node by default in zynq-7000.dtsi Sören Brinkmann
2015-05-07 22:36   ` Sören Brinkmann
2015-05-08 14:53   ` Xander Huff
2015-05-08 14:53     ` Xander Huff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5551EE60.40601@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.