From: Nishanth Menon <nm@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Michael Welling <mwelling@ieee.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-next@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs
Date: Tue, 12 May 2015 14:21:47 -0500 [thread overview]
Message-ID: <555252CB.3010208@ti.com> (raw)
In-Reply-To: <20150512191905.GY3066@sirena.org.uk>
On 05/12/2015 02:19 PM, Mark Brown wrote:
> On Tue, May 12, 2015 at 01:57:36PM -0500, Nishanth Menon wrote:
>> On 05/12/2015 12:38 PM, Michael Welling wrote:
>>> GPIO chip select patch series appears to have broken the native chip select
>>> support. This patch pulls the manual native chip select toggling out of
>>> the transfer_one routine and adds a set_cs routine.
>
> Please remember to delete unneeded context from your replies, the reader
> shouldn't need to page through the entire patch to find out you reviewed
> it.
Will do so. Anyways, I did test it to be accurate - have'nt reviewed it.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Michael Welling <mwelling@ieee.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-next@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs
Date: Tue, 12 May 2015 14:21:47 -0500 [thread overview]
Message-ID: <555252CB.3010208@ti.com> (raw)
In-Reply-To: <20150512191905.GY3066@sirena.org.uk>
On 05/12/2015 02:19 PM, Mark Brown wrote:
> On Tue, May 12, 2015 at 01:57:36PM -0500, Nishanth Menon wrote:
>> On 05/12/2015 12:38 PM, Michael Welling wrote:
>>> GPIO chip select patch series appears to have broken the native chip select
>>> support. This patch pulls the manual native chip select toggling out of
>>> the transfer_one routine and adds a set_cs routine.
>
> Please remember to delete unneeded context from your replies, the reader
> shouldn't need to page through the entire patch to find out you reviewed
> it.
Will do so. Anyways, I did test it to be accurate - have'nt reviewed it.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs
Date: Tue, 12 May 2015 14:21:47 -0500 [thread overview]
Message-ID: <555252CB.3010208@ti.com> (raw)
In-Reply-To: <20150512191905.GY3066@sirena.org.uk>
On 05/12/2015 02:19 PM, Mark Brown wrote:
> On Tue, May 12, 2015 at 01:57:36PM -0500, Nishanth Menon wrote:
>> On 05/12/2015 12:38 PM, Michael Welling wrote:
>>> GPIO chip select patch series appears to have broken the native chip select
>>> support. This patch pulls the manual native chip select toggling out of
>>> the transfer_one routine and adds a set_cs routine.
>
> Please remember to delete unneeded context from your replies, the reader
> shouldn't need to page through the entire patch to find out you reviewed
> it.
Will do so. Anyways, I did test it to be accurate - have'nt reviewed it.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2015-05-12 19:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:38 [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs Michael Welling
2015-05-12 17:38 ` Michael Welling
2015-05-12 18:57 ` Nishanth Menon
2015-05-12 18:57 ` Nishanth Menon
2015-05-12 18:57 ` Nishanth Menon
[not found] ` <55524D20.2050203-l0cyMroinI0@public.gmane.org>
2015-05-12 19:19 ` Mark Brown
2015-05-12 19:19 ` Mark Brown
2015-05-12 19:19 ` Mark Brown
2015-05-12 19:21 ` Nishanth Menon [this message]
2015-05-12 19:21 ` Nishanth Menon
2015-05-12 19:21 ` Nishanth Menon
2015-05-12 19:17 ` Mark Brown
2015-05-12 19:17 ` Mark Brown
[not found] ` <20150512191758.GX3066-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-21 2:07 ` Michael Welling
2015-05-21 2:07 ` Michael Welling
2015-05-21 2:07 ` Michael Welling
2015-05-21 10:18 ` Mark Brown
2015-05-21 10:18 ` Mark Brown
2015-05-21 21:04 ` Michael Welling
2015-05-21 21:04 ` Michael Welling
2015-05-21 21:16 ` Mark Brown
2015-05-21 21:16 ` Mark Brown
2015-05-21 23:48 ` Michael Welling
2015-05-21 23:48 ` Michael Welling
2015-05-22 12:25 ` Mark Brown
2015-05-22 12:25 ` Mark Brown
2015-05-22 12:25 ` Mark Brown
2015-05-22 15:31 ` Michael Welling
2015-05-22 15:31 ` Michael Welling
2015-05-24 2:13 ` [PATCH 0/4] spi: omap2-mcspi: Fixes for recent updates Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 2:13 ` [PATCH 1/4] spi: omap2-mcspi: Remove unnecessary delay Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 2:13 ` [PATCH 2/4] spi: omap2-mcspi: Fix set_cs function for active high Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 2:13 ` [PATCH 3/4] spi: omap2-mcspi: Fix GPIO chip select support Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 2:13 ` [PATCH 4/4] spi: omap2-mcspi: Handle error on gpio_request Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 8:13 ` Nicholas Mc Guire
2015-05-24 8:13 ` Nicholas Mc Guire
2015-05-24 16:52 ` Michael Welling
2015-05-24 16:52 ` Michael Welling
[not found] ` <1432433625-23407-1-git-send-email-mwelling-EkmVulN54Sk@public.gmane.org>
2015-05-25 12:00 ` [PATCH 0/4] spi: omap2-mcspi: Fixes for recent updates Mark Brown
2015-05-25 12:00 ` Mark Brown
2015-05-25 12:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555252CB.3010208@ti.com \
--to=nm@ti.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.