From: Richard Henderson <rth@twiddle.net>
To: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions
Date: Tue, 12 May 2015 13:27:25 -0700 [thread overview]
Message-ID: <5552622D.6020305@twiddle.net> (raw)
In-Reply-To: <1431462031-46912-1-git-send-email-agraf@suse.de>
On 05/12/2015 01:20 PM, Alexander Graf wrote:
> +static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
> +{
> + /* XXX should reserve the address */
> + in2_m2_32s(s, f, o);
> +}
> +#define SPEC_in2_m2_32s_atomic 0
> +
> +static void in2_m2_64_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
> +{
> + /* XXX should reserve the address */
> + in2_m2_64(s, f, o);
> +}
> +#define SPEC_in2_m2_64_atomic 0
> +
I think these should save the address in o->addr1 so that you don't have to
recompute it in the wout functions.
Otherwise I think this is a great scheme, making it easy to implement this
whole family of instructions.
r~
next prev parent reply other threads:[~2015-05-12 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 20:20 [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions Alexander Graf
2015-05-12 20:27 ` Richard Henderson [this message]
2015-05-12 20:42 ` Alexander Graf
2015-05-12 21:15 ` Richard Henderson
2015-05-12 20:46 ` Alexander Graf
2015-05-12 21:19 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5552622D.6020305@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.