All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Li, ZhenHua" <zhen-hual@hp.com>
To: Baoquan He <bhe@redhat.com>
Cc: alex.williamson@redhat.com, indou.takao@jp.fujitsu.com,
	tom.vaden@hp.com, rwright@hp.com, dwmw2@infradead.org,
	joro@8bytes.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, lisa.mitchell@hp.com,
	jerry.hoemann@hp.com, iommu@lists.linux-foundation.org, "Li,
	ZhenHua" <zhen-hual@hp.com>,
	ddutile@redhat.com, doug.hatch@hp.com,
	ishii.hironobu@jp.fujitsu.com, linux-pci@vger.kernel.org,
	bhelgaas@google.com, billsumnerlinux@gmail.com, li.zhang6@hp.com,
	dyoung@redhat.com, vgoyal@redhat.com
Subject: Re: [PATCH v11 04/10] iommu/vt-d: functions to copy data from old mem
Date: Wed, 13 May 2015 17:13:05 +0800	[thread overview]
Message-ID: <555315A1.5020402@hp.com> (raw)
In-Reply-To: <20150513090035.GE3736@dhcp-128-28.nay.redhat.com>

Hi Baoquan,
I am using a list here to store all the mapped addresses, and unmap them 
out of iounmap.

About the reason, please check the old mails. I cannot remember the 
detailed reasons.

Thanks
Zhenhua

On 05/13/2015 05:00 PM, Baoquan He wrote:
> On 05/11/15 at 05:52pm, Li, Zhen-Hua wrote:
>> Add some functions to copy the data from old kernel.
>> These functions are used to copy context tables and page tables.
>>
>> To avoid calling iounmap between spin_lock_irqsave and spin_unlock_irqrestore,
>> use a link here, store the pointers , and then use iounmap to free them in
>> another place.
>
> Hi Zhenhua,
>
> I remember you mentioned iounmap will cause error inside
> spin_lock_irqsave. Do you know why it happened now? And could you also
> describe why avoid calling iounmap between
> spin_lock_irqsave/unlock_irqsave  is needed here and what's the status
> now?
>
> I think other reviewer may want to know it too.
>
> Thanks
> Baoquan
>


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: "Li, ZhenHua" <zhen-hual@hp.com>
To: Baoquan He <bhe@redhat.com>
Cc: dwmw2@infradead.org, indou.takao@jp.fujitsu.com, joro@8bytes.org,
	vgoyal@redhat.com, dyoung@redhat.com,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, kexec@lists.infradead.org,
	alex.williamson@redhat.com, ddutile@redhat.com,
	ishii.hironobu@jp.fujitsu.com, bhelgaas@google.com,
	doug.hatch@hp.com, jerry.hoemann@hp.com, tom.vaden@hp.com,
	li.zhang6@hp.com, lisa.mitchell@hp.com,
	billsumnerlinux@gmail.com, rwright@hp.com, "Li,
	ZhenHua" <zhen-hual@hp.com>
Subject: Re: [PATCH v11 04/10] iommu/vt-d: functions to copy data from old mem
Date: Wed, 13 May 2015 17:13:05 +0800	[thread overview]
Message-ID: <555315A1.5020402@hp.com> (raw)
In-Reply-To: <20150513090035.GE3736@dhcp-128-28.nay.redhat.com>

Hi Baoquan,
I am using a list here to store all the mapped addresses, and unmap them 
out of iounmap.

About the reason, please check the old mails. I cannot remember the 
detailed reasons.

Thanks
Zhenhua

On 05/13/2015 05:00 PM, Baoquan He wrote:
> On 05/11/15 at 05:52pm, Li, Zhen-Hua wrote:
>> Add some functions to copy the data from old kernel.
>> These functions are used to copy context tables and page tables.
>>
>> To avoid calling iounmap between spin_lock_irqsave and spin_unlock_irqrestore,
>> use a link here, store the pointers , and then use iounmap to free them in
>> another place.
>
> Hi Zhenhua,
>
> I remember you mentioned iounmap will cause error inside
> spin_lock_irqsave. Do you know why it happened now? And could you also
> describe why avoid calling iounmap between
> spin_lock_irqsave/unlock_irqsave  is needed here and what's the status
> now?
>
> I think other reviewer may want to know it too.
>
> Thanks
> Baoquan
>

  reply	other threads:[~2015-05-13  9:14 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11  9:52 [PATCH v11 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel Li, Zhen-Hua
2015-05-11  9:52 ` Li, Zhen-Hua
2015-05-11  9:52 ` Li, Zhen-Hua
2015-05-11  9:52 ` [PATCH v11 01/10] iommu/vt-d: New function to attach domain with id Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52 ` [PATCH v11 02/10] iommu/vt-d: Items required for kdump Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-12  8:17   ` Dave Young
2015-05-12  8:17     ` Dave Young
2015-05-13  1:45     ` Li, ZhenHua
2015-05-13  1:45       ` Li, ZhenHua
2015-05-13  6:31       ` Alexander Duyck
2015-05-13  6:31         ` Alexander Duyck
2015-05-13  8:42       ` Dave Young
2015-05-13  8:42         ` Dave Young
2015-05-13  8:42         ` Dave Young
2015-05-11  9:52 ` [PATCH v11 03/10] iommu/vt-d: Function to get existing context entry Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52 ` [PATCH v11 04/10] iommu/vt-d: functions to copy data from old mem Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-12  8:29   ` Dave Young
2015-05-12  8:29     ` Dave Young
2015-05-12  8:29     ` Dave Young
2015-05-13  9:00   ` Baoquan He
2015-05-13  9:00     ` Baoquan He
2015-05-13  9:13     ` Li, ZhenHua [this message]
2015-05-13  9:13       ` Li, ZhenHua
2015-05-13  9:21       ` Baoquan He
2015-05-13  9:21         ` Baoquan He
2015-06-08 14:15   ` David Woodhouse
2015-06-08 14:15     ` David Woodhouse
     [not found]     ` <1433772935.2952.47.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-06-08 15:21       ` Joerg Roedel
2015-06-08 15:21         ` Joerg Roedel
2015-06-08 15:44         ` David Woodhouse
2015-06-08 15:44           ` David Woodhouse
2015-05-11  9:52 ` [PATCH v11 05/10] iommu/vt-d: Add functions to load and save old re Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-12  8:37   ` Dave Young
2015-05-12  8:37     ` Dave Young
2015-05-12  8:37     ` Dave Young
2015-05-13  1:47     ` Li, ZhenHua
2015-05-13  1:47       ` Li, ZhenHua
2015-05-13  1:47       ` Li, ZhenHua
2015-05-13  8:49       ` Dave Young
2015-05-13  8:49         ` Dave Young
2015-05-11  9:52 ` [PATCH v11 06/10] iommu/vt-d: datatypes and functions used for kdump Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-12  8:48   ` Dave Young
2015-05-12  8:48     ` Dave Young
2015-05-13  8:56   ` Baoquan He
2015-05-13  8:56     ` Baoquan He
2015-05-13  8:56     ` Baoquan He
2015-05-13  8:58     ` Li, ZhenHua
2015-05-13  8:58       ` Li, ZhenHua
2015-05-13  8:58       ` Li, ZhenHua
2015-05-13  9:10       ` Baoquan He
2015-05-13  9:10         ` Baoquan He
2015-05-13  9:10         ` Baoquan He
2015-05-11  9:52 ` [PATCH v11 07/10] iommu/vt-d: enable kdump support in iommu module Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-12  8:52   ` Dave Young
2015-05-12  8:52     ` Dave Young
2015-05-12  8:52     ` Dave Young
2015-05-13  2:10   ` Baoquan He
2015-05-13  2:10     ` Baoquan He
2015-05-13  2:28     ` Li, ZhenHua
2015-05-13  2:28       ` Li, ZhenHua
2015-05-13  2:36       ` Baoquan He
2015-05-13  2:36         ` Baoquan He
2015-05-11  9:52 ` [PATCH v11 08/10] iommu/vt-d: assign new page table for dma_map Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-20 23:52   ` Baoquan He
2015-05-20 23:52     ` Baoquan He
2015-05-21  1:27     ` Li, ZhenHua
2015-05-21  1:27       ` Li, ZhenHua
2015-05-21  6:54       ` Baoquan He
2015-05-21  6:54         ` Baoquan He
2015-05-21  8:40         ` Li, ZhenHua
2015-05-21  8:40           ` Li, ZhenHua
2015-05-21  8:40           ` Li, ZhenHua
2015-05-21 10:11           ` Baoquan He
2015-05-11  9:52 ` [PATCH v11 09/10] iommu/vt-d: Copy functions for irte Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-12  9:00   ` Dave Young
2015-05-12  9:00     ` Dave Young
2015-05-11  9:52 ` [PATCH v11 10/10] iommu/vt-d: Use old irte in kdump kernel Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-11  9:52   ` Li, Zhen-Hua
2015-05-12  6:18 ` [PATCH v11 0/10] iommu/vt-d: Fix intel vt-d faults " Baoquan He
2015-05-12  6:18   ` Baoquan He
2015-05-12  6:18   ` Baoquan He
2015-05-12  9:04 ` Dave Young
2015-05-12  9:04   ` Dave Young
2015-05-12  9:04   ` Dave Young
2015-05-12  9:34 ` Li, Zhen-Hua
2015-05-12  9:34   ` Li, Zhen-Hua
2015-05-12  9:34   ` Li, Zhen-Hua
2015-05-13  1:54 ` Li, ZhenHua
2015-05-13  1:54   ` Li, ZhenHua
2015-05-18 10:05   ` Li, ZhenHua
2015-05-18 10:05     ` Li, ZhenHua
2015-05-18 10:05     ` Li, ZhenHua
2015-05-19  1:13     ` Dave Young
2015-05-19  1:13       ` Dave Young
2015-05-19  7:43       ` Li, ZhenHua
2015-05-19  7:43         ` Li, ZhenHua
2015-05-29 16:21 ` Joerg Roedel
2015-05-30 11:23   ` Li, Zhen-Hua
2015-05-30 11:23     ` Li, Zhen-Hua
2015-05-30 11:23     ` Li, Zhen-Hua
2015-05-30 11:23     ` Li, Zhen-Hua
2015-06-08 14:26 ` David Woodhouse
2015-06-08 14:26   ` David Woodhouse
2015-06-08 14:26   ` David Woodhouse
     [not found]   ` <1433773583.2952.52.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-06-08 15:29     ` Joerg Roedel
2015-06-08 15:29       ` Joerg Roedel
2015-06-08 15:50       ` David Woodhouse
2015-06-08 15:50         ` David Woodhouse
2015-06-08 15:50         ` David Woodhouse
2015-06-08 16:13         ` Joerg Roedel
2015-06-09 12:55           ` David Woodhouse
2015-06-09 12:55             ` David Woodhouse
2015-06-10  9:21             ` Joerg Roedel
2015-06-10  9:32               ` Li, ZhenHua
2015-06-10  9:32                 ` Li, ZhenHua
2015-06-10  9:32                 ` Li, ZhenHua
2015-06-10 14:10                 ` David Woodhouse
2015-06-10 14:10                   ` David Woodhouse
2015-06-10 14:10                   ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555315A1.5020402@hp.com \
    --to=zhen-hual@hp.com \
    --cc=alex.williamson@redhat.com \
    --cc=bhe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=billsumnerlinux@gmail.com \
    --cc=ddutile@redhat.com \
    --cc=doug.hatch@hp.com \
    --cc=dwmw2@infradead.org \
    --cc=dyoung@redhat.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=ishii.hironobu@jp.fujitsu.com \
    --cc=jerry.hoemann@hp.com \
    --cc=joro@8bytes.org \
    --cc=kexec@lists.infradead.org \
    --cc=li.zhang6@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lisa.mitchell@hp.com \
    --cc=rwright@hp.com \
    --cc=tom.vaden@hp.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.