From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Cong Wang <xiyou.wangcong@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: netns: use a spin_lock to protect nsid management
Date: Wed, 13 May 2015 11:58:25 +0000 [thread overview]
Message-ID: <55533C61.2030206@6wind.com> (raw)
In-Reply-To: <CAM_iQpUSgpeL_Dy+U+KrBd=h3bhm03vASupdO-9dSs+CKYjNeg@mail.gmail.com>
Le 12/05/2015 21:16, Cong Wang a écrit :
[snip]
> Also why do we have to disable IRQ when holding the spinlock?
> IOW, which case takes the spin lock in IRQ context?
peernet2id() is called by do_one_broadcast() (net/netlink/af_netlink.c). So
every callers of netlink_broadcast[_filtered]()/nlmsg_unicast()
/nlmsg_multicast() may needs this lock.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Cong Wang <xiyou.wangcong@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: netns: use a spin_lock to protect nsid management
Date: Wed, 13 May 2015 13:58:25 +0200 [thread overview]
Message-ID: <55533C61.2030206@6wind.com> (raw)
In-Reply-To: <CAM_iQpUSgpeL_Dy+U+KrBd=h3bhm03vASupdO-9dSs+CKYjNeg@mail.gmail.com>
Le 12/05/2015 21:16, Cong Wang a écrit :
[snip]
> Also why do we have to disable IRQ when holding the spinlock?
> IOW, which case takes the spin lock in IRQ context?
peernet2id() is called by do_one_broadcast() (net/netlink/af_netlink.c). So
every callers of netlink_broadcast[_filtered]()/nlmsg_unicast()
/nlmsg_multicast() may needs this lock.
next prev parent reply other threads:[~2015-05-13 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:52 netns: use a spin_lock to protect nsid management Dan Carpenter
2015-05-12 19:16 ` Cong Wang
2015-05-12 19:16 ` Cong Wang
2015-05-13 11:58 ` Nicolas Dichtel [this message]
2015-05-13 11:58 ` Nicolas Dichtel
2015-05-13 11:37 ` Nicolas Dichtel
2015-05-13 11:37 ` Nicolas Dichtel
2015-05-13 11:43 ` [PATCH net-next] netns: fix unbalanced spin_lock on error Nicolas Dichtel
2015-05-13 11:43 ` Nicolas Dichtel
2015-05-15 2:36 ` David Miller
2015-05-15 2:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55533C61.2030206@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.