From: Stephen Boyd <sboyd@codeaurora.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Mike Turquette <mturquette@linaro.org>,
kernel@pengutronix.de, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: Automatic clock disabling on clk_put()
Date: Wed, 13 May 2015 12:45:12 -0700 [thread overview]
Message-ID: <5553A9C8.2070701@codeaurora.org> (raw)
In-Reply-To: <20150513064550.GE28888@pengutronix.de>
On 05/12/15 23:45, Uwe Kleine-König wrote:
>
>> that hard to call clk_disable_unprepare() on a clock at the end of an
>> error path? Maybe you could add a devm_clk_get_prepare_enable() that
>> does what you want and then call clk_disable_unprepare on the exit path?
> You mean clk_disable_unprepare is called in the same function that calls
> clk_put I assume such that you don't have to do anything in the exit
> path.
>
Yes that's what I mean.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: Automatic clock disabling on clk_put()
Date: Wed, 13 May 2015 12:45:12 -0700 [thread overview]
Message-ID: <5553A9C8.2070701@codeaurora.org> (raw)
In-Reply-To: <20150513064550.GE28888@pengutronix.de>
On 05/12/15 23:45, Uwe Kleine-K?nig wrote:
>
>> that hard to call clk_disable_unprepare() on a clock at the end of an
>> error path? Maybe you could add a devm_clk_get_prepare_enable() that
>> does what you want and then call clk_disable_unprepare on the exit path?
> You mean clk_disable_unprepare is called in the same function that calls
> clk_put I assume such that you don't have to do anything in the exit
> path.
>
Yes that's what I mean.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-13 19:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 6:01 Automatic clock disabling on clk_put() Sascha Hauer
2015-05-11 6:01 ` Sascha Hauer
2015-05-12 23:23 ` Stephen Boyd
2015-05-12 23:23 ` Stephen Boyd
2015-05-13 6:45 ` Uwe Kleine-König
2015-05-13 6:45 ` Uwe Kleine-König
2015-05-13 19:45 ` Stephen Boyd [this message]
2015-05-13 19:45 ` Stephen Boyd
2015-05-13 20:12 ` Russell King - ARM Linux
2015-05-13 20:12 ` Russell King - ARM Linux
2015-05-13 6:47 ` Sascha Hauer
2015-05-13 6:47 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5553A9C8.2070701@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.