From: Kukjin Kim <kgene@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v3 2/2] ARM: EXYNOS: Use of_machine_is_compatible instead ofsoc_is_exynos4
Date: Thu, 14 May 2015 11:41:19 +0900 [thread overview]
Message-ID: <55540B4F.6060607@kernel.org> (raw)
In-Reply-To: <1431307646-10779-2-git-send-email-k.kozlowski@samsung.com>
On 05/11/15 10:27, Krzysztof Kozlowski wrote:
> of_machine_is_compatible() seems to be preferred over soc_is_exynos4().
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
> Changes since v2:
> 1. New patch, requested by Kukjin Kim.
> ---
> arch/arm/mach-exynos/exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index c3bfbba3006d..5917a30eee33 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -179,7 +179,7 @@ static void __init exynos_init_io(void)
> */
> void exynos_set_delayed_reset_assertion(bool enable)
> {
> - if (soc_is_exynos4()) {
> + if (of_machine_is_compatible("samsung,exynos4")) {
> unsigned int tmp, core_id;
>
> for (core_id = 0; core_id < num_possible_cpus(); core_id++) {
Maybe we need to change the compatible for exynos4415.dtsi? because no
exynos4 in the compatible...Applied, anyway.
Thanks,
Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] ARM: EXYNOS: Use of_machine_is_compatible instead ofsoc_is_exynos4
Date: Thu, 14 May 2015 11:41:19 +0900 [thread overview]
Message-ID: <55540B4F.6060607@kernel.org> (raw)
In-Reply-To: <1431307646-10779-2-git-send-email-k.kozlowski@samsung.com>
On 05/11/15 10:27, Krzysztof Kozlowski wrote:
> of_machine_is_compatible() seems to be preferred over soc_is_exynos4().
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
> Changes since v2:
> 1. New patch, requested by Kukjin Kim.
> ---
> arch/arm/mach-exynos/exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index c3bfbba3006d..5917a30eee33 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -179,7 +179,7 @@ static void __init exynos_init_io(void)
> */
> void exynos_set_delayed_reset_assertion(bool enable)
> {
> - if (soc_is_exynos4()) {
> + if (of_machine_is_compatible("samsung,exynos4")) {
> unsigned int tmp, core_id;
>
> for (core_id = 0; core_id < num_possible_cpus(); core_id++) {
Maybe we need to change the compatible for exynos4415.dtsi? because no
exynos4 in the compatible...Applied, anyway.
Thanks,
Kukjin
next prev parent reply other threads:[~2015-05-14 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 1:27 [PATCH v3 1/2] ARM: EXYNOS: Fix failed second suspend on Exynos4 Krzysztof Kozlowski
2015-05-11 1:27 ` Krzysztof Kozlowski
2015-05-11 1:27 ` [PATCH v3 2/2] ARM: EXYNOS: Use of_machine_is_compatible instead of soc_is_exynos4 Krzysztof Kozlowski
2015-05-11 1:27 ` Krzysztof Kozlowski
2015-05-14 2:41 ` Kukjin Kim [this message]
2015-05-14 2:41 ` [PATCH v3 2/2] ARM: EXYNOS: Use of_machine_is_compatible instead ofsoc_is_exynos4 Kukjin Kim
2015-05-14 4:37 ` Krzysztof Kozlowski
2015-05-14 4:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55540B4F.6060607@kernel.org \
--to=kgene@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.