From: David Vrabel <david.vrabel@citrix.com>
To: Tim Deegan <tim@xen.org>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jennifer Herbert <jennifer.herbert@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCHv4 5/5] x86: reduce struct hvm_domain size
Date: Thu, 14 May 2015 13:08:12 +0100 [thread overview]
Message-ID: <5554902C.10609@citrix.com> (raw)
In-Reply-To: <20150514112435.GF81528@deinos.phlegethon.org>
On 14/05/15 12:24, Tim Deegan wrote:
> At 15:37 +0100 on 11 May (1431358625), David Vrabel wrote:
>> Pack struct hvm_domain to reduce it by 8 bytes. Thus reducing the
>> size of struct domain by 8 bytes.
>
> In my builds (non-debug, on current staging), this makes no difference
> to struct domain. struct hvm_domain gets 8 bytes smaller (2144 ->
> 2136), but struct arch_domain remains at 2944 bytes (it just gets an
> extra 8 bytes in the padding at the end to round it up to
> __cacheline_aligned).
It used to make a difference. Perhaps some other recently change
negates the benefit?
In which case, this patch could be dropped.
David
prev parent reply other threads:[~2015-05-14 12:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 14:37 [PATCHv5 0/5] Use ticket locks for spinlocks David Vrabel
2015-05-11 14:37 ` [PATCHv4 1/5] x86: provide add_sized() David Vrabel
2015-05-13 9:23 ` Jan Beulich
2015-05-13 9:35 ` David Vrabel
2015-05-13 9:48 ` Jan Beulich
2015-05-11 14:37 ` [PATCHv4 2/5] arm: " David Vrabel
2015-05-11 14:45 ` David Vrabel
2015-05-13 9:26 ` Jan Beulich
2015-05-11 14:37 ` [PATCHv4 3/5] xen: use ticket locks for spin locks David Vrabel
2015-05-13 9:31 ` Jan Beulich
2015-05-14 10:36 ` Tim Deegan
2015-05-14 20:05 ` Jan Beulich
2015-05-14 20:51 ` Jan Beulich
2015-05-14 20:55 ` Tim Deegan
2015-05-14 21:01 ` Jan Beulich
2015-05-11 14:37 ` [PATCHv4 4/5] x86, arm: remove asm/spinlock.h from all architectures David Vrabel
2015-05-11 14:37 ` [PATCHv4 5/5] x86: reduce struct hvm_domain size David Vrabel
2015-05-14 11:24 ` Tim Deegan
2015-05-14 12:08 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5554902C.10609@citrix.com \
--to=david.vrabel@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=jennifer.herbert@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.