All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Michal Hocko <miso@dhcp22.suse.cz>
Cc: mtk.manpages@gmail.com, Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux API <linux-api@vger.kernel.org>,
	linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH 2/2] mmap2: clarify MAP_POPULATE
Date: Thu, 14 May 2015 15:36:16 +0200	[thread overview]
Message-ID: <5554A4D0.1020405@gmail.com> (raw)
In-Reply-To: <1431527892-2996-3-git-send-email-miso@dhcp22.suse.cz>

On 05/13/2015 04:38 PM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.cz>
> 
> David Rientjes has noticed that MAP_POPULATE wording might promise much
> more than the kernel actually provides and intend to provide. The
> primary usage of the flag is to pre-fault the range. There is no
> guarantee that no major faults will happen later on. The pages might
> have been reclaimed by the time the process tries to access them.

Yes, thanks, Michal -- that's a good point to make clearer.
Applied, with Reviewed-by: from Eric added.

Cheers,

Michael

> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> ---
>  man2/mmap.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/mmap.2 b/man2/mmap.2
> index 1486be2e96b3..dcf306f2f730 100644
> --- a/man2/mmap.2
> +++ b/man2/mmap.2
> @@ -284,7 +284,7 @@ private writable mappings.
>  .BR MAP_POPULATE " (since Linux 2.5.46)"
>  Populate (prefault) page tables for a mapping.
>  For a file mapping, this causes read-ahead on the file.
> -Later accesses to the mapping will not be blocked by page faults.
> +This will help to reduce blocking on page faults later.
>  .BR MAP_POPULATE
>  is supported for private mappings only since Linux 2.6.23.
>  .TP
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Michal Hocko <miso@dhcp22.suse.cz>
Cc: mtk.manpages@gmail.com, Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux API <linux-api@vger.kernel.org>,
	linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH 2/2] mmap2: clarify MAP_POPULATE
Date: Thu, 14 May 2015 15:36:16 +0200	[thread overview]
Message-ID: <5554A4D0.1020405@gmail.com> (raw)
In-Reply-To: <1431527892-2996-3-git-send-email-miso@dhcp22.suse.cz>

On 05/13/2015 04:38 PM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.cz>
> 
> David Rientjes has noticed that MAP_POPULATE wording might promise much
> more than the kernel actually provides and intend to provide. The
> primary usage of the flag is to pre-fault the range. There is no
> guarantee that no major faults will happen later on. The pages might
> have been reclaimed by the time the process tries to access them.

Yes, thanks, Michal -- that's a good point to make clearer.
Applied, with Reviewed-by: from Eric added.

Cheers,

Michael

> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> ---
>  man2/mmap.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/mmap.2 b/man2/mmap.2
> index 1486be2e96b3..dcf306f2f730 100644
> --- a/man2/mmap.2
> +++ b/man2/mmap.2
> @@ -284,7 +284,7 @@ private writable mappings.
>  .BR MAP_POPULATE " (since Linux 2.5.46)"
>  Populate (prefault) page tables for a mapping.
>  For a file mapping, this causes read-ahead on the file.
> -Later accesses to the mapping will not be blocked by page faults.
> +This will help to reduce blocking on page faults later.
>  .BR MAP_POPULATE
>  is supported for private mappings only since Linux 2.6.23.
>  .TP
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

  parent reply	other threads:[~2015-05-14 13:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 14:38 [PATCH 0/2] man-pages: clarify MAP_LOCKED semantic Michal Hocko
2015-05-13 14:38 ` Michal Hocko
     [not found] ` <1431527892-2996-1-git-send-email-miso-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-05-13 14:38   ` [PATCH 1/2] mmap.2: " Michal Hocko
2015-05-13 14:38     ` Michal Hocko
2015-05-13 14:38     ` Michal Hocko
2015-05-13 14:45     ` Eric B Munson
     [not found]       ` <20150513144506.GD1227-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
2015-05-13 14:48         ` Eric B Munson
2015-05-13 14:48           ` Eric B Munson
2015-05-14  8:01         ` Michal Hocko
2015-05-14  8:01           ` Michal Hocko
2015-05-14  8:01           ` Michal Hocko
2015-05-14 13:36     ` Michael Kerrisk (man-pages)
2015-05-14 13:36       ` Michael Kerrisk (man-pages)
     [not found]     ` <1431527892-2996-2-git-send-email-miso-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2016-05-11 11:07       ` Peter Zijlstra
2016-05-11 11:07         ` Peter Zijlstra
2016-05-11 11:07         ` Peter Zijlstra
2016-05-11 11:18         ` Peter Zijlstra
2016-05-11 11:18           ` Peter Zijlstra
     [not found]         ` <57331275.9000805-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-05-11 11:32           ` Michal Hocko
2016-05-11 11:32             ` Michal Hocko
2016-05-11 11:32             ` Michal Hocko
2015-05-13 14:38 ` [PATCH 2/2] mmap2: clarify MAP_POPULATE Michal Hocko
2015-05-13 14:38   ` Michal Hocko
     [not found]   ` <1431527892-2996-3-git-send-email-miso-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-05-13 14:47     ` Eric B Munson
2015-05-13 14:47       ` Eric B Munson
2015-05-14 13:36   ` Michael Kerrisk (man-pages) [this message]
2015-05-14 13:36     ` Michael Kerrisk (man-pages)
2015-05-15  0:13   ` David Rientjes
2015-05-15  0:13     ` David Rientjes
2015-05-18  9:12 ` [PATCH 0/2] man-pages: clarify MAP_LOCKED semantic Michal Hocko
2015-05-18  9:12   ` Michal Hocko
2015-05-18  9:12   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5554A4D0.1020405@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=miso@dhcp22.suse.cz \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.